https://bugzilla.redhat.com/show_bug.cgi?id=2177572
--- Comment #3 from Neal Gompa ngompa13@gmail.com --- (In reply to Yaakov Selkowitz from comment #2)
Package Review
NOTES:
- Does it make sense to carry forward RPMFusion's %changelog?
I didn't completely write this package spec from scratch, so yes, I think so. That's the easy way to ensure attribution is preserved.
- Sources are marked GPL-2.0-or-later but COPYING is GPL3 (probably due to
autotools)
I can file a ticket with upstream to put the right COPYING file and drop it from the package for now.
- WRT files-duplicate warning, the icon copying (and hence the use of
hicolor-icon-theme and %_datadir/icons) could be removed from the RPM build and handled solely in the flatpak build with cleanup-commands.
I'd prefer to leave this alone for the rpm build. I could file a ticket asking them to update their icon handling though.
- Use of AC_PROG_LIBTOOL doesn't bother me.
Meh.