https://bugzilla.redhat.com/show_bug.cgi?id=2174227
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ Status|ASSIGNED |POST
--- Comment #8 from Fabio Valentini decathorpe@gmail.com --- Ok, package looks good to me.
You might want to consider replacing "%{_libdir}/%{lib}.so.0*" with "%{_libdir}/%{lib}.so.0{,.*}". (see https://docs.fedoraproject.org/en-US/packaging-guidelines/#_listing_shared_l...) but that's a minor thing.
The ABI / API compatibility with libimagequant v2 is not part of the package review, but please make sure that maintainers of dependent packages (and the "devel" list) are notified of the change.
===
Package was generated with rust2rpm, simplifying the review.
- package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification and is acceptable for Fedora - license file is included with %license in %files - license of statically linked components is reflected in License tag - shared C-ABI library built and installed correctly - package complies with Rust Packaging Guidelines
Package APPROVED.
===
Recommended post-import rust-sig tasks:
- add @rust-sig with "commit" access as package co-maintainer
- set bugzilla assignee overrides to @rust-sig (optional)
- set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate
- track package in koschei for all built branches