Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: oyranos - The Oyranos Colour Management System (CMS)
https://bugzilla.redhat.com/show_bug.cgi?id=239936
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2008-03-04 02:25 EST ------- For 0.1.7-9:
* Requires: - Would you explain why -devel subpackage "Requires" color-filesystem?
* From build.log: ------------------------------------------------------------------ 901 /builddir/build/BUILD/oyranos-0.1.7/oyranos_monitor.c:1386: Warning: The following parameters of oyGetDisplayNameFromPosition(const char *display_name, int x, int y, oyAllocFunc_t allocate_func) are not documented: 902 parameter display_name 903 sh: dot: command not found 904 Problems running dot: exit code=127, command='dot', arguments='"structoyComp__s____coll__graph.dot" -Tpng -o "structoyComp__s____coll__graph.png"' 905 /builddir/build/BUILD/oyranos-0.1.7/oyranos_config.h:41: Warning: Found unknown command `\autor' 906 /builddir/build/BUILD/oyranos-0.1.7/oyranos_config.h:65: Warning: Found unknown command `\autor' 907 sh: dot: command not found 908 Problems running dot: exit code=127, command='dot', arguments='"graph_legend.dot" -Tpng -o "graph_legend.png"' ------------------------------------------------------------------ - Perhaps graphviz is missing from BuildRequires (as you create document files by doxygen).
* Mandir - From spec file: ------------------------------------------------------------------ mv $RPM_BUILD_ROOT%{_mandir}/man1/oyranos-config.1 $RPM_BUILD_ROOT%{_mandir}/man3/oyranos-config.3 ------------------------------------------------------------------ Well, moving -config man file to section 3 is correct, however this also requires to fix man file itself. Currently "man oyranos-config" shows the section is 1.
* Comment on %scriptlet part ------------------------------------------------------------------ %post #if [ "`elektra-kdb ls system/sw/oyranos 2>/dev/zero | wc -l`" -eq 0 ]; then # oyranos-policy %{_settingscolordir}/office.policy.xml #fi || : ------------------------------------------------------------------ - Then "rpm -q --scripts oyranos" shows this, which is not desirable because this actually executes a /bin/sh script file (with all comments) needlessly. The correct method is to put this part in %if macro like: ------------------------------------------------------------------ %if 0 %post ...... %endif ------------------------------------------------------------------
* Directory ownership issue - On my system: ------------------------------------------------------------------ [tasaka1@localhost ~]$ LANG=C rpm -qf /usr/share/color/settings/office.policy.xml oyranos-0.1.7-9.fc9.i386 [tasaka1@localhost ~]$ LANG=C rpm -qf /usr/share/color/settings/ file /usr/share/color/settings is not owned by any package ------------------------------------------------------------------
! Multilib conflict - From configure: ------------------------------------------------------------------ 584 test -n "$ECHO" && $ECHO "sbindir=$sbindir" >> $CONF_SH 585 test -n "$ECHO" && $ECHO "libdir=$libdir" >> $CONF_SH 586 test -n "$ECHO" && $ECHO "includedir=$includedir" >> $CONF_SH ------------------------------------------------------------------ (here $CONF_SH is oyranos-config) This configure part creates oyranos-config different between 32 bits arch vs 64 bits arch.
For scripts installed under %_bindir and packaged in -devel package, this multilib conflict is not allowed. * Please check http://fedoraproject.org/wiki/PackagingDrafts/MultilibTricks and try to fix this multilib conflict. * Or if you feel fixing configure is not easy, you can - move oyranos-config to oyranos-config-{32,64} according to the architecture - Then install oyranos-config as: ------------------------------------------------------------------- #!/bin/sh ARCH=$(uname -s)
case $ARCH in x86_64 | ia64 | s390 ) exec oyranos-config-64 $* ;; * ) exec oyranos-config-32 $* ;; esac ------------------------------------------------------------------- for example (I guess this work).