https://bugzilla.redhat.com/show_bug.cgi?id=1832392
Christopher Brown chris.brown@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(mail@fabian-affol | |ter.ch)
--- Comment #4 from Christopher Brown chris.brown@redhat.com --- Thanks for the review Fabian.
(In reply to Fabian Affolter from comment #3)
Issues:
- Python packages must not contain %{pythonX_site(lib|arch)}/* in %files Note: Package contains %{pythonX_site(lib|arch)}/* in %files See: https://pagure.io/packaging-committee/issue/782
Fixed.
- %{?python_enable_dependency_generator} can be removed, the dependency
generator is enabled by default
Fixed.
- Remove "%global common_desc" this is a superfluous variable. Place the
content directly in the "Summery:" tag and re-use %{summary} later
Fixed.
- Upstream has a test suite. This means switching to the upstream source
from GItHub.
Can you clarify as this is included and is being run?
+ /usr/bin/python3 -m pytest ==================================================================================================================================================== test session starts ===================================================================================================================================================== platform linux -- Python 3.8.2, pytest-4.6.9, py-1.8.0, pluggy-0.13.0 rootdir: /home/chribrow/rpmbuild/BUILD/typeguard-2.7.1, inifile: setup.cfg, testpaths: tests plugins: typeguard-2.7.1, cov-2.8.1 collected 213 items
tests/test_importhook.py ...............
[ 7%] tests/test_typeguard.py ...................................................................................................................................................................................
[ 91%] tests/test_typeguard_py36.py ...........
[ 96%] tests/test_typeguard_py38.py ........
[100%]
----------- coverage: platform linux, python 3.8.2-final-0 ----------- Name Stmts Miss Cover Missing ---------------------------------------------------------- typeguard/__init__.py 536 183 66% 1-83, 102, 106-131, 157, 164, 169, 190, 196, 201, 215, 229, 236-237, 241-242, 277, 291, 312, 325, 337, 350, 367-368, 383, 393, 396, 413, 433, 436, 471, 477, 479, 482-486, 495-500, 507-542, 560, 574, 578, 580, 610, 626-627, 640, 658-659, 675-676, 685-688, 691-700, 716-717, 725-728, 731-740, 751-761, 839-875, 879, 890-903, 918-921, 925-938, 954, 969, 973 typeguard/importhook.py 93 34 63% 1-13, 17, 21-22, 25, 41, 50, 69-70, 79, 85-96, 100, 107-109, 120-124, 127, 130, 133, 136-140, 159 typeguard/pytest_plugin.py 9 7 22% 1-11, 14-15 ---------------------------------------------------------- TOTAL 638 224 65%
================================================================================================================================================= 213 passed in 1.04 seconds =================================================================================================================================================