https://bugzilla.redhat.com/show_bug.cgi?id=2254460
--- Comment #3 from Neal Gompa ngompa13@gmail.com --- Initial spec review:
Release: 3%{?dist}
You're using %autochangelog in %changelog, so you'll want to use %autorelease here too.
BuildRequires: lua5.1-devel, lua5.1 [...] sed -i -e 's/luac/luac-5.1/g' configure.ac
This should not be necessary. VLC 3.x is compatible with Lua 5.4: https://code.videolan.org/videolan/vlc/-/merge_requests/2557
%package plugin-gstreamer Summary: VLC media player GStreamer codec plugin Requires: %{name}-libs%{?_isa} = %{epoch}:%{version}-%{release} Requires: %{name}-plugins-base%{?_isa} = %{epoch}:%{version}-%{release} Requires: gstreamer1-plugins-good%{?_isa} Requires: gstreamer1-plugins-bad-free%{?_isa} Recommends: gstreamer1-plugin-libav%{?_isa}
Can you also add "Recommends: gstreamer1-plugin-openh264%{?_isa}" here?
# GNOME 2 script, not compatible with GNOME 3+
rm -f %{buildroot}%{_datadir}/vlc/utils/gnome-vlc-default.sh
Would this be used by MATE, since it's a GNOME 2 descendent?
%transfiletriggerin libs -- %{vlc_plugindir}
%{_libdir}/vlc/vlc-cache-gen %{vlc_plugindir} &>/dev/null || :
%transfiletriggerpostun libs -- %{vlc_plugindir} %{_libdir}/vlc/vlc-cache-gen %{vlc_plugindir} &>/dev/null || :
Do we need a posttrans for vlc-libs itself so that it runs on initial install? Or does this fire even when you initially install vlc?