Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=522920
--- Comment #16 from David Timms dtimms@iinet.net.au 2010-03-19 20:37:10 EDT --- (In reply to comment #14)
Sorry for late reply.
# MUST: Packages containing GUI applications must include a %{name}.desktop
=> FAIL
The guideline says 'Packages containing GUI applications must include a %{name}.desktop' but this package does not contain '%{name}.desktop'. I have no idea whether this is a blocker since this package is not 'GUI application'.
I'll ask on packaging list whether that applies to command line tools that are being given a mime-type/ open with entry rather than a GUI menu entry.
# MUST: If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in bugzilla, describing the reason that the package does not compile/build/work on that architecture. The bug number MUST be placed in a comment, next to the corresponding ExcludeArch line. => FAIL(build error on ppc and ppc64)
=> now OK
The new SRPM successfully built on ppc and ppc64.
I have reverted the "dont test on ppc ppc64" changes. With the current 1.4.7 version the tests succeed on x86_64, and the koji scratch build succeeds. I note however, that it only built x86 arches.
Building with f-12 as target succeeds on the ppcX arches: http://koji.fedoraproject.org/koji/taskinfo?taskID=2064055
Updated package: http://members.iinet.net.au/~timmsy/tnef/tnef.spec http://members.iinet.net.au/~timmsy/tnef/tnef-1.4.7-1.fc12.src.rpm also there is a diff: tnef.spec.1.4.6-5.to.tnef.1.4.7-1 , with the intent of making it easier to pick out changes.
Naoki, do you have a few cycles to finalise this review ?