https://bugzilla.redhat.com/show_bug.cgi?id=2224783
--- Comment #4 from Mattia Verga mattia.verga@proton.me --- (In reply to Felix Wang from comment #3)
I only see an issue: static library should be avoided as possible. The remaining things LGTM.
This is a header only library, so adheres to https://docs.fedoraproject.org/en-US/packaging-guidelines/#packaging-static-...
BTW, if you're willing to make a formal review, you should set the ticket status to ASSIGNED and set yourself as the assignee. Thanks.