https://bugzilla.redhat.com/show_bug.cgi?id=2126348
Jitka Plesnikova jplesnik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #6 from Jitka Plesnikova jplesnik@redhat.com --- (In reply to Jitka Plesnikova from comment #4)
BuildRequires FIX: Please add build-requires:
<...> Almost all missing dependencies were added only one is missing. FIX: Add BR - perl(Config) - spec file:54
+BuildRequires: perl(Config) Ok.
FIX: Please add run-requires 'perl(constant)'
Still need to be fixed
# Runtime +Requires: perl(constant) Requires: perl(XSLoader) Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
@@ -63,6 +63,7 @@ Summary: Tests for %{name} Requires: %{name} = %{?epoch:%{epoch}:}%{version}-%{release} Requires: perl(Test::Harness) +Requires: perl(constant)
The run-require should be added only to sub-package perl-Tickit-tests. FIX: Remove run-requires 'perl(constant)' from the main package perl-Tickit, because it is found by generators.
Please correct 'FIX' item. Otherwise the package is in line with Fedora and Perl packaging guide lines.
Resolution: Approved