Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ocrad -- An Optical Character Recognition program
https://bugzilla.redhat.com/show_bug.cgi?id=435433
------- Additional Comments From tsmetana@redhat.com 2008-02-29 07:20 EST ------- (In reply to comment #1)
1)make command should be using parallel make make %{?_smp_mflags}
Right.
2)your build section should be %configure make CXXFLAGS="$RPM_OPT_FLAGS" %{?_smp_mflags}
This package doesn't use autotools and its configure script accepts compiler flags as parameters. What would be the reason no to use that? I can change it, of course.
- make install should be called as
make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p"
I found nothing like this in the guidelines. I might have overlooked it of course. Could you point me at the reasoning for this please?
- %files section should look like
%defattr(-,root,root,-) %doc AUTHORS COPYING ChangeLog NEWS README TODO %{_bindir}/ocrad %{_mandir}/man1/* %{_infodir}/ocrad.info.gz
The package installs info and manual pages with +x permission. Therefore I need the %attr otherwise rpmlint would complain.
- missing requires
Requires(post): /sbin/install-info Requires(preun): /sbin/install-info
Right.
As for the building problem: my rawhide mock failed to update, so I built the package on F-8... But there are no shiny new gcc-4.3 C++ headers. This will require a patch.
Thanks for looking. I'll post an update after I solve the compilation errors.