https://bugzilla.redhat.com/show_bug.cgi?id=2174227
Bug ID: 2174227 Summary: Review Request: rust-imagequant-sys - Convert 24/32-bit images to 8-bit palette with alpha channel Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: h-k-81@hotmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://blinxen.fedorapeople.org/rust-imagequant-sys/rust-imagequant-sys.spe... SRPM URL: https://blinxen.fedorapeople.org/rust-imagequant-sys/rust-imagequant-sys-4.0... Description: Convert 24/32-bit images to 8-bit palette with alpha channel. C API/FFI libimagequant that powers pngquant lossy PNG compressor. Dual-licensed like pngquant. See https://pngquant.org for details.
Fedora Account System Username: blinxen
This is a re-review request for a package rename. This package will replace `libimagequant` [1]. `libimagequant` will still live as a subpackage of `rust-imagequant-sys` (See spec file). I consciously did not set `Provides` or `Obsoletes` [2] because the "oldpackagename" still exists but as a subpackage. Please correct me if my reasoning is wrong here.
Reason for renaming the package: The upstream project rewrote the library in rust and this crate contains the C bindings of the rust code. According to the packaging guidelines [3], "Source packages for Rust crates which contain a library with a public API MUST be named rust-$crate".
The spec file has already had a first review (thanks! @decathorpe) in this PR: https://src.fedoraproject.org/rpms/libimagequant/pull-request/2
[1] https://src.fedoraproject.org/rpms/libimagequant [2] https://docs.fedoraproject.org/en-US/packaging-guidelines/#renaming-or-repla... [3] https://docs.fedoraproject.org/en-US/packaging-guidelines/Rust/#_library_cra...