Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: xcb-util-image - Port of Xlib's XImage and XShmImage functions on top of libxcb
https://bugzilla.redhat.com/show_bug.cgi?id=760155
Summary: Review Request: xcb-util-image - Port of Xlib's XImage and XShmImage functions on top of libxcb Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: thomas.moschny@gmx.de QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: ---
Spec URL: http://thm.fedorapeople.org/xcb-util-image/xcb-util-image.spec SRPM URL: http://thm.fedorapeople.org/xcb-util-image/xcb-util-image-0.3.8-1.fc16.src.r... Description: XCB util-image module provides the following library:
- image: Port of Xlib's XImage and XShmImage functions.
Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=3563741
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=760155
--- Comment #1 from Thomas Moschny thomas.moschny@gmx.de 2012-04-05 10:39:52 EDT --- Spec URL: http://thm.fedorapeople.org/xcb-util-image/xcb-util-image.spec SRPM URL: http://thm.fedorapeople.org/xcb-util-image/xcb-util-image-0.3.8-2.fc18.src.r...
Spec file updates: - Drop BR on pkgconfig - Drop BuildRoot tag - Drop defattr lines - Use %{_isa} in explicit dependency - Remove chrpath, seems unnecessary
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=760155
Tom "spot" Callaway tcallawa@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |tcallawa@redhat.com AssignedTo|nobody@fedoraproject.org |tcallawa@redhat.com Flag| |fedora-review+
--- Comment #2 from Tom "spot" Callaway tcallawa@redhat.com 2012-04-05 10:57:35 EDT --- Review =======
- rpmlint checks return:
xcb-util-image.src: W: spelling-error Summary(en_US) libxcb -> Libby xcb-util-image.x86_64: W: spelling-error Summary(en_US) libxcb -> Libby 4 packages and 0 specfiles checked; 0 errors, 2 warnings.
All safe to ignore.
- package meets naming guidelines - package meets packaging guidelines - license (MIT) OK, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file - devel package ok - no .la files - post/postun ldconfig ok - devel requires base package n-v-r
APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=760155
Thomas Moschny thomas.moschny@gmx.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #3 from Thomas Moschny thomas.moschny@gmx.de 2012-04-05 11:28:05 EDT --- Thanks for the review, spot!
New Package SCM Request ======================= Package Name: xcb-util-image Short Description: Port of Xlib's XImage and XShmImage functions on top of libxcb Owners: thm Branches: f17 InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=760155
--- Comment #4 from Jon Ciesla limburgher@gmail.com 2012-04-05 12:11:52 EDT --- Git done (by process-git-requests).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=760155
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=760155
--- Comment #5 from Fedora Update System updates@fedoraproject.org 2012-04-05 18:25:12 EDT --- xcb-util-image-0.3.8-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/xcb-util-image-0.3.8-2.fc17
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=760155
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #6 from Fedora Update System updates@fedoraproject.org 2012-04-06 19:23:43 EDT --- xcb-util-image-0.3.8-2.fc17 has been pushed to the Fedora 17 testing repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=760155
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |xcb-util-image-0.3.8-2.fc17 Resolution| |ERRATA Last Closed| |2012-04-14 00:29:43
--- Comment #7 from Fedora Update System updates@fedoraproject.org 2012-04-14 00:29:43 EDT --- xcb-util-image-0.3.8-2.fc17 has been pushed to the Fedora 17 stable repository.
package-review@lists.fedoraproject.org