Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: edg-gridftp-client - Command line clients to GridFTP libraries
https://bugzilla.redhat.com/show_bug.cgi?id=719456
Summary: Review Request: edg-gridftp-client - Command line clients to GridFTP libraries Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: steve.traylen@cern.ch QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: ---
Spec URL: http://straylen.web.cern.ch/straylen/rpms/edg-griftp-client/edg-gridftp-clie... SRPM URL: http://straylen.web.cern.ch/straylen/rpms/edg-griftp-client/edg-gridftp-clie...
Description: The edg-gridftp-client package is a thin command line interface on top of the GridFTP libraries supplied by Globus. They do, however, represent a useful set of commands to do basic management of files on a GridFTP server.
Scratch builds: rawhide scratch: http://koji.fedoraproject.org/koji/taskinfo?taskID=3184078 epel4 scratch: http://koji.fedoraproject.org/koji/taskinfo?taskID=3184096
rpmlint results: $ rpmlint *.rpm edg-gridftp-client.src: W: invalid-url Source0: edg-gridftp-client-1.2.9.2.tar.gz edg-gridftp-client.src: W: invalid-url Source0: edg-gridftp-client-1.2.9.2.tar.gz edg-gridftp-client.src: W: invalid-url Source0: edg-gridftp-client-1.2.9.2.tar.gz
which is expected given this is a tarball from RCS. http://fedoraproject.org/wiki/Packaging:SourceURL#Using_Revision_Control
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=719456
Mattias Ellert mattias.ellert@fysast.uu.se changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |mattias.ellert@fysast.uu.se AssignedTo|nobody@fedoraproject.org |mattias.ellert@fysast.uu.se Flag| |fedora-review+
--- Comment #1 from Mattias Ellert mattias.ellert@fysast.uu.se 2011-08-18 11:03:08 EDT --- Fedora review edg-gridftp-client 2011-08-18
+ rpmlint output:
edg-gridftp-client.x86_64: W: spelling-error %description -l en_US mkdir -> mk dir, mk-dir, midiron edg-gridftp-client.x86_64: W: spelling-error %description -l en_US rmdir -> rm dir, rm-dir, midiron edg-gridftp-client.src: W: spelling-error %description -l en_US mkdir -> mk dir, mk-dir, midiron edg-gridftp-client.src: W: spelling-error %description -l en_US rmdir -> rm dir, rm-dir, midiron edg-gridftp-client.src: W: invalid-url Source0: edg-gridftp-client-1.2.9.2.tar.gz 3 packages and 0 specfiles checked; 0 errors, 5 warnings.
These warnings can be ignored.
+ The package is named according to the guidelines + The specfile is named after the package + The package's License tag (EU Datagrid) is a Fedora approved license + The License tag matches the actual license statements in the sources + Package installs LICENSE file as %doc + Specfile is written in legible English
+ Source matches upstream (ignoring CVS directories)
diff -ur --exclude CVS checkout/edg-gridftp-client-1.2.9.2 edg-gridftp-client-1.2.9.2 (no output)
+ The package builds in mock (F15 x96_64) + BuildRequires are sane + no locales + no shared libraries + no bundled sources + no created directories + no duplicate %files
Comment: The manpages are normally listed as xxx.1* and not xxx.1.* in the %files section in order to also allow non-compressed files.
+ File permissions are sane + Macros are used consistently + Package contains code + No large documentation files + %doc is not runtime essential + no headers + no static libraries + no sub-packages + no libtool archives + no GUIs + Package does not own other's directories + Filenames are UTF8
Apart from the comment about the manpages in %files there are no issues.
Package approved.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=719456
Steve Traylen steve.traylen@cern.ch changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review+ |fedora-review?
--- Comment #2 from Steve Traylen steve.traylen@cern.ch 2011-08-18 11:40:27 EDT --- New Package SCM Request ======================= Package Name: edg-gridftp-client Short Description: Command line clients to GridFTP libraries Owners: stevetraylen Branches: f15 f16 el4 el5 el6 InitialCC
Thanks for the review, I'll glob the man page endings before import.
Steve.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=719456
Steve Traylen steve.traylen@cern.ch changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+, fedora-cvs?
--- Comment #3 from Steve Traylen steve.traylen@cern.ch 2011-08-18 11:43:55 EDT ---
Mattias,
I switched the wrong flag, could your reassign the flag.
Steve
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=719456
--- Comment #4 from Jon Ciesla limb@jcomserv.net 2011-08-18 12:02:28 EDT --- Git done (by process-git-requests).
Edited request for syntax, let me know if something isn't as expected.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=719456
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=719456
--- Comment #5 from Fedora Update System updates@fedoraproject.org 2011-08-18 12:41:26 EDT --- edg-gridftp-client-1.2.9.2-2.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/edg-gridftp-client-1.2.9.2-2.el5
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=719456
--- Comment #6 from Fedora Update System updates@fedoraproject.org 2011-08-18 12:41:33 EDT --- edg-gridftp-client-1.2.9.2-2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/edg-gridftp-client-1.2.9.2-2.fc15
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=719456
--- Comment #7 from Fedora Update System updates@fedoraproject.org 2011-08-18 12:41:40 EDT --- edg-gridftp-client-1.2.9.2-2.el4 has been submitted as an update for Fedora EPEL 4. https://admin.fedoraproject.org/updates/edg-gridftp-client-1.2.9.2-2.el4
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=719456
--- Comment #8 from Fedora Update System updates@fedoraproject.org 2011-08-18 12:41:48 EDT --- edg-gridftp-client-1.2.9.2-2.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/edg-gridftp-client-1.2.9.2-2.fc16
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=719456
--- Comment #9 from Fedora Update System updates@fedoraproject.org 2011-08-18 12:41:56 EDT --- edg-gridftp-client-1.2.9.2-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/edg-gridftp-client-1.2.9.2-2.el6
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=719456
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #10 from Fedora Update System updates@fedoraproject.org 2011-08-18 18:03:59 EDT --- edg-gridftp-client-1.2.9.2-2.fc16 has been pushed to the Fedora 16 testing repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=719456
--- Comment #11 from Fedora Update System updates@fedoraproject.org 2011-08-28 01:39:45 EDT --- edg-gridftp-client-1.2.9.2-2.fc16 has been pushed to the Fedora 16 stable repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=719456
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |edg-gridftp-client-1.2.9.2- | |2.fc16 Resolution| |ERRATA Last Closed| |2011-08-28 01:39:50
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=719456
--- Comment #12 from Fedora Update System updates@fedoraproject.org 2011-08-30 21:35:33 EDT --- edg-gridftp-client-1.2.9.2-2.fc15 has been pushed to the Fedora 15 stable repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=719456
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|edg-gridftp-client-1.2.9.2- |edg-gridftp-client-1.2.9.2- |2.fc16 |2.fc15
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=719456
--- Comment #13 from Fedora Update System updates@fedoraproject.org 2011-09-05 19:30:47 EDT --- edg-gridftp-client-1.2.9.2-2.el6 has been pushed to the Fedora EPEL 6 stable repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=719456
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|edg-gridftp-client-1.2.9.2- |edg-gridftp-client-1.2.9.2- |2.fc15 |2.el6
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=719456
--- Comment #14 from Fedora Update System updates@fedoraproject.org 2011-09-05 19:31:35 EDT --- edg-gridftp-client-1.2.9.2-2.el5 has been pushed to the Fedora EPEL 5 stable repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=719456
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|edg-gridftp-client-1.2.9.2- |edg-gridftp-client-1.2.9.2- |2.el6 |2.el5
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=719456
--- Comment #15 from Fedora Update System updates@fedoraproject.org 2011-09-05 19:33:24 EDT --- edg-gridftp-client-1.2.9.2-2.el4 has been pushed to the Fedora EPEL 4 stable repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=719456
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|edg-gridftp-client-1.2.9.2- |edg-gridftp-client-1.2.9.2- |2.el5 |2.el4
package-review@lists.fedoraproject.org