https://bugzilla.redhat.com/show_bug.cgi?id=2122345
Bug ID: 2122345 Summary: Review Request: credentials-fetcher - Daemon to allow Windows gMSA accounts to be used in Linux Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Assignee: nobody@fedoraproject.org Reporter: samiull@amazon.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://s3.us-west-2.amazonaws.com/aws.portingassistant.dotnet.datastore/cre... SRPM URL: https://s3.us-west-2.amazonaws.com/aws.portingassistant.dotnet.datastore/cre... Description: This daemon creates and refreshes kerberos tickets, these tickets can be used to launch new containers. The gMSA feature can be implemented using this daemon. Kerberos tickets are refreshed when tickets expire or when a gMSA password changes. The same method can be used to refresh other types of security tokens.
Fedora Account System Username:samiullahmohammed
https://bugzilla.redhat.com/show_bug.cgi?id=2122345
Tom "spot" Callaway spotrh@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |spotrh@gmail.com Flags| |fedora-review? Doc Type|--- |If docs needed, set a value Status|NEW |ASSIGNED CC| |spotrh@gmail.com
https://bugzilla.redhat.com/show_bug.cgi?id=2122345
--- Comment #1 from Samiullah Mohammed samiull@amazon.com --- Updated SRPM - https://s3.us-west-2.amazonaws.com/aws.portingassistant.dotnet.datastore/cre...
https://bugzilla.redhat.com/show_bug.cgi?id=2122345
Tom "spot" Callaway spotrh@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #2 from Tom "spot" Callaway spotrh@gmail.com --- There are some extremely minor issues in the spec, which we can fix after import:
1. License: tag should be "Apache-2.0" 2. When you commit the spec file to Fedora packaging git, please rename it to "credentials-fetcher.spec" 3. One of the %description lines is longer than 80 characters (just fix it to wrap around):
Kerberos tickets are refreshed when tickets expire or when a gMSA password changes.
4. Summary is not capitalized, but given that the name of the project is not, this is not an issue. 5. You may want to consider including the release value at the end of the version string in changelog entries, like this, since you may want to update release when version has not changed. This is not required though.
* Mon Aug 29 2022 Tom Callaway spotaws@amazon.com - 0.0.94-1
All other rpmlint issues are safe to ignore:
credentials-fetcher-debuginfo.x86_64: W: unstripped-binary-or-object /usr/lib/debug/usr/sbin/credentials-fetcherd-0.0.94-1.fc36.x86_64.debug credentials-fetcher-debuginfo.x86_64: E: shared-library-without-dependency-information /usr/lib/debug/usr/sbin/credentials-fetcherd-0.0.94-1.fc36.x86_64.debug credentials-fetcher.x86_64: E: non-standard-executable-perm /usr/sbin/credentials_fetcher_utf16_private.exe 700 credentials-fetcher.x86_64: E: non-readable /usr/sbin/credentials_fetcher_utf16_private.exe 700 credentials-fetcher.x86_64: W: no-manual-page-for-binary credentials-fetcherd credentials-fetcher.x86_64: W: no-manual-page-for-binary credentials_fetcher_utf16_private.exe credentials-fetcher-debuginfo.x86_64: W: no-documentation credentials-fetcher-debugsource.x86_64: W: no-documentation credentials-fetcher.x86_64: W: name-repeated-in-summary credentials-fetcher credentials-fetcher.src: W: name-repeated-in-summary credentials-fetcher credentials-fetcher.x86_64: W: incoherent-version-in-changelog 0.0.94 ['0.0.94-1.fc36', '0.0.94-1']
= Review = - package meets naming guidelines - package meets packaging guidelines - license (Apache 2.0) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on F36 (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok (the mono bits are weird, but necessary) - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file
APPROVED
https://bugzilla.redhat.com/show_bug.cgi?id=2122345
--- Comment #3 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/credentials-fetcher
https://bugzilla.redhat.com/show_bug.cgi?id=2122345
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
--- Comment #4 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-49a649fe54 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-49a649fe54
https://bugzilla.redhat.com/show_bug.cgi?id=2122345
--- Comment #5 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-a7bd44e159 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-a7bd44e159
https://bugzilla.redhat.com/show_bug.cgi?id=2122345
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-7dd06cefe9 has been pushed to the Fedora 37 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-7dd06cefe9 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-7dd06cefe9
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2122345
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-a7bd44e159 has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-a7bd44e159 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-a7bd44e159
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2122345
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-49a649fe54 has been pushed to the Fedora 36 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-49a649fe54 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-49a649fe54
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2122345
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2022-09-01 09:40:41
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-49a649fe54 has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2122345
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-a7bd44e159 has been pushed to the Fedora 35 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2122345
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-7dd06cefe9 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org