https://bugzilla.redhat.com/show_bug.cgi?id=2153766
Bug ID: 2153766 Summary: Review Request: rust-cursive0.16 - TUI (Text User Interface) library focused on ease-of-use Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: michel@michel-slm.name QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://salimma.fedorapeople.org/rust-cursive0.16.spec SRPM URL: https://salimma.fedorapeople.org/rust-cursive0.16-0.16.3-1.fc37.src.rpm
Description: TUI (Text User Interface) library focused on ease-of-use.
Fedora Account System Username: salimma
https://bugzilla.redhat.com/show_bug.cgi?id=2153766
Michel Alexandre Salim michel@michel-slm.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value
--- Comment #1 from Michel Alexandre Salim michel@michel-slm.name --- Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=95395643
This is needed to update rust-cursive which is needed to update below-common, since rust-resctl-demo still requires the older version
https://bugzilla.redhat.com/show_bug.cgi?id=2153766
Michel Alexandre Salim michel@michel-slm.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2039060
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2039060 [Bug 2039060] rust-cursive-0.20.0 is available
https://bugzilla.redhat.com/show_bug.cgi?id=2153766
Davide Cavalca davide@cavalca.name changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |davide@cavalca.name
--- Comment #2 from Davide Cavalca davide@cavalca.name --- This is missing license files
https://bugzilla.redhat.com/show_bug.cgi?id=2153766
--- Comment #3 from Michel Alexandre Salim michel@michel-slm.name --- Updated: https://koji.fedoraproject.org/koji/taskinfo?taskID=95398337
Same spec and SRPM
https://bugzilla.redhat.com/show_bug.cgi?id=2153766
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |decathorpe@gmail.com
--- Comment #4 from Fabio Valentini decathorpe@gmail.com --- Package review isn't strictly necessary for compat packages, but looks good to me. I assume you used "rust2rpm cursive 0.16.3 --suffix 0.16" to create the spec?
The only suggestion I have is to use %license %{crate_instdir}/LICENSE instead of plain %license LICENSE so that the file is not included twice in the built packages.
Do you want me to formally review and approve the package?
https://bugzilla.redhat.com/show_bug.cgi?id=2153766
Michel Alexandre Salim michel@michel-slm.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |2153797
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2153797 [Bug 2153797] Review Request: rust-cursive_core0.2 - Core components for the Cursive TUI
https://bugzilla.redhat.com/show_bug.cgi?id=2153766
--- Comment #5 from Michel Alexandre Salim michel@michel-slm.name --- I did, thanks. And good point, reviews are not necessary, though seems this caught a couple of things so it works out! I think Davide is doing the formal review
https://bugzilla.redhat.com/show_bug.cgi?id=2153766
Michel Alexandre Salim michel@michel-slm.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED
--- Comment #6 from Michel Alexandre Salim michel@michel-slm.name --- Repo requested: https://pagure.io/releng/fedora-scm-requests/issue/49880
https://bugzilla.redhat.com/show_bug.cgi?id=2153766
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |ERRATA Fixed In Version| |rust-cursive0.16-0.16.3-3.f | |c36 CC| |ppisar@redhat.com Last Closed| |2023-02-03 14:00:24
https://bugzilla.redhat.com/show_bug.cgi?id=2153766 Bug 2153766 depends on bug 2153797, which changed state.
Bug 2153797 Summary: Review Request: rust-cursive_core0.2 - Core components for the Cursive TUI https://bugzilla.redhat.com/show_bug.cgi?id=2153797
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |NOTABUG
package-review@lists.fedoraproject.org