[Bug 2182358] New: Review Request: unzboot - Extract vmlinuz image from a EFI application

https://bugzilla.redhat.com/show_bug.cgi?id=2182358

Bug ID: 2182358
           Summary: Review Request: unzboot - Extract vmlinuz image from a
                    EFI application
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL: 
 -
https://download.copr.fedorainfracloud.org/results/eballetbo/chromebooks/fed...

SRPM URL: 
-
https://download.copr.fedorainfracloud.org/results/eballetbo/chromebooks/fed...

Description: 
  This tool is used to extract a kernel vmlinuz image from a EFI application
that carries the actual kernel image in compressed form.

Fedora Account System Username: eballetbo

Packages are available via my personal copr: 
- https://copr.fedorainfracloud.org/coprs/eballetbo/chromebooks/build/5677525/

[Bug 2182358] Review Request: unzboot - Extract vmlinuz image from a EFI application

https://bugzilla.redhat.com/show_bug.cgi?id=2182358

Enric Balletbo i Serra  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Doc Type|---                         |If docs needed, set a value

[Bug 2182358] Review Request: unzboot - Extract vmlinuz image from a EFI application

https://bugzilla.redhat.com/show_bug.cgi?id=2182358

--- Comment #1 from Jakub Kadlčík  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5716327
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[Bug 2182358] Review Request: unzboot - Extract vmlinuz image from a EFI application

https://bugzilla.redhat.com/show_bug.cgi?id=2182358

--- Comment #2 from Enric Balletbo i Serra  ---
Spec URL: 
 -
https://download.copr.fedorainfracloud.org/results/eballetbo/chromebooks/fed...

SRPM URL: 
 -
https://download.copr.fedorainfracloud.org/results/eballetbo/chromebooks/fed...

[Bug 2182358] Review Request: unzboot - Extract vmlinuz image from a EFI application

https://bugzilla.redhat.com/show_bug.cgi?id=2182358

--- Comment #3 from Jakub Kadlčík  ---
Created attachment 1954230
  --> https://bugzilla.redhat.com/attachment.cgi?id=1954230&action=edit
The .spec file difference from Copr build 5716327 to 5718574

[Bug 2182358] Review Request: unzboot - Extract vmlinuz image from a EFI application

https://bugzilla.redhat.com/show_bug.cgi?id=2182358

--- Comment #4 from Jakub Kadlčík  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5718574
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[Bug 2182358] Review Request: unzboot - Extract vmlinuz image from a EFI application

https://bugzilla.redhat.com/show_bug.cgi?id=2182358

Javier Martinez Canillas  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #5 from Javier Martinez Canillas  ---
Everything looks to me, the only comment I've is that the Fedora package policy
has a very precise naming for packages that are built from git snapshots rather
than released tarballs versions. And the package doesn't follow the guidelines:

https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_snaps...

In short, you need to have something like following diff to your current SPEC
(I've not tested this though so there may be some typos):

diff --git a/unzboot.spec b/unzboot.spec
index 7e845fee4575..9dd816eab379 100644
--- a/unzboot.spec
+++ b/unzboot.spec
@@ -1,15 +1,19 @@
-%global gitversion 3285b558  
+%global commit 3285b558529b862391d27afe098368d6f8dda09e
+%global shortcommit %(c=%{commit}; echo ${c:0:7})
+%global commitdate 20230318

Name:          unzboot
-Version:       0.1
-Release:       1.git%{gitversion}%{?dist}
+Version:       0.1~git.%{commitdate}.%{shortcommit}
+Release:       1%{?dist}

Summary:       Extracts a kernel vmlinuz image from a EFI application.
 License:       MIT

-# git snapshot.  to recreate, run:
-# ./make-git-snapshot.sh `cat commitid`
-Source0:       unzboot-%{gitversion}.tar.xz
+# Upstream is still under development so they are not tagging releases
+# yet. Use the following to do a rebase to a new snapshot:
+#
+# git archive --format=tar --prefix=${name}-${shortcommit}/ ${shortcommit} |
xz > ${name}-${shortcommit}.tar.xz
+Source0:       %{name}-%{shortcommit}.tar.xz

BuildRequires: gcc
 BuildRequires: glib2-devel
@@ -22,7 +26,7 @@ a EFI application that carries the actual kernel image in
 compressed form.

%prep
-%setup -q -n %{name}-%{gitversion}
+%autosetup -n %{name}-%{shortcommit}
 %build
 %meson
 %meson_build
@@ -37,5 +41,5 @@ compressed form.
 %{_bindir}/unzboot

%changelog
-* Sat Mar 18 2023 Enric Balletbo i Serra  -
0.1-1.git3285b558 
+* Sat Mar 18 2023 Enric Balletbo i Serra  -
0.1~git.20210928.e00149f-1
 - initial unzboot spec

[Bug 2182358] Review Request: unzboot - Extract vmlinuz image from a EFI application

https://bugzilla.redhat.com/show_bug.cgi?id=2182358

--- Comment #6 from Enric Balletbo i Serra  ---
Spec URL: 
https://download.copr.fedorainfracloud.org/results/eballetbo/chromebooks/fed...

SRPM URL:
https://download.copr.fedorainfracloud.org/results/eballetbo/chromebooks/fed...

Thanks Javier for the review, just posted a new package following the
guidelines for packages that are built from git snapshots.

[Bug 2182358] Review Request: unzboot - Extract vmlinuz image from a EFI application

https://bugzilla.redhat.com/show_bug.cgi?id=2182358

--- Comment #7 from Jakub Kadlčík  ---
Created attachment 1955673
  --> https://bugzilla.redhat.com/attachment.cgi?id=1955673&action=edit
The .spec file difference from Copr build 5718574 to 5741285

[Bug 2182358] Review Request: unzboot - Extract vmlinuz image from a EFI application

https://bugzilla.redhat.com/show_bug.cgi?id=2182358

--- Comment #8 from Jakub Kadlčík  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5741285
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[Bug 2182358] Review Request: unzboot - Extract vmlinuz image from a EFI application

https://bugzilla.redhat.com/show_bug.cgi?id=2182358

Javier Martinez Canillas  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[e-mail]    |[e-mail]

[Bug 2182358] Review Request: unzboot - Extract vmlinuz image from a EFI application

https://bugzilla.redhat.com/show_bug.cgi?id=2182358

--- Comment #9 from Javier Martinez Canillas  ---
Looks good to me now.

[Bug 2182358] Review Request: unzboot - Extract vmlinuz image from a EFI application

https://bugzilla.redhat.com/show_bug.cgi?id=2182358

Javier Martinez Canillas  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review+

[Bug 2182358] Review Request: unzboot - Extract vmlinuz image from a EFI application

https://bugzilla.redhat.com/show_bug.cgi?id=2182358

--- Comment #10 from Fedora Admin user for bugzilla script actions  ---
The Pagure repository was created at https://src.fedoraproject.org/rpms/unzboot

[Bug 2182358] Review Request: unzboot - Extract vmlinuz image from a EFI application

https://bugzilla.redhat.com/show_bug.cgi?id=2182358

Petr Pisar  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Fixed In Version|                            |unzboot-0.1~git.20230318.32
                   |                            |85b55-1.fc39
             Status|NEW                         |MODIFIED
                 CC|                            |[e-mail]

--- Comment #11 from Petr Pisar  ---
Enric, if you are not going to build this package for older Fedoras, close this
bug.

[Bug 2182358] Review Request: unzboot - Extract vmlinuz image from a EFI application

https://bugzilla.redhat.com/show_bug.cgi?id=2182358

Enric Balletbo i Serra  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |COMPLETED
             Status|MODIFIED                    |CLOSED
        Last Closed|                            |2023-04-12 13:57:05