https://bugzilla.redhat.com/show_bug.cgi?id=2127627
Bug ID: 2127627 Summary: Review Request: php-splitbrain-php-archive - pure-PHP handling of zip and tar archives Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: fedora@svgames.pl QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
spec: https://svgames.pl/fedora/php-splitbrain-php-archive-1.3.1-1/php-splitbrain-... srpm: https://svgames.pl/fedora/php-splitbrain-php-archive-1.3.1-1/php-splitbrain-... koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=92116067
Description: PHPArchive allows to handle ZIP and TAR archives without the need for PHP extensions.
Fedora Account System Username: suve
https://bugzilla.redhat.com/show_bug.cgi?id=2127627
--- Comment #1 from Remi Collet fedora@famillecollet.com --- Created attachment 1913068 --> https://bugzilla.redhat.com/attachment.cgi?id=1913068&action=edit phpci.log
https://bugzilla.redhat.com/show_bug.cgi?id=2127627
Remi Collet fedora@famillecollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@famillecollet.com
--- Comment #2 from Remi Collet fedora@famillecollet.com --- Created attachment 1913069 --> https://bugzilla.redhat.com/attachment.cgi?id=1913069&action=edit review.txt
https://bugzilla.redhat.com/show_bug.cgi?id=2127627
Remi Collet fedora@famillecollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? Status|NEW |ASSIGNED Doc Type|--- |If docs needed, set a value
--- Comment #3 from Remi Collet fedora@famillecollet.com --- [~]: Requires correct, justified where necessary.
From phpcompatinfo report, this library use date, hash and pcre ext. Despite there are always there, Guidelines say they must be required
=> https://fedoraproject.org/wiki/Packaging:PHP#Extensions_Requires
Also: Requires: php(language) >= 7.0
Package use /usr/share/php/splitbrain-php-archive
Not part of the Guidelines but common usage is
/usr/share/php/splitbrain/php-archive (using composer name) or /usr/share/php/splitbrain/PHPArchive (using namespace, so PSR0 compatible)
Notice: if you plan to build for EPEL, you should make test suite conditional (as EPEL don't have any PHPUnit versions)
https://bugzilla.redhat.com/show_bug.cgi?id=2127627
--- Comment #4 from Artur Frenszek-Iwicki fedora@svgames.pl ---
Created attachment 1913068 [details] phpci.log
What's the program used for generating this report?
Not part of the Guidelines but common usage is /usr/share/php/splitbrain/php-archive (using composer name) or /usr/share/php/splitbrain/PHPArchive (using namespace, so PSR0 compatible)
Hm, the PHP packages I submitted previously all used the "composerVendor-composerName" format, but I guess the namespace/PSR0 scheme makes more sense.
Notice: if you plan to build for EPEL, you should make test suite conditional (as EPEL don't have any PHPUnit versions)
Not planning EPEL builds currently. All the php-splibrain-* packages I've submitted for review are dependencies of dokuwiki, currently bundled with that package.
https://bugzilla.redhat.com/show_bug.cgi?id=2127627
--- Comment #5 from Remi Collet fedora@famillecollet.com --- (In reply to Artur Frenszek-Iwicki from comment #4)
Created attachment 1913068 [details] phpci.log
What's the program used for generating this report?
the phpcompatinfo command provided by the php-bartlett-PHP-CompatInfo package
automatically run by fedora-review when installed.
Notice: only missing dep. is a blocker others comment are your choice
https://bugzilla.redhat.com/show_bug.cgi?id=2127627
--- Comment #6 from Artur Frenszek-Iwicki fedora@svgames.pl --- Added the missing deps and changed the directory structure.
spec: https://svgames.pl/fedora/php-splitbrain-php-archive-1.3.1-2/php-splitbrain-... srpm: https://svgames.pl/fedora/php-splitbrain-php-archive-1.3.1-2/php-splitbrain-... koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=92405289
https://bugzilla.redhat.com/show_bug.cgi?id=2127627
Remi Collet fedora@famillecollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #7 from Remi Collet fedora@famillecollet.com --- Dependencies fixed.
==== APPROVED ====
https://bugzilla.redhat.com/show_bug.cgi?id=2127627
--- Comment #8 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/php-splitbrain-php-archive
https://bugzilla.redhat.com/show_bug.cgi?id=2127627
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-71439731b0 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-71439731b0
https://bugzilla.redhat.com/show_bug.cgi?id=2127627
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-71439731b0 has been pushed to the Fedora 37 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-71439731b0 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-71439731b0
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2127627
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2022-11-10 22:15:22
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-71439731b0 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org