https://bugzilla.redhat.com/show_bug.cgi?id=1275391
Bug ID: 1275391 Summary: Review Request: wbar - A quick launch bar Product: Fedora Version: rawhide Component: Package Review Severity: medium Assignee: nobody@fedoraproject.org Reporter: sajozsattila@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: http://landscape.geo.klte.hu/sajozsattila/Fedora_packages/wbar.spec SRPM URL: http://landscape.geo.klte.hu/sajozsattila/Fedora_packages/wbar-2.3.4-1.fc21....
Description: wbar is a quick launch bar. * It's cool eye candy * It's designed with speed in mind * It's coded in c++ using imlib2 * It's lite & fast
Authors: -------- Rodolfo Granata
Fedora Account System Username: sajozsattila
https://bugzilla.redhat.com/show_bug.cgi?id=1275391
--- Comment #1 from Attila Zsolt Sajo sajozsattila@gmail.com --- Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=11585888
Output of rpmlint -i wbar.spec wbar-2.3.4-1.fc21.i686.rpm wbar-2.3.4-1.fc21.src.rpm:
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
https://bugzilla.redhat.com/show_bug.cgi?id=1275391
--- Comment #2 from Upstream Release Monitoring upstream-release-monitoring@fedoraproject.org --- sajozsattila's scratch build of wbar-2.3.4-1.fc21.src.rpm for f22 completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11602428
https://bugzilla.redhat.com/show_bug.cgi?id=1275391
--- Comment #3 from Attila Zsolt Sajo sajozsattila@gmail.com --- I have updated the spec file, the rpmlint and koji result is show same.
https://bugzilla.redhat.com/show_bug.cgi?id=1275391
William Moreno williamjmorenor@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |williamjmorenor@gmail.com Assignee|nobody@fedoraproject.org |williamjmorenor@gmail.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1275391
--- Comment #4 from Upstream Release Monitoring upstream-release-monitoring@fedoraproject.org --- williamjmorenor's scratch build of wbar-2.3.4-1.fc21.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11630491
https://bugzilla.redhat.com/show_bug.cgi?id=1275391
--- Comment #5 from William Moreno williamjmorenor@gmail.com --- Are you going to epel5? If not, there is no need of rm -rf $RPM_BUILD_ROOT in %%install.
Note than the current spec build fine in epel6, epel7 and current Fedora: http://copr.fedoraproject.org/coprs/williamjmorenor/fedora-review-test/build...
Where is the license file? You must use the %license macro to handle the COPYING file in the tarball. Note than for epel6 you need to define the %license macro in %%files with
%files %{!?_licensedir:%global license %%doc} %license COPYING
Where are the docs files? You must use the %doc macro to handle the AUTHORS ChangeLog INSTALL README NEWS THANKS and TODO files in the tarball.
Consider to create a -docs subpackage.
https://bugzilla.redhat.com/show_bug.cgi?id=1275391
William Moreno williamjmorenor@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |sajozsattila@gmail.com Flags| |needinfo?(sajozsattila@gmai | |l.com)
--- Comment #6 from William Moreno williamjmorenor@gmail.com --- Any update here?
https://bugzilla.redhat.com/show_bug.cgi?id=1275391
William Moreno williamjmorenor@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|williamjmorenor@gmail.com | Assignee|williamjmorenor@gmail.com |nobody@fedoraproject.org Flags|fedora-review? | |needinfo?(sajozsattila@gmai | |l.com) |
https://bugzilla.redhat.com/show_bug.cgi?id=1275391
Raphael Groner projects.rg@smart.ms changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED CC| |projects.rg@smart.ms Blocks| |201449 (FE-DEADREVIEW) Resolution|--- |NOTABUG Last Closed| |2017-02-06 16:26:33
--- Comment #7 from Raphael Groner projects.rg@smart.ms --- It seems we can close here. Please feel free to reopen if you're still interested in this package.
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=201449 [Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response should be blocking this bug.
package-review@lists.fedoraproject.org