[Bug 2181994] New: Review Request: python-urltools - Some functions to parse and normalize URLs

https://bugzilla.redhat.com/show_bug.cgi?id=2181994

Bug ID: 2181994
           Summary: Review Request: python-urltools - Some functions to
                    parse and normalize URLs
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL: http://cern.ch/straylen/rpms/python-urltools/python-urltools.spec
SRPM URL:
http://cern.ch/straylen/rpms/python-urltools/python-urltools-0.4.0-1.fc39.sr...
Description: Some functions to parse and normalize URLs
Fedora Account System Username: stevetraylen

[Bug 2181994] Review Request: python-urltools - Some functions to parse and normalize URLs

https://bugzilla.redhat.com/show_bug.cgi?id=2181994

Derek  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
           Doc Type|---                         |If docs needed, set a value

[Bug 2181994] Review Request: python-urltools - Some functions to parse and normalize URLs

https://bugzilla.redhat.com/show_bug.cgi?id=2181994

--- Comment #1 from Steve Traylen  ---
I don't like the way when you import this module it down loads a file.
I think it will be better to just ship the file?

The .tld file will nearly never change anyway.

[Bug 2181994] Review Request: python-urltools - Some functions to parse and normalize URLs

https://bugzilla.redhat.com/show_bug.cgi?id=2181994

--- Comment #2 from Steve Traylen  ---
* Much happier, I learnt that the package:

$ rpm -ql publicsuffix-list
   /usr/share/publicsuffix/effective_tld_names.dat

which is a much better source for effective_tld_names.dat.

* Also converted to pyproject macros which I could not get to work before.

[Bug 2181994] Review Request: python-urltools - Some functions to parse and normalize URLs

https://bugzilla.redhat.com/show_bug.cgi?id=2181994

--- Comment #3 from Steve Traylen  ---
[fedora-review-service-build]

[Bug 2181994] Review Request: python-urltools - Some functions to parse and normalize URLs

https://bugzilla.redhat.com/show_bug.cgi?id=2181994

Steve Traylen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |2181686

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=2181686
[Bug 2181686] Review Request: python-scitokens - Reference library for SciToken
capability tokens library

[Bug 2181994] Review Request: python-urltools - Some functions to parse and normalize URLs

https://bugzilla.redhat.com/show_bug.cgi?id=2181994

--- Comment #4 from Jakub Kadlčík  ---
Created attachment 1954349
  --> https://bugzilla.redhat.com/attachment.cgi?id=1954349&action=edit
The .spec file difference from Copr build 5711343 to 5725506

[Bug 2181994] Review Request: python-urltools - Some functions to parse and normalize URLs

https://bugzilla.redhat.com/show_bug.cgi?id=2181994

Derek  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |WONTFIX
             Status|NEW                         |CLOSED
        Last Closed|                            |2023-09-13 14:22:59

--- Comment #5 from Derek  ---
python-urltools is not used by any other packages, removing this request.