https://bugzilla.redhat.com/show_bug.cgi?id=1991145
Bug ID: 1991145 Summary: Review Request: python-oslo-service - Oslo service library Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: hiwkby@yahoo.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://hiwkby.fedorapeople.org/python-oslo-service.spec SRPM URL: https://hiwkby.fedorapeople.org/python-oslo-service-2.6.0-1.fc35.src.rpm Description: Library for running OpenStack services Fedora Account System Username:hiwkby
Koji scratch build result: https://koji.fedoraproject.org/koji/taskinfo?taskID=73452628
This package retired two years ago but the former packager says feel free to take it. I will take this and update to 2.6.0. https://src.fedoraproject.org/rpms/python-oslo-service https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/...
https://bugzilla.redhat.com/show_bug.cgi?id=1991145
Hirotaka Wakabayashi hiwkby@yahoo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value
--- Comment #1 from Hirotaka Wakabayashi hiwkby@yahoo.com --- I fixed some issues against Python Packaging Guidelines.
Spec URL: https://hiwkby.fedorapeople.org/python-oslo-service.spec SRPM URL: https://hiwkby.fedorapeople.org/python-oslo-service-2.6.0-2.fc36.src.rpm Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=76405582
https://bugzilla.redhat.com/show_bug.cgi?id=1991145
Hirotaka Wakabayashi hiwkby@yahoo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |2009155
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2009155 [Bug 2009155] Review Request: python-oslo-messaging - OpenStack common messaging library
https://bugzilla.redhat.com/show_bug.cgi?id=1991145
Mattia Verga mattia.verga@proton.me changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1663668
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1663668 [Bug 1663668] Review Request: python-k2hr3-osnl - K2hR3 OpenStack Notification Listener
https://bugzilla.redhat.com/show_bug.cgi?id=1991145
--- Comment #2 from Hirotaka Wakabayashi hiwkby@yahoo.com --- Hello, I updated the version to 3.0.0.
https://hiwkby.fedorapeople.org/python-oslo-service.spec https://hiwkby.fedorapeople.org/python-oslo-service-3.0.0-1.fc38.src.rpm Koji build(success!): https://koji.fedoraproject.org/koji/taskinfo?taskID=93460195
https://bugzilla.redhat.com/show_bug.cgi?id=1991145
--- Comment #3 from Hirotaka Wakabayashi hiwkby@yahoo.com --- Hello, I fixed issues on the package guidelines.
https://hiwkby.fedorapeople.org/python-oslo-service.spec https://hiwkby.fedorapeople.org/python-oslo-service-3.0.0-2.fc38.src.rpm Koji build(success!): https://koji.fedoraproject.org/koji/taskinfo?taskID=93644839
``` $ diff -c public_html/python-oslo-service.spec python-oslo-service.spec *** public_html/python-oslo-service.spec 2022-10-26 09:28:50.620251005 +0000 --- python-oslo-service.spec 2022-11-01 00:04:09.180098559 +0000 *************** *** 8,23 **** %global common_desc \ Library for running OpenStack services
- %global common_desc1 \ - Tests for oslo.service - Name: python-%{pname} Version: 3.0.0 ! Release: 1%{?dist} Summary: Oslo service library
License: ASL 2.0 ! URL: http://launchpad.net/oslo Source0: https://tarballs.openstack.org/%%7Bpypi_name%7D/%%7Bpypi_name%7D-%%7Bupstrea... # Required for tarball sources verification %if 0%{?sources_gpg} == 1 --- 8,20 ---- %global common_desc \ Library for running OpenStack services
Name: python-%{pname} Version: 3.0.0 ! Release: 2%{?dist} Summary: Oslo service library
License: ASL 2.0 ! URL: https://opendev.org/openstack/oslo.service Source0: https://tarballs.openstack.org/%%7Bpypi_name%7D/%%7Bpypi_name%7D-%%7Bupstrea... # Required for tarball sources verification %if 0%{?sources_gpg} == 1 *************** *** 47,53 **** BuildRequires: procps-ng BuildRequires: python3-fixtures BuildRequires: python3-hacking - BuildRequires: python3-mock BuildRequires: python3-requests BuildRequires: python3-routes BuildRequires: python3-oslotest --- 44,49 ---- *************** *** 85,97 **** Requires: procps-ng Requires: python3-fixtures Requires: python3-hacking - Requires: python3-mock Requires: python3-requests Requires: python3-routes Requires: python3-oslotest
%description -n python3-%{pname}-tests ! %{common_desc1}
%if 0%{?with_doc} %package -n python-%{pname}-doc --- 81,92 ---- Requires: procps-ng Requires: python3-fixtures Requires: python3-hacking Requires: python3-requests Requires: python3-routes Requires: python3-oslotest
%description -n python3-%{pname}-tests ! Tests for oslo.service
%if 0%{?with_doc} %package -n python-%{pname}-doc *************** *** 152,157 **** --- 147,155 ---- %endif
%changelog + * Tue Nov 01 2022 Hirotaka Wakabayashi hiwkby@yahoo.com - 3.0.0-2 + - Fixes issues on the packaging guidelines + * Wed Oct 26 2022 Hirotaka Wakabayashi hiwkby@yahoo.com - 3.0.0-1 - Update to 3.0.0
```
https://bugzilla.redhat.com/show_bug.cgi?id=1991145
--- Comment #4 from Hirotaka Wakabayashi hiwkby@yahoo.com --- Hello, I fixed issues on the package guidelines.
https://hiwkby.fedorapeople.org/python-oslo-service.spec https://hiwkby.fedorapeople.org/python-oslo-service-3.0.0-3.fc38.src.rpm Koji build(success!): https://koji.fedoraproject.org/koji/taskinfo?taskID=93927843
``` $ diff -c public_html/python-oslo-service.spec python-oslo-service.spec *** public_html/python-oslo-service.spec 2022-11-01 00:04:09.180098559 +0000 --- python-oslo-service.spec 2022-11-08 02:11:12.092810714 +0000 *************** *** 10,16 ****
Name: python-%{pname} Version: 3.0.0 ! Release: 2%{?dist} Summary: Oslo service library
License: ASL 2.0 --- 10,16 ----
Name: python-%{pname} Version: 3.0.0 ! Release: 3%{?dist} Summary: Oslo service library
License: ASL 2.0 *************** *** 30,36 ****
%package -n python3-%{pname} Summary: Oslo service library ! %{?python_provide:%python_provide python3-%{pname}}
BuildRequires: python3-devel BuildRequires: python3-setuptools --- 30,36 ----
%package -n python3-%{pname} Summary: Oslo service library ! %py_provides python3-pkg_resources
BuildRequires: python3-devel BuildRequires: python3-setuptools *************** *** 75,81 ****
%package -n python3-%{pname}-tests Summary: Oslo service tests ! %{?python_provide:%python_provide python3-%{pname}-tests}
Requires: python3-%{pname} = %{version}-%{release} Requires: procps-ng --- 75,81 ----
%package -n python3-%{pname}-tests Summary: Oslo service tests ! %py_provides python3-pkg_resources
Requires: python3-%{pname} = %{version}-%{release} Requires: procps-ng *************** *** 147,152 **** --- 147,155 ---- %endif
%changelog + * Tue Nov 08 2022 Hirotaka Wakabayashi hiwkby@yahoo.com - 3.0.0-3 + - Fixes issues on the packaging guidelines + * Tue Nov 01 2022 Hirotaka Wakabayashi hiwkby@yahoo.com - 3.0.0-2 - Fixes issues on the packaging guidelines
```
``` $ sudo dnf install -y ~/dev/packages/RPMS/noarch/python3-oslo-service-3.0.0-3.fc38.noarch.rpm $ rpm -q --whatprovides python3-oslo-service python3-oslo-service-3.0.0-3.fc38.noarch ```
https://bugzilla.redhat.com/show_bug.cgi?id=1991145
--- Comment #5 from Hirotaka Wakabayashi hiwkby@yahoo.com --- Sorry, I fixed an issue on the guidelines again because I read the old guidelines and made a mistake...orz
https://hiwkby.fedorapeople.org/python-oslo-service.spec https://hiwkby.fedorapeople.org/python-oslo-service-3.0.0-4.fc38.src.rpm Koji build(success!): https://koji.fedoraproject.org/koji/taskinfo?taskID=93962925
``` $ diff -c public_html/python-oslo-service.spec python-oslo-service.spec *** public_html/python-oslo-service.spec 2022-11-08 02:11:12.092810714 +0000 --- python-oslo-service.spec 2022-11-09 02:40:07.926307694 +0000 *************** *** 2,16 **** %global sources_gpg_sign 0xa63ea142678138d1bb15f2e303bdfd64dd164087 %{!?upstream_version: %global upstream_version %{version}%{?milestone}} %global pypi_name oslo.service ! %global pname oslo-service %global with_doc 1
%global common_desc \ Library for running OpenStack services
! Name: python-%{pname} Version: 3.0.0 ! Release: 3%{?dist} Summary: Oslo service library
License: ASL 2.0 --- 2,16 ---- %global sources_gpg_sign 0xa63ea142678138d1bb15f2e303bdfd64dd164087 %{!?upstream_version: %global upstream_version %{version}%{?milestone}} %global pypi_name oslo.service ! %global pkg_name oslo-service %global with_doc 1
%global common_desc \ Library for running OpenStack services
! Name: python-%{pkg_name} Version: 3.0.0 ! Release: 4%{?dist} Summary: Oslo service library
License: ASL 2.0 *************** *** 28,36 **** BuildRequires: /usr/bin/gpgv2 %endif
! %package -n python3-%{pname} Summary: Oslo service library ! %py_provides python3-pkg_resources
BuildRequires: python3-devel BuildRequires: python3-setuptools --- 28,36 ---- BuildRequires: /usr/bin/gpgv2 %endif
! %package -n python3-%{pkg_name} Summary: Oslo service library ! %py_provides python3-%{pkg_name}
BuildRequires: python3-devel BuildRequires: python3-setuptools *************** *** 70,83 **** Requires: python3-paste-deploy >= 1.5.0
! %description -n python3-%{pname} %{common_desc}
! %package -n python3-%{pname}-tests Summary: Oslo service tests ! %py_provides python3-pkg_resources
! Requires: python3-%{pname} = %{version}-%{release} Requires: procps-ng Requires: python3-fixtures Requires: python3-hacking --- 70,83 ---- Requires: python3-paste-deploy >= 1.5.0
! %description -n python3-%{pkg_name} %{common_desc}
! %package -n python3-%{pkg_name}-tests Summary: Oslo service tests ! %py_provides python3-%{pkg_name}
! Requires: python3-%{pkg_name} = %{version}-%{release} Requires: procps-ng Requires: python3-fixtures Requires: python3-hacking *************** *** 85,101 **** Requires: python3-routes Requires: python3-oslotest
! %description -n python3-%{pname}-tests Tests for oslo.service
%if 0%{?with_doc} ! %package -n python-%{pname}-doc Summary: Oslo service documentation
BuildRequires: python3-sphinx BuildRequires: python3-openstackdocstheme
! %description -n python-%{pname}-doc Documentation for oslo.service %endif
--- 85,101 ---- Requires: python3-routes Requires: python3-oslotest
! %description -n python3-%{pkg_name}-tests Tests for oslo.service Tests for oslo.service
%if 0%{?with_doc} ! %package -n python-%{pkg_name}-doc Summary: Oslo service documentation
BuildRequires: python3-sphinx BuildRequires: python3-openstackdocstheme
! %description -n python-%{pkg_name}-doc Documentation for oslo.service %endif
*************** *** 130,152 **** #python3 setup.py test || #rm -rf .testrepository
! %files -n python3-%{pname} %doc README.rst %license LICENSE %{python3_sitelib}/oslo_service %{python3_sitelib}/*.egg-info %exclude %{python3_sitelib}/oslo_service/tests
! %files -n python3-%{pname}-tests %{python3_sitelib}/oslo_service/tests
%if 0%{?with_doc} ! %files -n python-%{pname}-doc %doc doc/build/html %license LICENSE %endif
%changelog * Tue Nov 08 2022 Hirotaka Wakabayashi hiwkby@yahoo.com - 3.0.0-3 - Fixes issues on the packaging guidelines
--- 130,155 ---- #python3 setup.py test || #rm -rf .testrepository
! %files -n python3-%{pkg_name} %doc README.rst %license LICENSE %{python3_sitelib}/oslo_service %{python3_sitelib}/*.egg-info %exclude %{python3_sitelib}/oslo_service/tests
! %files -n python3-%{pkg_name}-tests %{python3_sitelib}/oslo_service/tests
%if 0%{?with_doc} ! %files -n python-%{pkg_name}-doc %doc doc/build/html %license LICENSE %endif
%changelog + * Wed Nov 09 2022 Hirotaka Wakabayashi hiwkby@yahoo.com - 3.0.0-4 + - Fixes issues on the packaging guidelines + * Tue Nov 08 2022 Hirotaka Wakabayashi hiwkby@yahoo.com - 3.0.0-3 - Fixes issues on the packaging guidelines
```
``` $ rpmspec -P python-oslo-service.spec | grep -B 3 Provides
%package -n python3-oslo-service Summary: Oslo service library Provides: python3-oslo-service = 3.0.0-4.fc38 Provides: python3.11-oslo-service = 3.0.0-4.fc38 Provides: python-oslo-service = 3.0.0-4.fc38 --
%package -n python3-oslo-service-tests Summary: Oslo service tests Provides: python3-oslo-service = 3.0.0-4.fc38 Provides: python3.11-oslo-service = 3.0.0-4.fc38 Provides: python-oslo-service = 3.0.0-4.fc38
$ sudo dnf install -y ~/dev/packages/RPMS/noarch/python3-oslo-service-3.0.0-4.fc38.noarch.rpm $ rpm -q --whatprovides python3-oslo-service python3-oslo-service-3.0.0-4.fc38.noarch ```
https://bugzilla.redhat.com/show_bug.cgi?id=1991145
--- Comment #6 from Hirotaka Wakabayashi hiwkby@yahoo.com --- Hello, I fixed another issue.
Spec URL: https://hiwkby.fedorapeople.org/python-oslo-service.spec SRPM URL: https://hiwkby.fedorapeople.org/python-oslo-service-3.0.0-5.fc38.src.rpm Koji(success): https://koji.fedoraproject.org/koji/taskinfo?taskID=94227940
``` $ diff -c ~/public_html/python-oslo-service.spec python-oslo-service.spec *** /home/fedora/hiwkby/public_html/python-oslo-service.spec 2022-11-09 02:40:07.926307694 +0000 --- python-oslo-service.spec 2022-11-16 03:46:59.626630713 +0000 *************** *** 10,16 ****
Name: python-%{pkg_name} Version: 3.0.0 ! Release: 4%{?dist} Summary: Oslo service library
License: ASL 2.0 --- 10,16 ----
Name: python-%{pkg_name} Version: 3.0.0 ! Release: 5%{?dist} Summary: Oslo service library
License: ASL 2.0 *************** *** 134,140 **** %doc README.rst %license LICENSE %{python3_sitelib}/oslo_service ! %{python3_sitelib}/*.egg-info %exclude %{python3_sitelib}/oslo_service/tests
%files -n python3-%{pkg_name}-tests --- 134,140 ---- %doc README.rst %license LICENSE %{python3_sitelib}/oslo_service ! %{python3_sitelib}/%{pypi_name}-%{version}-py%{python3_version}.egg-info %exclude %{python3_sitelib}/oslo_service/tests
%files -n python3-%{pkg_name}-tests *************** *** 147,152 **** --- 147,155 ---- %endif
%changelog + * Wed Nov 16 2022 Hirotaka Wakabayashi hiwkby@yahoo.com - 3.0.0-5 + - Fixes issues on the packaging guidelines + * Wed Nov 09 2022 Hirotaka Wakabayashi hiwkby@yahoo.com - 3.0.0-4 - Fixes issues on the packaging guidelines ```
https://bugzilla.redhat.com/show_bug.cgi?id=1991145
Jakub Kadlčík jkadlcik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jkadlcik@redhat.com
--- Comment #7 from Jakub Kadlčík jkadlcik@redhat.com --- Hello Hirotaka, thank you for the package.
I have only a few notes.
%global common_desc \ Library for running OpenStack services
There is a nice paragraph explaining the package in the project README - https://opendev.org/openstack/oslo.service Can we use that as a description?
%check # FIXME: https://review.openstack.org/279011 seems to break tests in CentOS7, # creating an infinite loop #python3 setup.py test || #rm -rf .testrepository
Does this fail only for CentOS7?
In such case, we can conditionally run the tests for the rest of the distributions, e.g.
%if 0%{?fedora} || 0%{?rhel} > 7 # ... run your tests here %endif
- Wed Nov 16 2022 Hirotaka Wakabayashi hiwkby@yahoo.com - 3.0.0-5
- Wed Nov 09 2022 Hirotaka Wakabayashi hiwkby@yahoo.com - 3.0.0-4
- Tue Nov 08 2022 Hirotaka Wakabayashi hiwkby@yahoo.com - 3.0.0-3
- Tue Nov 01 2022 Hirotaka Wakabayashi hiwkby@yahoo.com - 3.0.0-2
The email address should be in < and > brackets, as you did for your previous changelog records
* Wed Oct 26 2022 Hirotaka Wakabayashi hiwkby@yahoo.com - 3.0.0-1
https://bugzilla.redhat.com/show_bug.cgi?id=1991145
Jakub Kadlčík jkadlcik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |jkadlcik@redhat.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1991145
--- Comment #8 from Hirotaka Wakabayashi hiwkby@yahoo.com --- Hello Jakub! Sorry for my late response.
Does this fail only for CentOS7?
I found failures=1 and errors=1 for rawhide. I will make a patch in this weekend.
Thanks in advance, Hirotaka
https://bugzilla.redhat.com/show_bug.cgi?id=1991145
--- Comment #9 from Hirotaka Wakabayashi hiwkby@yahoo.com --- Hello Jakub! I have fixed the issues. Please check the following files.
Spec URL: https://hiwkby.fedorapeople.org/python-oslo-service.spec SRPM URL: https://hiwkby.fedorapeople.org/python-oslo-service-3.0.0-6.fc38.src.rpm Koji(success): https://koji.fedoraproject.org/koji/taskinfo?taskID=94867239
There is a nice paragraph explaining the package in the project README - https://opendev.org/openstack/oslo.service Can we use that as a description?
Fixed. I use the sentences from the README.rst file. https://opendev.org/openstack/oslo.service/src/branch/master/README.rst
Does this fail only for CentOS7?
In such case, we can conditionally run the tests for the rest of the distributions, e.g.
Fixed. I uncomment the lines because I firstly want to push this package for Rawhide branch. I also introduce the new patch for tests and use tox for the tests.
The email address should be in < and > brackets, as you did for your previous changelog records
Fixed. Sorry for my typos. m(_ _)m
``` *** /home/fedora/hiwkby/public_html/python-oslo-service.spec 2022-11-16 03:46:59.626630713 +0000 --- python-oslo-service.spec 2022-12-03 06:41:11.128314842 +0000 *************** *** 6,16 **** %global with_doc 1
%global common_desc \ ! Library for running OpenStack services
Name: python-%{pkg_name} Version: 3.0.0 ! Release: 5%{?dist} Summary: Oslo service library
License: ASL 2.0 --- 6,17 ---- %global with_doc 1
%global common_desc \ ! oslo.service provides a framework for defining new long-running services \ ! using the patterns established by other OpenStack applications.
Name: python-%{pkg_name} Version: 3.0.0 ! Release: 6%{?dist} Summary: Oslo service library
License: ASL 2.0 *************** *** 21,26 **** --- 22,30 ---- Source101: https://tarballs.openstack.org/%%7Bpypi_name%7D/%%7Bpypi_name%7D-%%7Bupstrea... Source102: https://releases.openstack.org/_static/%%7Bsources_gpg_sign%7D.txt %endif + # This patch is temporary until upstream releases 3.0.1. See + # https://bugs.launchpad.net/oslo.service/+bug/1988308 + Patch1: test_loopingcall.py.patch BuildArch: noarch
# Required for tarball sources verification *************** *** 54,59 **** --- 58,64 ---- BuildRequires: python3-webob BuildRequires: python3-paste BuildRequires: python3-paste-deploy + BuildRequires: python3-tox
Requires: python3-eventlet >= 0.25.2 Requires: python3-greenlet *************** *** 107,113 **** %if 0%{?sources_gpg} == 1 %{gpgverify} --keyring=%{SOURCE102} --signature=%{SOURCE101} --data=%{SOURCE0} %endif ! %autosetup -n %{pypi_name}-%{upstream_version} -S git
%build %{py3_build} --- 112,118 ---- %if 0%{?sources_gpg} == 1 %{gpgverify} --keyring=%{SOURCE102} --signature=%{SOURCE101} --data=%{SOURCE0} %endif ! %autosetup -p0 -n %{pypi_name}-%{upstream_version} -S git
%build %{py3_build} *************** *** 127,134 **** %check # FIXME: https://review.openstack.org/279011 seems to break tests in CentOS7, # creating an infinite loop ! #python3 setup.py test || ! #rm -rf .testrepository
%files -n python3-%{pkg_name} %doc README.rst --- 132,139 ---- %check # FIXME: https://review.openstack.org/279011 seems to break tests in CentOS7, # creating an infinite loop ! tox -e py3|| ! rm -rf .testrepository
%files -n python3-%{pkg_name} %doc README.rst *************** *** 147,162 **** %endif
%changelog ! * Wed Nov 16 2022 Hirotaka Wakabayashi hiwkby@yahoo.com - 3.0.0-5 - Fixes issues on the packaging guidelines
! * Wed Nov 09 2022 Hirotaka Wakabayashi hiwkby@yahoo.com - 3.0.0-4 - Fixes issues on the packaging guidelines
! * Tue Nov 08 2022 Hirotaka Wakabayashi hiwkby@yahoo.com - 3.0.0-3 - Fixes issues on the packaging guidelines
! * Tue Nov 01 2022 Hirotaka Wakabayashi hiwkby@yahoo.com - 3.0.0-2 - Fixes issues on the packaging guidelines
* Wed Oct 26 2022 Hirotaka Wakabayashi hiwkby@yahoo.com - 3.0.0-1 --- 152,171 ---- %endif
%changelog ! * Sat Dec 03 2022 Hirotaka Wakabayashi hiwkby@yahoo.com - 3.0.0-6 ! - Applies a patch for tests and uses tox for tests - Fixes issues on the packaging guidelines
! * Wed Nov 16 2022 Hirotaka Wakabayashi hiwkby@yahoo.com - 3.0.0-5 - Fixes issues on the packaging guidelines
! * Wed Nov 09 2022 Hirotaka Wakabayashi hiwkby@yahoo.com - 3.0.0-4 - Fixes issues on the packaging guidelines
! * Tue Nov 08 2022 Hirotaka Wakabayashi hiwkby@yahoo.com - 3.0.0-3 ! - Fixes issues on the packaging guidelines ! ! * Tue Nov 01 2022 Hirotaka Wakabayashi hiwkby@yahoo.com - 3.0.0-2 - Fixes issues on the packaging guidelines
* Wed Oct 26 2022 Hirotaka Wakabayashi hiwkby@yahoo.com - 3.0.0-1 ```
Thanks in advance, Hirotaka
https://bugzilla.redhat.com/show_bug.cgi?id=1991145
--- Comment #10 from Jakub Kadlčík jkadlcik@redhat.com --- Hello
Spec URL: https://hiwkby.fedorapeople.org/python-oslo-service.spec SRPM URL: https://hiwkby.fedorapeople.org/python-oslo-service-3.0.0-6.fc38.src.rpm Koji(success): https://koji.fedoraproject.org/koji/taskinfo?taskID=94867239
Please be aware that you forgot to update the spec file here and that the SRPM is not downloadable and returns 404. I wanted to finish the review for you, so I downloaded the SRPM from Koji and reviewed it.
Please make sure to import the correct spec file and sources once you get access to the DistGit repository.
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
Issues: ======= - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file license.png is not marked as %license See: https://docs.fedoraproject.org/en-US/packaging- guidelines/LicensingGuidelines/#_license_text - Package does not use a name that already exists. Note: A package with this name already exists. Please check https://src.fedoraproject.org/rpms/python-oslo-service See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Naming/#_conflicting_package_names
===== MUST items =====
Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Apache License 2.0", "*No copyright* Apache License", "Apache License 2.0". 67 files have unknown license. Detailed output of licensecheck in /tmp/review/python-oslo-service/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep
===== SHOULD items =====
Generic: [x]: Reviewer should test that the package builds in mock. [x]: Avoid bundling fonts in non-fonts packages. Note: Package contains font files ^^ Only the HTML doc in the subpackage [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-oslo-service , python3-oslo-service-tests [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [?]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment).
Rpmlint ------- Checking: python3-oslo-service-3.0.0-6.fc38.noarch.rpm python3-oslo-service-tests-3.0.0-6.fc38.noarch.rpm python-oslo-service-doc-3.0.0-6.fc38.noarch.rpm python-oslo-service-3.0.0-6.fc38.src.rpm ============================================================================================================ rpmlint session starts =========================================================================================================== rpmlint: 2.4.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpahh6a24x')] checks: 31, packages: 4
python3-oslo-service-tests.noarch: W: no-documentation python-oslo-service-doc.noarch: W: files-duplicate /usr/share/doc/python-oslo-service-doc/html/_static/images/openstack-logo-full.png /usr/share/doc/python-oslo-service-doc/html/_static/images/logo-full.png python-oslo-service-doc.noarch: W: files-duplicate /usr/share/doc/python-oslo-service-doc/html/_static/images/openstack-logo-full.svg /usr/share/doc/python-oslo-service-doc/html/_static/images/logo-full.svg python-oslo-service-doc.noarch: W: files-duplicate /usr/share/doc/python-oslo-service-doc/html/_static/images/openstack-logo-vert.png /usr/share/doc/python-oslo-service-doc/html/_static/images/logo-vert.png python-oslo-service-doc.noarch: W: files-duplicate /usr/share/doc/python-oslo-service-doc/html/_static/images/openstack-logo-vert.svg /usr/share/doc/python-oslo-service-doc/html/_static/images/logo-vert.svg python3-oslo-service.noarch: W: files-duplicate /usr/lib/python3.11/site-packages/oslo.service-3.0.0-py3.11.egg-info/not-zip-safe /usr/lib/python3.11/site-packages/oslo.service-3.0.0-py3.11.egg-info/dependency_links.txt ============================================================================= 4 packages and 0 specfiles checked; 0 errors, 6 warnings, 0 badness; has taken 0.3 s ============================================================================
Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 3
python3-oslo-service-tests.noarch: W: no-documentation python-oslo-service-doc.noarch: W: files-duplicate /usr/share/doc/python-oslo-service-doc/html/_static/images/openstack-logo-full.png /usr/share/doc/python-oslo-service-doc/html/_static/images/logo-full.png python-oslo-service-doc.noarch: W: files-duplicate /usr/share/doc/python-oslo-service-doc/html/_static/images/openstack-logo-full.svg /usr/share/doc/python-oslo-service-doc/html/_static/images/logo-full.svg python-oslo-service-doc.noarch: W: files-duplicate /usr/share/doc/python-oslo-service-doc/html/_static/images/openstack-logo-vert.png /usr/share/doc/python-oslo-service-doc/html/_static/images/logo-vert.png python-oslo-service-doc.noarch: W: files-duplicate /usr/share/doc/python-oslo-service-doc/html/_static/images/openstack-logo-vert.svg /usr/share/doc/python-oslo-service-doc/html/_static/images/logo-vert.svg python3-oslo-service.noarch: W: files-duplicate /usr/lib/python3.11/site-packages/oslo.service-3.0.0-py3.11.egg-info/not-zip-safe /usr/lib/python3.11/site-packages/oslo.service-3.0.0-py3.11.egg-info/dependency_links.txt 3 packages and 0 specfiles checked; 0 errors, 6 warnings, 0 badness; has taken 0.1 s
Source checksums ---------------- https://releases.openstack.org/_static/0xa63ea142678138d1bb15f2e303bdfd64dd1... : CHECKSUM(SHA256) this package : 78f850ee4e9c8c1f5447d15856042cd65aa8bdd311f8a52906b18bf97dab4049 CHECKSUM(SHA256) upstream package : 78f850ee4e9c8c1f5447d15856042cd65aa8bdd311f8a52906b18bf97dab4049 https://tarballs.openstack.org/oslo.service/oslo.service-3.0.0.tar.gz.asc : CHECKSUM(SHA256) this package : 4b6ea7823b3c27e31b1df342e636711b25c356bf9cce5e8815673e25e48d7ca7 CHECKSUM(SHA256) upstream package : 4b6ea7823b3c27e31b1df342e636711b25c356bf9cce5e8815673e25e48d7ca7 https://tarballs.openstack.org/oslo.service/oslo.service-3.0.0.tar.gz : CHECKSUM(SHA256) this package : 87b9ea3e144a186ff1a2e1f18fd4a81f1f381a0574f5acffd93001edd04e8027 CHECKSUM(SHA256) upstream package : 87b9ea3e144a186ff1a2e1f18fd4a81f1f381a0574f5acffd93001edd04e8027
Requires -------- python3-oslo-service (rpmlib, GLIBC filtered): python(abi) python3-debtcollector python3-eventlet python3-greenlet python3-oslo-concurrency python3-oslo-config python3-oslo-i18n python3-oslo-log python3-oslo-utils python3-paste python3-paste-deploy python3-routes python3-webob python3-yappi python3.11dist(debtcollector) python3.11dist(eventlet) python3.11dist(fixtures) python3.11dist(greenlet) python3.11dist(oslo-concurrency) python3.11dist(oslo-config) python3.11dist(oslo-i18n) python3.11dist(oslo-log) python3.11dist(oslo-utils) python3.11dist(paste) python3.11dist(pastedeploy) python3.11dist(routes) python3.11dist(webob) python3.11dist(yappi)
python3-oslo-service-tests (rpmlib, GLIBC filtered): procps-ng python(abi) python3-fixtures python3-hacking python3-oslo-service python3-oslotest python3-requests python3-routes
python-oslo-service-doc (rpmlib, GLIBC filtered):
Provides -------- python3-oslo-service: python-oslo-service python3-oslo-service python3.11-oslo-service python3.11dist(oslo-service) python3dist(oslo-service)
python3-oslo-service-tests: python-oslo-service python-oslo-service-tests python3-oslo-service python3-oslo-service-tests python3.11-oslo-service python3.11-oslo-service-tests
python-oslo-service-doc: python-oslo-service-doc
Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review --prebuilt --rpm-spec --name python-oslo-service Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: fonts, Ocaml, Haskell, Java, SugarActivity, Perl, R, PHP, C/C++ Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
https://bugzilla.redhat.com/show_bug.cgi?id=1991145
Jakub Kadlčík jkadlcik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
https://bugzilla.redhat.com/show_bug.cgi?id=1991145
--- Comment #11 from Hirotaka Wakabayashi hiwkby@yahoo.com --- Hello Jakub, I really appreciate you reviewing this package!
Please be aware that you forgot to update the spec file here and that
the SRPM is not downloadable and returns 404. I wanted to finish the review for you, so I downloaded the SRPM from Koji and reviewed it.
I am sorry, I forgot to update the files on the fedorapeople.org... orz
Please make sure to import the correct spec file and sources once you
get access to the DistGit repository.
I will import the correct files to the DistGit repository. :)
Hirotaka
https://bugzilla.redhat.com/show_bug.cgi?id=1991145
Lumír Balhar lbalhar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |lbalhar@redhat.com
--- Comment #12 from Lumír Balhar lbalhar@redhat.com --- It seems that the package is already imported and available in rawhide so this bug can be closed. It's a good idea to add the package to Koschei and release-monitoring.
https://bugzilla.redhat.com/show_bug.cgi?id=1991145
Jakub Kadlčík jkadlcik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |RAWHIDE Last Closed| |2023-01-20 03:08:14
--- Comment #13 from Jakub Kadlčík jkadlcik@redhat.com --- Indeed Lumír, https://src.fedoraproject.org/rpms/python-oslo-service
I was expecting the standard "repo was created" comment but the repo already existed, in was just retired. I can see that Hirotaka was able to push there, https://src.fedoraproject.org/rpms/python-oslo-service/c/d51240202572898b244...
so I also think we can close the issue.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com