[Bug 2173716] New: Review Request: rust-test-case-macros - Procedural macro attribute for generating parametrized test cases
https://bugzilla.redhat.com/show_bug.cgi?id=2173716
Bug ID: 2173716 Summary: Review Request: rust-test-case-macros - Procedural macro attribute for generating parametrized test cases Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: decathorpe@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://decathorpe.fedorapeople.org/rust-test-case-macros.spec SRPM URL: https://decathorpe.fedorapeople.org/rust-test-case-macros-2.2.2-1.fc37.src.r...
Description: Provides #[test_case(...)] procedural macro attribute for generating parametrized test cases easily.
Fedora Account System Username: decathorpe
https://bugzilla.redhat.com/show_bug.cgi?id=2173716
Jakub Kadlčík jkadlcik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://crates.io/crates/te | |st-case-macros
--- Comment #2 from Jakub Kadlčík jkadlcik@redhat.com --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5574395 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2173716
Michel Alexandre Salim michel@michel-slm.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |michel@michel-slm.name Flags| |fedora-review? CC| |michel@michel-slm.name Status|NEW |ASSIGNED
https://bugzilla.redhat.com/show_bug.cgi?id=2173716
Michel Alexandre Salim michel@michel-slm.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+
--- Comment #3 from Michel Alexandre Salim michel@michel-slm.name --- Package was generated with rust2rpm, simplifying the review.
- package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification (MIT) and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines
Package APPROVED.
===
Recommended post-import rust-sig tasks:
- add @rust-sig with "commit" access as package co-maintainer
- set bugzilla assignee overrides to @rust-sig (optional)
- set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate
- track package in koschei for all built branches
https://bugzilla.redhat.com/show_bug.cgi?id=2173716
--- Comment #4 from Michel Alexandre Salim michel@michel-slm.name --- (In reply to Michel Alexandre Salim from comment #3)
- latest version of the crate is packaged
^ not latest, but there's an explanation
https://bugzilla.redhat.com/show_bug.cgi?id=2173716
--- Comment #5 from Fabio Valentini decathorpe@gmail.com --- Thanks for the review! :)
https://bugzilla.redhat.com/show_bug.cgi?id=2173716
--- Comment #6 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-test-case-macros
https://bugzilla.redhat.com/show_bug.cgi?id=2173716
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |ERRATA Status|POST |CLOSED Last Closed| |2023-03-03 15:27:08
--- Comment #7 from Fabio Valentini decathorpe@gmail.com --- Imported, built, and submitted: https://bodhi.fedoraproject.org/updates/FEDORA-2023-617e48c47d https://bodhi.fedoraproject.org/updates/FEDORA-2023-aa61180662 https://bodhi.fedoraproject.org/updates/FEDORA-2023-17198904f9 https://bodhi.fedoraproject.org/updates/FEDORA-2023-2258507395 Thanks everybody!
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com