Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: mozilla-https-everywhere - HTTPS/HSTS enforcement extension for Mozilla browsers
https://bugzilla.redhat.com/show_bug.cgi?id=739323
Summary: Review Request: mozilla-https-everywhere - HTTPS/HSTS enforcement extension for Mozilla browsers Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: unspecified Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: niveusluna@niveusluna.org QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: ---
Spec URL: mozilla-https-everywhere.spec SRPM URL: https://niveusluna.org/kahiru/repo/fedora/free/SRPMS/mozilla-https-everywher... Description: I'm just gonna copy and paste this from upstream, if that's okay.
HTTPS Everywhere is a Firefox extension produced as a collaboration between The Tor Project and the Electronic Frontier Foundation. It encrypts your communications with a number of major websites.
Many sites on the web offer some limited support for encryption over HTTPS, but make it difficult to use. For instance, they may default to unencrypted HTTP, or fill encrypted pages with links that go back to the unencrypted site.
The HTTPS Everywhere extension fixes these problems by rewriting all requests to these sites to HTTPS.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=739323
--- Comment #1 from Russell Golden niveusluna@niveusluna.org 2011-09-17 12:58:38 EDT --- ...How the heck did that happen?
Spec URL: https://niveusluna.org/kahiru/repo/fedora/free/SRPMS/mozilla-https-everywher...
Sorry about that, could've sworn I pasted the URL properly...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=739323
Al Reay alreay1@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |alreay1@gmail.com
--- Comment #2 from Al Reay alreay1@gmail.com 2011-09-18 19:40:01 EDT --- Hi Russell, I'm not a proven packager so I can't sponsor or approve your package but I'll cheerfully do an informal review for you.
* just a niggle, the srpm link isn't fully formed with respect to the https certificate, to avoid wget/curl download errors make sure that it's got a 'www' prefix to match the servername as per the cert.
* I think your use of explicit 'requires' tag is OK here because automatic dependency resolution by RPM won't work as you're using it only to see if a directory structure exists (as opposed to using a library or binary)
Nice simple package, I think you'll have no problems getting this one through.
Good luck Al
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=739323
--- Comment #3 from Russell Golden niveusluna@niveusluna.org 2011-09-18 20:14:24 EDT --- Huh. On my machine, neither wget nor curl complains about my cert.
When I made it, I was under the impression the cert would work for both my SLD and the subdomain www. I only entered the subdomain because StartCom wouldn't give me a cert otherwise.
Thanks for the informal review!
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=739323
Thomas Spura tomspur@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |tomspur@fedoraproject.org
--- Comment #4 from Thomas Spura tomspur@fedoraproject.org 2011-09-20 04:41:48 EDT --- Hmm, there is a draft of packaging such extensions a bit differently here: https://fedoraproject.org/wiki/User:Kalev/MozillaExtensionsDraft
So I further adjusted the noscript extension to follow that guideline a bit. Maybe you want to have a look at the new macros, I'm using there. I think, it's a bit clearer than just inst_dir and symlink_dir: http://pkgs.fedoraproject.org/gitweb/?p=mozilla-noscript.git;a=blob;f=mozill...
Not an issue, while reviewing this, more a RFC. Maybe that draft or the current packaging can still be enhanced :)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=739323
--- Comment #5 from Russell Golden niveusluna@niveusluna.org 2011-09-20 12:36:31 EDT --- Hm. Draft or no, that makes the SRPM *much* more readable. Thanks for the info.
Note: This extension is not packaged by upstream with an extension UUID, but with https-everywhere@eff.org. Every Mozilla browser currently packaged by Fedora can handle a name instead of a UUID, so it shouldn't be a problem. Just wanted to give a heads up in case someone wondered what was going on.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=739323
--- Comment #6 from Russell Golden niveusluna@niveusluna.org 2011-09-25 22:21:58 EDT --- Upstream updated.
New SRPM: https://niveusluna.org/kahiru/repo/fedora/free/SRPMS/mozilla-https-everywher... New spec file: https://niveusluna.org/kahiru/repo/fedora/free/SRPMS/mozilla-https-everywher...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=739323
Kevin Fenzi kevin@scrye.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |kevin@scrye.com Flag| |fedora-review?
--- Comment #7 from Kevin Fenzi kevin@scrye.com 2011-10-08 16:55:23 EDT --- I'll go ahead and look at reviewing this. Expect a review later today hopefully...
Do you have any packages you have pre-reviewed? Or are you planning on submitting any other packages at this time?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=739323
--- Comment #8 from Russell Golden niveusluna@niveusluna.org 2011-10-08 17:04:09 EDT --- No, and no.
In case it's needed, here's the link for the latest SRPM: https://niveusluna.org/files/repo/fedora/free/SRPMS/mozilla-https-everywhere...
The spec file is still at the same location. It doesn't change except for version number.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=739323
Kevin Fenzi kevin@scrye.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #9 from Kevin Fenzi kevin@scrye.com 2011-10-08 18:04:06 EDT ---
OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (GPLv2+) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: 05ea1355a3f2e91b1ca10dd8bb88a7ea ./https-everywhere-1.0.3.xpi 05ea1355a3f2e91b1ca10dd8bb88a7ea ./https-everywhere-1.0.3.xpi.orig OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package has rm -rf RPM_BUILD_ROOT at top of %install
OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - Package obey's FHS standard (except for 2 exceptions) See below - No rpmlint output. OK - final provides and requires are sane.
SHOULD Items:
OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have sane scriptlets. OK - Should have dist tag OK - Should package latest version OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin
Issues:
1. rpmlint says: mozilla-https-everywhere.noarch: W: spelling-error %description -l en_US unencrypted -> encrypted mozilla-https-everywhere.noarch: W: incoherent-version-in-changelog 1.0.1-1 ['1.0.3-1.fc17', '1.0.3-1'] mozilla-https-everywhere.src: W: spelling-error %description -l en_US unencrypted -> encrypted
You need to fix the changelog. The others can be ignored.
So, the only minor issue is the changelog entry. You can fix that before you import.
This package is APPROVED. I will go ahead and sponsor you.
You can continue the process from: https://fedoraproject.org/wiki/PackageMaintainers/Join#Add_Package_to_Source... Please feel free to ask me if you have any questions or run into problems.
Welcome to the packagers!
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=739323
--- Comment #10 from Russell Golden niveusluna@niveusluna.org 2011-10-08 21:37:23 EDT --- Spec file updated to include changelogs.
New SRPM: https://niveusluna.org/kahiru/repo/fedora/free/RPMS/noarch/mozilla-https-eve...
No idea if this is needed for CVS or not. If so, it's here. If not, people can hit delete on their emails. :)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=739323
--- Comment #11 from Russell Golden niveusluna@niveusluna.org 2011-10-08 21:49:27 EDT --- New Package SCM Request ======================= Package Name: mozilla-https-everywhere Short Description: HTTPS/HSTS enforcement extension for Mozilla browsers Owners: niveusluna Branches: f14 f15 f16 el5 el6 InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=739323
Russell Golden niveusluna@niveusluna.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=739323
--- Comment #12 from Jon Ciesla limb@jcomserv.net 2011-10-09 13:50:19 EDT --- Git done (by process-git-requests).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=739323
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=739323
--- Comment #13 from Fedora Update System updates@fedoraproject.org 2011-10-09 16:01:25 EDT --- mozilla-https-everywhere-1.0.3-2.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/mozilla-https-everywhere-1.0.3-2.fc1...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=739323
--- Comment #14 from Fedora Update System updates@fedoraproject.org 2011-10-09 16:03:04 EDT --- mozilla-https-everywhere-1.0.3-2.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/mozilla-https-everywhere-1.0.3-2.fc1...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=739323
--- Comment #15 from Fedora Update System updates@fedoraproject.org 2011-10-09 16:04:28 EDT --- mozilla-https-everywhere-1.0.3-2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/mozilla-https-everywhere-1.0.3-2.fc1...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=739323
--- Comment #16 from Fedora Update System updates@fedoraproject.org 2011-10-09 16:06:39 EDT --- mozilla-https-everywhere-1.0.3-2.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/mozilla-https-everywhere-1.0.3-2.el5
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=739323
--- Comment #17 from Fedora Update System updates@fedoraproject.org 2011-10-09 16:06:42 EDT --- mozilla-https-everywhere-1.0.3-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/mozilla-https-everywhere-1.0.3-2.el6
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=739323
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #18 from Fedora Update System updates@fedoraproject.org 2011-10-09 22:49:48 EDT --- mozilla-https-everywhere-1.0.3-2.fc15 has been pushed to the Fedora 15 testing repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=739323
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |mozilla-https-everywhere-1. | |0.3-2.fc15 Resolution| |ERRATA Last Closed| |2011-10-18 18:08:12
--- Comment #19 from Fedora Update System updates@fedoraproject.org 2011-10-18 18:08:12 EDT --- mozilla-https-everywhere-1.0.3-2.fc15 has been pushed to the Fedora 15 stable repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=739323
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|mozilla-https-everywhere-1. |mozilla-https-everywhere-1. |0.3-2.fc15 |0.3-2.fc14
--- Comment #20 from Fedora Update System updates@fedoraproject.org 2011-10-18 18:12:29 EDT --- mozilla-https-everywhere-1.0.3-2.fc14 has been pushed to the Fedora 14 stable repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=739323
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|mozilla-https-everywhere-1. |mozilla-https-everywhere-1. |0.3-2.fc14 |0.3-2.fc16
--- Comment #21 from Fedora Update System updates@fedoraproject.org 2011-10-19 00:34:42 EDT --- mozilla-https-everywhere-1.0.3-2.fc16 has been pushed to the Fedora 16 stable repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=739323
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|mozilla-https-everywhere-1. |mozilla-https-everywhere-1. |0.3-2.fc16 |0.3-2.el5
--- Comment #22 from Fedora Update System updates@fedoraproject.org 2011-11-01 20:06:26 EDT --- mozilla-https-everywhere-1.0.3-2.el5 has been pushed to the Fedora EPEL 5 stable repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=739323
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|mozilla-https-everywhere-1. |mozilla-https-everywhere-1. |0.3-2.el5 |0.3-2.el6
--- Comment #23 from Fedora Update System updates@fedoraproject.org 2011-11-01 20:08:50 EDT --- mozilla-https-everywhere-1.0.3-2.el6 has been pushed to the Fedora EPEL 6 stable repository.
https://bugzilla.redhat.com/show_bug.cgi?id=739323
Jan Kratochvil jan.kratochvil@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1154321
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1154321 [Bug 1154321] Fedora Packaging Rules violation: No source for defaults/rulesets.sqlite
https://bugzilla.redhat.com/show_bug.cgi?id=739323 Bug 739323 depends on bug 1154321, which changed state.
Bug 1154321 Summary: Fedora Packaging Rules violation: No source for defaults/rulesets.sqlite https://bugzilla.redhat.com/show_bug.cgi?id=1154321
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |EOL
https://bugzilla.redhat.com/show_bug.cgi?id=739323 Bug 739323 depends on bug 1154321, which changed state.
Bug 1154321 Summary: Fedora Packaging Rules violation: No source for defaults/rulesets.sqlite https://bugzilla.redhat.com/show_bug.cgi?id=1154321
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |NEW Resolution|EOL |---
package-review@lists.fedoraproject.org