https://bugzilla.redhat.com/show_bug.cgi?id=1288739
Bug ID: 1288739 Summary: Review Request: petpvc - Toolbox for partial volume correction (PVC) in positron emission tomography (PET) Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: i.gnatenko.brain@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://ignatenkobrain.fedorapeople.org/neurofedora/petpvc.spec SRPM URL: https://ignatenkobrain.fedorapeople.org/neurofedora/petpvc-0.0.0-0.1.git7758... Description: Toolbox for partial volume correction (PVC) in positron emission tomography (PET). Fedora Account System Username: ignatenkobrain
https://bugzilla.redhat.com/show_bug.cgi?id=1288739
Igor Gnatenko i.gnatenko.brain@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1276941 (fedora-neuro) Alias| |petpvc
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1276941 [Bug 1276941] Fedora NeuroImaging and NeuroScience tracking bug
https://bugzilla.redhat.com/show_bug.cgi?id=1288739
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST CC| |zbyszek@in.waw.pl Assignee|nobody@fedoraproject.org |zbyszek@in.waw.pl Flags| |fedora-review+
--- Comment #1 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- No need to 'rm -rf build', %autosetup recreated the source directory anyway.
Please extend the %description... What is this software actually useful for, what does it do?
Seems to be missing BR: InsightToolkit-devel, gdcm-devel, fftw-devel, vxl-devel.
+ license is OK (ASL 2) + license file is present, %license is used + name is OK + latest version (git snapshot) + %check is present, some checks fail + builds and installs, binaries run
rpmlint: petpvc.src: E: summary-too-long C Toolbox for partial volume correction (PVC) in positron emission tomography (PET) petpvc.src: E: description-line-too-long C Toolbox for partial volume correction (PVC) in positron emission tomography (PET). petpvc.x86_64: E: summary-too-long C Toolbox for partial volume correction (PVC) in positron emission tomography (PET) petpvc.x86_64: E: description-line-too-long C Toolbox for partial volume correction (PVC) in positron emission tomography (PET). Please fix. Maybe "Toolbox for partial volume correction in positron emission tomography"?
petpvc.x86_64: W: no-manual-page-for-binary pvc_rl petpvc.x86_64: W: no-manual-page-for-binary pvc_mtc petpvc.x86_64: W: no-manual-page-for-binary petpvc petpvc.x86_64: W: no-manual-page-for-binary pvc_vc petpvc.x86_64: W: no-manual-page-for-binary pvc_iy petpvc.x86_64: W: no-manual-page-for-binary pvc_rbv petpvc.x86_64: W: no-manual-page-for-binary pvc_mg petpvc.x86_64: W: no-manual-page-for-binary pvc_diy petpvc.x86_64: W: no-manual-page-for-binary pvc_gtm petpvc.x86_64: W: no-manual-page-for-binary pvc_labbe petpvc.x86_64: W: no-manual-page-for-binary pvc_simulate 3 packages and 0 specfiles checked; 4 errors, 11 warnings.
OK.
Please fix the missing BR and summary and description when importing. Package is APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=1288739
Igor Gnatenko i.gnatenko.brain@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: petpvc - |Review Request: petpvc - |Toolbox for partial volume |Tools for partial volume |correction (PVC) in |correction (PVC) in |positron emission |positron emission |tomography (PET) |tomography (PET)
https://bugzilla.redhat.com/show_bug.cgi?id=1288739
--- Comment #2 from Jon Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/petpvc
https://bugzilla.redhat.com/show_bug.cgi?id=1288739
Igor Gnatenko i.gnatenko.brain@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1291010
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1291010 [Bug 1291010] [ARM] terminate called after throwing an instance of 'std::length_error'
https://bugzilla.redhat.com/show_bug.cgi?id=1288739
Sat6QE Jenkins sat6-jenkins@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1288739
Mike McCune mmccune@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |POST
--- Comment #3 from Mike McCune mmccune@redhat.com --- This bug was accidentally moved from POST to MODIFIED via an error in automation, please see mmccune@redhat.com with any questions
https://bugzilla.redhat.com/show_bug.cgi?id=1288739
Igor Gnatenko ignatenko@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Alias|petpvc |
https://bugzilla.redhat.com/show_bug.cgi?id=1288739 Bug 1288739 depends on bug 1291010, which changed state.
Bug 1291010 Summary: [ARM] terminate called after throwing an instance of 'std::length_error' https://bugzilla.redhat.com/show_bug.cgi?id=1291010
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |EOL
https://bugzilla.redhat.com/show_bug.cgi?id=1288739
Ankur Sinha (FranciscoD) sanjay.ankur@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED CC| |sanjay.ankur@gmail.com Resolution|--- |CURRENTRELEASE Last Closed| |2018-08-05 05:37:58
--- Comment #4 from Ankur Sinha (FranciscoD) sanjay.ankur@gmail.com --- Imported, built, and available for use. Closing.
package-review@lists.fedoraproject.org