[Bug 602767] New: Review Request: perl-MooseX-MarkAsMethods - Mark overload code symbols as methods
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: perl-MooseX-MarkAsMethods - Mark overload code symbols as methods
https://bugzilla.redhat.com/show_bug.cgi?id=602767
Summary: Review Request: perl-MooseX-MarkAsMethods - Mark overload code symbols as methods Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: ppisar@redhat.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Target Release: ---
Spec URL: http://ppisar.fedorapeople.org/perl-MooseX-MarkAsMethods/perl-MooseX-MarkAsM... SRPM URL: http://ppisar.fedorapeople.org/perl-MooseX-MarkAsMethods/perl-MooseX-MarkAsM... Description: MooseX::MarkAsMethods allows one to easily mark certain functions as Moose methods. This will allow other packages such as namespace::autoclean to operate without blowing away your overloads. After using MooseX::MarkAsMethods your overloads will be recognized by Class::MOP as being methods, and class extension as well as composition from roles with overloads will "just work".
This package is required to upgrade perl-Archive-RPM to 0.05 version.
Package compiles on F14--13. F12 has too old perl-Moose.
I'm not sure whether include both README and README.mkdn into %doc. They are similar but the latter one is generated at compile time. Current spec file includes both of them.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=602767
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |599859
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=602767
Marcela Mašláňová mmaslano@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |mmaslano@redhat.com
--- Comment #1 from Marcela Mašláňová mmaslano@redhat.com 2010-06-14 08:42:23 EDT --- OK rpmlint checks return: [marca@caladan SRPMS]$ rpmlint perl-MooseX-MarkAsMethods-0.08-1.fc13.src.rpm perl-MooseX-MarkAsMethods.src: W: spelling-error %description -l en_US namespace -> name space, name-space, names pace perl-MooseX-MarkAsMethods.src: W: spelling-error %description -l en_US autoclean -> auto clean, auto-clean, autoclave 1 packages and 0 specfiles checked; 0 errors, 2 warnings. [marca@caladan SRPMS]$ rpmlint ../RPMS/noarch/perl-MooseX-MarkAsMethods-0.08-1.fc13.noarch.rpm perl-MooseX-MarkAsMethods.noarch: W: spelling-error %description -l en_US namespace -> name space, name-space, names pace perl-MooseX-MarkAsMethods.noarch: W: spelling-error %description -l en_US autoclean -> auto clean, auto-clean, autoclave 1 packages and 0 specfiles checked; 0 errors, 2 warnings.
OK package meets naming guidelines OK package meets packaging guidelines OK license (LGPLv2+) OK, text in %doc, matches source OK spec file legible, in am. english OK source matches upstream OK package compiles on devel (x86) OK no missing BR OK no unnecessary BR OK no locales OK not relocatable OK owns all directories that it creates OK no duplicate files OK permissions ok OK %clean ok OK macro use consistent OK code, not content OK no need for -docs OK nothing in %doc affects runtime OK no need for .desktop file
New version 0.09 is available. Please update, the latest version is fixing version of Moose in requirements.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=602767
--- Comment #2 from Marcela Mašláňová mmaslano@redhat.com 2010-06-14 08:42:53 EDT --- Both readme could stay in package.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=602767
--- Comment #3 from Petr Pisar ppisar@redhat.com 2010-06-14 11:51:20 EDT --- Both spelling errors are false; The words are literals (perl package name).
New version 0.09 does not provide fix. It still does not updates required version in the module itself. Upstream noticed. Do you mind reviewing 0.08? Both versions are almost identical.
The 0.08 spec includes both REAMDE files yet.
Marcela, could accept this package and set review flag to +?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=602767
Marcela Mašláňová mmaslano@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review+
--- Comment #4 from Marcela Mašláňová mmaslano@redhat.com 2010-06-15 11:05:50 EDT --- ACCEPTED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=602767
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #5 from Petr Pisar ppisar@redhat.com 2010-06-15 12:11:41 EDT --- New Package CVS Request ======================= Package Name: perl-MooseX-MarkAsMethods Short Description: Mark overload code symbols as methods Owners: ppisar mmaslano psabata Branches: F-13 InitialCC: perl-sig
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=602767
Huzaifa S. Sidhpurwala huzaifas@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
--- Comment #6 from Huzaifa S. Sidhpurwala huzaifas@redhat.com 2010-06-18 03:59:48 EDT --- cvs done
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=602767
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
--- Comment #7 from Petr Pisar ppisar@redhat.com 2010-06-18 05:20:32 EDT --- Thank you for review and CVS update. Package built for F-14 and F-13.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=602767
--- Comment #8 from Fedora Update System updates@fedoraproject.org 2010-06-18 05:31:48 EDT --- perl-MooseX-MarkAsMethods-0.10-1.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/perl-MooseX-MarkAsMethods-0.10-1.fc13
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=602767
--- Comment #9 from Fedora Update System updates@fedoraproject.org 2010-07-07 13:51:38 EDT --- perl-MooseX-MarkAsMethods-0.10-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla