https://bugzilla.redhat.com/show_bug.cgi?id=1918405
Bug ID: 1918405 Summary: Review Request: nodejs-tiddlywiki - A non-linear personal web notebook for Node.js and browsers Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: mike@flyn.org QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://www.flyn.org/SRPMS/nodejs-tiddlywiki.spec SRPM URL: https://www.flyn.org/SRPMS/nodejs-tiddlywiki-5.1.23-1.fc33.src.rpm Description: A non-linear personal web notebook for Node.js and browsers. Fedora Account System Username: mike
I am new to node.js and node.js packaging. It is difficult for me to see whether I have this right or if node.js is pulling in portions of tiddlywiki at runtime.
I did notice that the nodejs-packaging-bundler package is not presently in the Fedora 33 repository (i.e., https://dl.fedoraproject.org/pub/fedora/linux/releases/33/Everything/x86_64/...). I had to build this package myself. Is this expected?
https://bugzilla.redhat.com/show_bug.cgi?id=1918405
Robert-André Mauchin 🐧 zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@gmail.com Doc Type|--- |If docs needed, set a value
--- Comment #1 from Robert-André Mauchin 🐧 zebob.m@gmail.com --- Have you considered: https://fedoraproject.org/wiki/Changes/NodejsLibrariesBundleByDefault ?
https://bugzilla.redhat.com/show_bug.cgi?id=1918405
--- Comment #2 from Robert-André Mauchin 🐧 zebob.m@gmail.com ---
- How is this generated:
Source1: %{npm_name}-%{version}-nm-dev.tgz
Add a comment to explain it.
- You unzip Source1 but do not run tests with it?
%check %{__nodejs} -e 'require("./")' # Setup bundled dev node_modules for testing # Note: this cannot be in %%prep or the dev node_modules # can get pulled into the regular rpm tar xfz %{SOURCE1}
- Package should start with:
%{?nodejs_find_provides_and_requires}
- %nodejs_symlink_deps should be run at the end of install
- I suggest naming the package tiddlywiki if this is a standalone application
- What's the point of Source2: %{npm_name}-%{version}-bundled-licenses.txt? There is already a "license" file with the BSD copy.
https://bugzilla.redhat.com/show_bug.cgi?id=1918405
--- Comment #3 from W. Michael Petullo mike@flyn.org --- Spec URL: https://www.flyn.org/SRPMS/tiddlywiki.spec SRPM URL: https://www.flyn.org/SRPMS/tiddlywiki-5.1.23-2.fc33.src.rpm
- Make use of nodejs_find_provides_and_requires macro - Make use of nodejs_symlink_deps macro - Rename package from nodejs-tiddlywiki to tiddlywiki - Drop ...bundled-licenses.txt, use install, which is distributed with source - Drop ...-nm-dev.tgz
https://bugzilla.redhat.com/show_bug.cgi?id=1918405
--- Comment #4 from Robert-André Mauchin 🐧 zebob.m@gmail.com --- - Something is wrong with the package, the only .js shipped contains:
#!/usr/bin/env node
/* This is invoked as a shell script by NPM when the `tiddlywiki` command is typed */
var $tw = require("./boot/boot.js").TiddlyWiki();
// Pass the command line arguments to the boot kernel $tw.boot.argv = Array.prototype.slice.call(process.argv,2);
// Boot the TW5 app $tw.boot.boot();
no other js is shipped so I don't see how this package could work. There are tons of other files in the archive that you don't install.
Product: Fedora Version: rawhide Component: Package Review
Package Review package-review@lists.fedoraproject.org has canceled Package Review package-review@lists.fedoraproject.org's request for W. Michael Petullo mike@flyn.org's needinfo: Bug 1918405: Review Request: tiddlywiki - A non-linear personal web notebook for Node.js and browsers https://bugzilla.redhat.com/show_bug.cgi?id=1918405
--- Comment #6 from Package Review package-review@lists.fedoraproject.org --- This is an automatic action taken by review-stats script.
The ticket submitter failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we consider this ticket as DEADREVIEW and proceed to close it.
package-review@lists.fedoraproject.org