[Bug 399951] New: Review Request: PyAmanith - Python bindings for Amanith

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/show_bug.cgi?id=399951

Summary: Review Request: PyAmanith - Python bindings for Amanith
           Product: Fedora
           Version: devel
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail],[e-mail]

Spec URL: http://www.auroralinux.org/people/spot/review/new/PyAmanith.spec
SRPM URL: http://www.auroralinux.org/people/spot/review/new/PyAmanith-0.3.35-1.fc9.src...
Description: 
PyAmanith is a Python wrapper for the Amanith (http://www.amanith.org) 2D
vector graphics library. It strives to offer a pythonic interface to the
library and make all its features accessible.

[Bug 399951] Review Request: PyAmanith - Python bindings for Amanith

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: PyAmanith - Python bindings for Amanith

https://bugzilla.redhat.com/show_bug.cgi?id=399951

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|devel                       |rawhide

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  BugsThisDependsOn|                            |399941

[Bug 399951] Review Request: PyAmanith - Python bindings for Amanith

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: PyAmanith - Python bindings for Amanith

https://bugzilla.redhat.com/show_bug.cgi?id=399951

Bug 399951 depends on bug 399941, which changed state.

Bug 399941 Summary: Review Request: amanith - Crossplatform framework for 2d/3d vector graphics
https://bugzilla.redhat.com/show_bug.cgi?id=399941

What    |Old Value                   |New Value
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEEDINFO
             Status|NEEDINFO                    |ASSIGNED
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |RAWHIDE

[Bug 399951] Review Request: PyAmanith - Python bindings for Amanith

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: PyAmanith - Python bindings for Amanith

https://bugzilla.redhat.com/show_bug.cgi?id=399951

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]    |[e-mail]
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review?

------- Additional Comments From [e-mail]  2008-01-18 22:19 EST -------
It occurs to me that this might have been submitted as a dependency for Frets on
Fire, but I'll go ahead and review it and you can do with it what you will.

This failed to build for me in rawhide due to the .egg-info thing.  I fixed that
(and I'll just assume that it's been fixed for the remainder of this review) and
got the following rpmlint complaint:

PyAmanith.x86_64: E: non-standard-executable-perm 
   /usr/lib64/python2.5/site-packages/_amanith.so 0775
which is a little weird, I'll admit.  A chmod or %attr should get rid if it, though.

There's a copying file in the tarball that should make it into the package,
especially since it's the only place I found with the text of the GPL exception
the package is licensed under.

* source files match upstream:
   a16a3a8379246549008c514fb549337700ea5a17ba524187f8213e92f9a966f0  
   PyAmanith-0.3.35.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
X license text not included in package.
* latest version is being packaged.
* BuildRequires are proper.
* compiler flags are appropriate.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly
* debuginfo package looks complete.
X rpmlint has a valid complaint.
* final provides and requires are sane:
   _amanith.so()(64bit)
   PyAmanith = 0.3.35-1.fc9
  =
   libamanith.so.1()(64bit)
   libgcc_s.so.1()(64bit)
   libgcc_s.so.1(GCC_3.0)(64bit)
   libpython2.5.so.1.0()(64bit)
   libstdc++.so.6()(64bit)
   libstdc++.so.6(CXXABI_1.3)(64bit)
   libstdc++.so.6(GLIBCXX_3.4)(64bit)
   python(abi) = 2.5

* %check is not present; no test suite upstream.  rawhide is screwed enough at 
   the moment that I can't test it manually.
* no shared libraries are added to the regular linker search paths.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no static libraries.
* no libtool .la files.

[Bug 399951] Review Request: PyAmanith - Python bindings for Amanith

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: PyAmanith - Python bindings for Amanith

https://bugzilla.redhat.com/show_bug.cgi?id=399951

------- Additional Comments From [e-mail]  2008-02-28 14:46 EST -------
Sorry for the delay. This one fell off my radar for a bit, due to the fact that
we discovered that FretsOnFire was no-go for Fedora.

All issues mentioned above are resolved in -2.

New SRPM:
http://www.auroralinux.org/people/spot/review/new/PyAmanith-0.3.35-2.fc9.src...
New SPEC: http://www.auroralinux.org/people/spot/review/new/PyAmanith.spec

[Bug 399951] Review Request: PyAmanith - Python bindings for Amanith

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: PyAmanith - Python bindings for Amanith

https://bugzilla.redhat.com/show_bug.cgi?id=399951

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

------- Additional Comments From [e-mail]  2008-02-28 20:14 EST -------
OK; builds fine now, rpmlint is silent andthe COPYING file is included.  Looks
good to me.

APPROVED

[Bug 399951] Review Request: PyAmanith - Python bindings for Amanith

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: PyAmanith - Python bindings for Amanith

https://bugzilla.redhat.com/show_bug.cgi?id=399951

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

------- Additional Comments From [e-mail]  2008-03-10 14:58 EST -------
New Package CVS Request
=======================
Package Name: pyamanith
Short Description: Python bindings for Amanith
Owners: spot
Branches: F-7 F-8 devel
InitialCC: 
Cvsextras Commits: yes

[Bug 399951] Review Request: PyAmanith - Python bindings for Amanith

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: PyAmanith - Python bindings for Amanith

https://bugzilla.redhat.com/show_bug.cgi?id=399951

------- Additional Comments From [e-mail]  2008-03-10 15:00 EST -------
Ugh, I screwed this up. Should be:

New Package CVS Request
=======================
Package Name: PyAmanith
Short Description: Python bindings for Amanith
Owners: spot
Branches: F-7 F-8 devel
InitialCC: 
Cvsextras Commits: yes

[Bug 399951] Review Request: PyAmanith - Python bindings for Amanith

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: PyAmanith - Python bindings for Amanith

https://bugzilla.redhat.com/show_bug.cgi?id=399951

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

[Bug 399951] Review Request: PyAmanith - Python bindings for Amanith

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: PyAmanith - Python bindings for Amanith

https://bugzilla.redhat.com/show_bug.cgi?id=399951

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |RAWHIDE

------- Additional Comments From [e-mail]  2008-03-10 22:16 EST -------
In rawhide, thanks for the review.