[Bug 1128356] New: Review Request: minipro - Utility for MiniPro TL866A/TL866/CS programmer

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1128356

Bug ID: 1128356
           Summary: Review Request: minipro - Utility for MiniPro
                    TL866A/TL866/CS programmer
           Product: Fedora
           Version: rawhide
         Component: Package Review
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]

SPEC: http://v3.sk/~lkundrak/SPECS/minipro.spec
SRPM: http://v3.sk/~lkundrak/SRPMS/minipro-0-1.20140624gite521a63.fc20.src.rpm

Description:

Programming utility compatible with Minipro TL866CS and Minipro TL866A
programmers. Supports more than 13000 target devices (including AVRs, PICs,
various BIOSes and EEPROMs).

[Bug 1128356] Review Request: minipro - Utility for MiniPro TL866A/TL866/CS programmer

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1128356

--- Comment #1 from Christopher Meng  ---
%config(noreplace) %{_sysconfdir}/bash_completion.d

You shouldn't set this as %config.

[Bug 1128356] Review Request: minipro - Utility for MiniPro TL866A/TL866/CS programmer

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1128356

--- Comment #2 from Lubomir Rintel  ---
(In reply to Christopher Meng from comment #1)
> %config(noreplace) %{_sysconfdir}/bash_completion.d
>
> You shouldn't set this as %config.

But rpmlint behaves like it doesn't love me anymore then :(

SPEC: http://v3.sk/~lkundrak/SPECS/minipro.spec
SRPM: http://v3.sk/~lkundrak/SRPMS/minipro-0-2.20140624gite521a63.fc20.src.rpm

[Bug 1128356] Review Request: minipro - Utility for MiniPro TL866A/TL866/CS programmer

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1128356

--- Comment #3 from Lubomir Rintel  ---
SPEC: http://v3.sk/~lkundrak/SPECS/minipro.spec
SRPM: http://v3.sk/~lkundrak/SRPMS/minipro-0-2.20140902git6f36b9e.fc20.src.rpm

[Bug 1128356] Review Request: minipro - Utility for MiniPro TL866A/TL866/CS programmer

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1128356

Mihkel Vain  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
           Assignee|[e-mail]    |[e-mail]
              Flags|                            |fedora-review?

[Bug 1128356] Review Request: minipro - Utility for MiniPro TL866A/TL866/CS programmer

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1128356

--- Comment #4 from Mihkel Vain  ---
Ok. Few comments at first:

rpmlint *.rpm
minipro.src: W: name-repeated-in-summary C MiniPro
minipro.x86_64: W: name-repeated-in-summary C MiniPro
minipro.x86_64: W: only-non-binary-in-usr-lib
minipro.x86_64: W: non-conffile-in-etc /etc/bash_completion.d/minipro
minipro.x86_64: E: sourced-script-with-shebang /etc/bash_completion.d/minipro
/bin/bash
minipro.x86_64: W: no-manual-page-for-binary minipro-query-db
minipro.x86_64: W: no-manual-page-for-binary miniprohex
minipro-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/minipro-6f36b9eff8b82d5aa89f2fb07b0940383327a896/easyconfig.c
minipro-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/minipro-6f36b9eff8b82d5aa89f2fb07b0940383327a896/easyconfig.h
3 packages and 0 specfiles checked; 3 errors, 6 warnings.

--------------------------------------------
minipro.src: W: name-repeated-in-summary C MiniPro
minipro.x86_64: W: name-repeated-in-summary C MiniPro

To me Summary looks fine. I think we can ignore those.

minipro.x86_64: W: non-conffile-in-etc /etc/bash_completion.d/minipro
minipro.x86_64: E: sourced-script-with-shebang /etc/bash_completion.d/minipro
/bin/bash

I think you should remove the shebang

minipro.x86_64: W: no-manual-page-for-binary minipro-query-db
minipro.x86_64: W: no-manual-page-for-binary miniprohex
minipro-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/minipro-6f36b9eff8b82d5aa89f2fb07b0940383327a896/easyconfig.c
minipro-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/minipro-6f36b9eff8b82d5aa89f2fb07b0940383327a896/easyconfig.h

Manual pages are a SHOULD according to this
https://fedoraproject.org/wiki/Packaging:ReviewGuidelines
But not a blocker.
Also you should notify upstream about fsf address.

So. If you remove shebang I think we are good to go.

[Bug 1128356] Review Request: minipro - Utility for MiniPro TL866A/TL866/CS programmer

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1128356

Lubomir Rintel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #5 from Lubomir Rintel  ---
SPEC: http://v3.sk/~lkundrak/SPECS/minipro.spec
SRPM: http://v3.sk/~lkundrak/SRPMS/minipro-0-3.20140902git6f36b9e.fc20.src.rpm

[Bug 1128356] Review Request: minipro - Utility for MiniPro TL866A/TL866/CS programmer

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1128356

Mihkel Vain  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+

--- Comment #6 from Mihkel Vain  ---
  CHECKSUM(SHA256) this package     :
28190b0b1c5f7ffdc575ddd6736db519fd79a1f16f01412ebc8e3c2033fd6d88
  CHECKSUM(SHA256) upstream package :
28190b0b1c5f7ffdc575ddd6736db519fd79a1f16f01412ebc8e3c2033fd6d88

Checksum is good. LICENSE is included in source tarball and is acceptable for
Fedora. Although rpmlint produces 5 warnings and mentions about wrong FSF
address in two source files (easyconfig.c and easyconfig.h) I consider them a
non-blockers, but you should notify upstream about wrong FSF address.

APPROVED

[Bug 1128356] Review Request: minipro - Utility for MiniPro TL866A/TL866/CS programmer

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1128356

Lubomir Rintel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-cvs?

--- Comment #7 from Lubomir Rintel  ---
New Package SCM Request
=======================
Package Name: minipro
Short Description: Utility for MiniPro TL866A/TL866/CS programmer
Upstream URL: https://github.com/vdudouyt/minipro
Owners: lkundrak
Branches: f20 f21 el6 epel7

[Bug 1128356] Review Request: minipro - Utility for MiniPro TL866A/TL866/CS programmer

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1128356

Jon Ciesla  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-cvs?                 |fedora-cvs+

[Bug 1128356] Review Request: minipro - Utility for MiniPro TL866A/TL866/CS programmer

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1128356

--- Comment #8 from Jon Ciesla  ---
Git done (by process-git-requests).

[Bug 1128356] Review Request: minipro - Utility for MiniPro TL866A/TL866/CS programmer

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1128356

Lubomir Rintel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |CLOSED
                 CC|                            |[e-mail]
         Resolution|---                         |NEXTRELEASE
        Last Closed|                            |2014-10-01 06:13:20

--- Comment #9 from Lubomir Rintel  ---
Imported and built.

Thank you!