https://bugzilla.redhat.com/show_bug.cgi?id=2185040
Bug ID: 2185040 Summary: Review Request: <main package name here> - <short summary here> Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: mads@kiilerich.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://gist.githubusercontent.com/kiilerix/f21eaffd3d1220e6077fa36c9125f24a... SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/2810/99592810/rust-logging_ti... Description: Simple timers that log the elapsed time when dropped Fedora Account System Username: kiilerix
This depends on the recent packaged rust-logging_timer_proc_macros , and will be needed for upgrading Mercurial to 6.4
https://bugzilla.redhat.com/show_bug.cgi?id=2185040
Mads Kiilerich mads@kiilerich.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mads@kiilerich.com Doc Type|--- |If docs needed, set a value Summary|Review Request: <main |Review Request: |package name here> - <short |rust-logging_timer - Simple |summary here> |timers that log the elapsed | |time when dropped
https://bugzilla.redhat.com/show_bug.cgi?id=2185040
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |decathorpe@gmail.com Status|NEW |POST CC| |decathorpe@gmail.com Flags| |fedora-review+
--- Comment #1 from Fabio Valentini decathorpe@gmail.com --- Package was generated with rust2rpm, simplifying the review.
- package builds and installs without errors on rawhide ? test suite is run and all unit tests pass (there are no tests) - latest version of the crate is packaged - license matches upstream specification (MIT) and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines
Package APPROVED.
===
Recommended post-import rust-sig tasks:
- add @rust-sig with "commit" access as package co-maintainer
- set bugzilla assignee overrides to @rust-sig (optional)
- set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate
- track package in koschei for all built branches
===
Note that there are quite a lot of warnings emitted during the build. It appears that the doctests use an invalid "norun" attribute instead of "no_run". You might want to report this upstream.
https://bugzilla.redhat.com/show_bug.cgi?id=2185040
--- Comment #2 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-logging_timer
https://bugzilla.redhat.com/show_bug.cgi?id=2185040
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #3 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-31c0e78c1d has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-31c0e78c1d
https://bugzilla.redhat.com/show_bug.cgi?id=2185040
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA Last Closed| |2023-04-07 22:53:48
--- Comment #4 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-31c0e78c1d has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org