[Bug 1420378] New: Review Request: php-phpunit-mock-objects4 - ock Object library for PHPUnit

https://bugzilla.redhat.com/show_bug.cgi?id=1420378

Bug ID: 1420378
           Summary: Review Request: php-phpunit-mock-objects4 - ock Object
                    library for PHPUnit
           Product: Fedora
           Version: rawhide
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]

Spec URL:
https://raw.githubusercontent.com/remicollet/remirepo/master/php/phpunit/php...
SRPM URL:
http://rpms.remirepo.net/SRPMS/php-phpunit-mock-objects4-4.0.0-1.remi.src.rp...
Description: 
Mock Object library for PHPUnit

Fedora Account System Username: remi

[Bug 1420378] Review Request: php-phpunit-mock-objects4 - ock Object library for PHPUnit

https://bugzilla.redhat.com/show_bug.cgi?id=1420378

Remi Collet  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |1420381

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1420381
[Bug 1420381] Review Request: phpunit6 - The PHP Unit Testing framework

[Bug 1420378] Review Request: php-phpunit-mock-objects4 - ock Object library for PHPUnit

https://bugzilla.redhat.com/show_bug.cgi?id=1420378

Remi Collet  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends On|                            |1428912

--- Comment #1 from Remi Collet  ---
Updated to 4.0.1

Spec:
https://raw.githubusercontent.com/remicollet/remirepo/d5483e903e9f49e3efad19...
Srpm:
http://rpms.remirepo.net/SRPMS/php-phpunit-mock-objects4-4.0.1-1.remi.src.rp...

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1428912
[Bug 1428912] Review Request: php-sebastian-exporter3 - Export PHP
variables for visualization

[Bug 1420378] Review Request: php-phpunit-mock-objects4 - ock Object library for PHPUnit

https://bugzilla.redhat.com/show_bug.cgi?id=1420378

--- Comment #2 from Remi Collet  ---
Fix for autoloader:

Spec: https://raw.githubusercontent.com/remicollet/remirepo
/ef56d4822b27c0602e0f2ff509031b39f8cfdce2/php/phpunit/php-phpunit-mock-objects4/php-phpunit-mock-objects4.spec
Srpm:
http://rpms.remirepo.net/SRPMS/php-phpunit-mock-objects4-4.0.1-2.remi.src.rp...

[Bug 1420378] Review Request: php-phpunit-mock-objects4 - ock Object library for PHPUnit

https://bugzilla.redhat.com/show_bug.cgi?id=1420378

Shawn Iwinski  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail],
                   |                            |[e-mail]
              Flags|                            |needinfo?(fedora@famillecol
                   |                            |let.com)

--- Comment #3 from Shawn Iwinski  ---
Since this package installs into "/usr/share/php/PHPUnit6/Framework/MockObject"
instead of "/usr/share/php/PHPUnit/Framework/MockObject4", shouldn't this
package be named "php-phpunit6-mock-objects"?

[Bug 1420378] Review Request: php-phpunit-mock-objects4 - ock Object library for PHPUnit

https://bugzilla.redhat.com/show_bug.cgi?id=1420378

Remi Collet  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?(fedora@famillecol |
                   |let.com)                    |

--- Comment #4 from Remi Collet  ---
(In reply to Shawn Iwinski from comment #3)
> Since this package installs into
> "/usr/share/php/PHPUnit6/Framework/MockObject" instead of
> "/usr/share/php/PHPUnit/Framework/MockObject4", shouldn't this package be
> named "php-phpunit6-mock-objects"?

I choice to install in Phpunit6, as this is used by the phpunit6 package, but
for the name I prefer to match the API version of the library.

BTW... both make sense... only my idea ;)

[Bug 1420378] Review Request: php-phpunit-mock-objects4 - ock Object library for PHPUnit

https://bugzilla.redhat.com/show_bug.cgi?id=1420378

Shawn Iwinski  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|[e-mail]    |[e-mail]
              Flags|                            |fedora-review?

[Bug 1420378] Review Request: php-phpunit-mock-objects4 - ock Object library for PHPUnit

https://bugzilla.redhat.com/show_bug.cgi?id=1420378

--- Comment #5 from Shawn Iwinski  ---
Created attachment 1262076
  --> https://bugzilla.redhat.com/attachment.cgi?id=1262076&action=edit
phpcompatinfo-full.log

phpCompatInfo version 5.0.4 DB version 1.17.0 built Jan 24 2017 10:56:54 CET

[Bug 1420378] Review Request: php-phpunit-mock-objects4 - ock Object library for PHPUnit

https://bugzilla.redhat.com/show_bug.cgi?id=1420378

--- Comment #6 from Shawn Iwinski  ---
Created attachment 1262077
  --> https://bugzilla.redhat.com/attachment.cgi?id=1262077&action=edit
phpcompatinfo-lib.log

phpCompatInfo version 5.0.4 DB version 1.17.0 built Jan 24 2017 10:56:54 CET

[Bug 1420378] Review Request: php-phpunit-mock-objects4 - ock Object library for PHPUnit

https://bugzilla.redhat.com/show_bug.cgi?id=1420378

--- Comment #7 from Shawn Iwinski  ---
Created attachment 1262078
  --> https://bugzilla.redhat.com/attachment.cgi?id=1262078&action=edit
fedora-review.txt

Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review --mock-config fedora-rawhide-x86_64 --bug
1420378
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, PHP, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl,
Haskell, R
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

[Bug 1420378] Review Request: php-phpunit-mock-objects4 - Mock Object library for PHPUnit

https://bugzilla.redhat.com/show_bug.cgi?id=1420378

Shawn Iwinski  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Review Request:             |Review Request:
                   |php-phpunit-mock-objects4 - |php-phpunit-mock-objects4 -
                   |ock Object library for      |Mock Object library for
                   |PHPUnit                     |PHPUnit

[Bug 1420378] Review Request: php-phpunit-mock-objects4 - Mock Object library for PHPUnit

https://bugzilla.redhat.com/show_bug.cgi?id=1420378

Shawn Iwinski  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+

--- Comment #8 from Shawn Iwinski  ---
[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
     Note: rm -rf %{buildroot} present but not required

Remove EPEL 5 bits after initial import

[!]: Spec file according to URL is the same as in SRPM.
     Note: Spec file as given by url is not the same as in SRPM (see
     attached diff).

Diffs just turning on bootstrap.

No blockers

===== APPROVED =====

[Bug 1420378] Review Request: php-phpunit-mock-objects4 - Mock Object library for PHPUnit

https://bugzilla.redhat.com/show_bug.cgi?id=1420378

--- Comment #9 from Remi Collet  ---
Thanks for the review.

New packages requested.

[Bug 1420378] Review Request: php-phpunit-mock-objects4 - Mock Object library for PHPUnit

https://bugzilla.redhat.com/show_bug.cgi?id=1420378

--- Comment #10 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/php-phpunit-mock-objects4

[Bug 1420378] Review Request: php-phpunit-mock-objects4 - Mock Object library for PHPUnit

https://bugzilla.redhat.com/show_bug.cgi?id=1420378

--- Comment #11 from Fedora Update System  ---
php-phpunit-mock-objects4-4.0.1-2.fc26 has been submitted as an update to
Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-d605f6d602

[Bug 1420378] Review Request: php-phpunit-mock-objects4 - Mock Object library for PHPUnit

https://bugzilla.redhat.com/show_bug.cgi?id=1420378

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |MODIFIED

[Bug 1420378] Review Request: php-phpunit-mock-objects4 - Mock Object library for PHPUnit

https://bugzilla.redhat.com/show_bug.cgi?id=1420378

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |ON_QA

--- Comment #12 from Fedora Update System  ---
php-phpunit-mock-objects4-4.0.1-2.fc26 has been pushed to the Fedora 26 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-d605f6d602

[Bug 1420378] Review Request: php-phpunit-mock-objects4 - Mock Object library for PHPUnit

https://bugzilla.redhat.com/show_bug.cgi?id=1420378
Bug 1420378 depends on bug 1428912, which changed state.

Bug 1428912 Summary: Review Request: php-sebastian-exporter3 - Export PHP variables for visualization
https://bugzilla.redhat.com/show_bug.cgi?id=1428912

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |CLOSED
         Resolution|---                         |ERRATA

[Bug 1420378] Review Request: php-phpunit-mock-objects4 - Mock Object library for PHPUnit

https://bugzilla.redhat.com/show_bug.cgi?id=1420378

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |CLOSED
         Resolution|---                         |ERRATA
        Last Closed|                            |2017-04-01 13:00:28

--- Comment #13 from Fedora Update System  ---
php-phpunit-mock-objects4-4.0.1-2.fc26 has been pushed to the Fedora 26 stable
repository. If problems still persist, please make note of it in this bug
report.