https://bugzilla.redhat.com/show_bug.cgi?id=1310355
Bug ID: 1310355 Summary: Review Request: spirv-headers - Khronos SPIR-V development headers Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: i.gnatenko.brain@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/spirv-headers.spec SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/spirv-headers-1.0-1.fc24.... Description: Khronos SPIR-V development headers Fedora Account System Username: ignatenkobrain
https://bugzilla.redhat.com/show_bug.cgi?id=1310355
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |zbyszek@in.waw.pl Assignee|nobody@fedoraproject.org |zbyszek@in.waw.pl
--- Comment #1 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- spirv-headers.src: W: no-%build-section Better to add an empty one.
About the name: upstream project is SPIR-V, the URL contains "spir-v" too. Shouldn't the name of the package be spir-v-headers?
I think you should also include https://www.khronos.org/registry/spir-v/api/spir-v.xml. Unfortunately the docs are non-redistributable. It would be nice to include them otherwise.
https://bugzilla.redhat.com/show_bug.cgi?id=1310355
Igor Gnatenko i.gnatenko.brain@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |WONTFIX Last Closed| |2018-08-22 03:31:24
--- Comment #2 from Igor Gnatenko i.gnatenko.brain@gmail.com --- Unfortunately I don't have time to work on these review requests anymore, sorry.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com -
Red Hat Bugzilla