Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=397031
Summary: Review Request: php-pear-HTTP-Upload - Secure managment of files submitted via HTML Forms Product: Fedora Version: devel Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: chris.stone@gmail.com QAContact: extras-qa@fedoraproject.org CC: fedora-package-review@redhat.com,notting@redhat.com
Spec URL: http://tkmame.retrogames.com/fedora-extras/php-pear-HTTP-Upload.spec SRPM URL: http://tkmame.retrogames.com/fedora-extras/php-pear-HTTP-Upload-0.9.1-1.fc7....
Description:
This class provides an advanced file uploader system for file uploads made from html forms. Features: * Can handle from one file to multiple files. * Safe file copying from tmp dir. * Easy detecting mechanism of valid upload, missing upload or error. * Gives extensive information about the uploaded file. * Rename uploaded files in different ways: as it is, safe or unique * Validate allowed file extensions * Multiple languages error messages support (es, en, de, fr, it, nl, pt_BR)
%changelog * Fri Nov 23 2007 Christopher Stone chris.stone@gmail.com 0.9.1-1 - Initial Fedora release
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-pear-HTTP-Upload - Secure managment of files submitted via HTML Forms Alias: pear-HTTP-Upload
https://bugzilla.redhat.com/show_bug.cgi?id=397031
chris.stone@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Alias| |pear-HTTP-Upload
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-pear-HTTP-Upload - Secure managment of files submitted via HTML Forms Alias: pear-HTTP-Upload
https://bugzilla.redhat.com/show_bug.cgi?id=397031
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Version|devel |rawhide
fedora@famillecollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |fedora@famillecollet.com Status|NEW |ASSIGNED Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-pear-HTTP-Upload - Secure managment of files submitted via HTML Forms Alias: pear-HTTP-Upload
https://bugzilla.redhat.com/show_bug.cgi?id=397031
------- Additional Comments From fedora@famillecollet.com 2007-12-22 04:14 EST ------- arg, the sample doesn't work...
I think it would be cool to patch it : Line 14 : if (!isset($_GET["submit"])) {
It's not a issue for the review.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-pear-HTTP-Upload - Secure managment of files submitted via HTML Forms Alias: pear-HTTP-Upload
https://bugzilla.redhat.com/show_bug.cgi?id=397031
fedora@famillecollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
------- Additional Comments From fedora@famillecollet.com 2007-12-22 04:22 EST ------- REVIEW:
* rpmlint : OK * The package is named according to the Package Naming Guidelines. * The spec file name match the base package * The package follow the PHP Packaging Guidelines * Fedora approved license (LGPL) * License field in the package spec file match the actual license * The spec file is written in American English * The spec file is legible * The sources used to build the package must match the upstream source fd1161202786fcba5272d2715bcda787 HTTP_Upload-0.9.1.tgz * build in mock (F-7, noarch) * All build dependencies are listed in BuildRequires * no locales * no shared library files * package own all directories that it creates * Package don't own files or directories already owned by other packages (HTTP owned by php-pear-HTTP-Request, but no dependencies, so it's ok) * no duplicate files * Permissions on files are set properly * %clean section * package consistently use macros * The package contain code * small documentation * no library * no desktop file * %install, start with rm -rf %{buildroot} * All filenames are valid UTF-8 * scriptlets are sane* * Final Provides ok php-pear(HTTP_Upload) = 0.9.1 php-pear-HTTP-Upload = 0.9.1-1.fc8 * Final Requires see below /usr/bin/pear php-pear(PEAR)
Should : see previous comment
APPROVED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-pear-HTTP-Upload - Secure managment of files submitted via HTML Forms Alias: pear-HTTP-Upload
https://bugzilla.redhat.com/show_bug.cgi?id=397031
------- Additional Comments From chris.stone@gmail.com 2008-02-07 18:46 EST ------- New Package CVS Request ======================= Package Name: php-pear-HTTP-Upload Short Description: Secure managment of files submitted via HTML Forms Owners: xulchris Branches: F-7 F-8 InitialCC: Cvsextras Commits: yes
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-pear-HTTP-Upload - Secure managment of files submitted via HTML Forms Alias: pear-HTTP-Upload
https://bugzilla.redhat.com/show_bug.cgi?id=397031
chris.stone@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-pear-HTTP-Upload - Secure managment of files submitted via HTML Forms Alias: pear-HTTP-Upload
https://bugzilla.redhat.com/show_bug.cgi?id=397031
petersen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
------- Additional Comments From petersen@redhat.com 2008-02-08 01:12 EST ------- cvs admin done
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-pear-HTTP-Upload - Secure managment of files submitted via HTML Forms Alias: pear-HTTP-Upload
https://bugzilla.redhat.com/show_bug.cgi?id=397031
------- Additional Comments From petersen@redhat.com 2008-02-08 01:28 EST ------- Added EL-5 too per request of xulchris.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-pear-HTTP-Upload - Secure managment of files submitted via HTML Forms Alias: pear-HTTP-Upload
https://bugzilla.redhat.com/show_bug.cgi?id=397031
------- Additional Comments From updates@fedoraproject.org 2008-02-08 16:18 EST ------- php-pear-HTTP-Upload-0.9.1-2.fc8 has been submitted as an update for Fedora 8
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-pear-HTTP-Upload - Secure managment of files submitted via HTML Forms Alias: pear-HTTP-Upload
https://bugzilla.redhat.com/show_bug.cgi?id=397031
chris.stone@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs+ |fedora-cvs?
------- Additional Comments From chris.stone@gmail.com 2008-02-08 16:30 EST ------- Package Change Request ====================== Package Name: php-pear-HTTP-Upload New Branches: EL-5
Jens said he added an EL-5 branch, and I got an e-mail from packagedb to that regard, but when I try to do a cvs up -d command, the EL-5 branch is not showing up.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-pear-HTTP-Upload - Secure managment of files submitted via HTML Forms Alias: pear-HTTP-Upload
https://bugzilla.redhat.com/show_bug.cgi?id=397031
kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |kevin@tummy.com Flag|fedora-cvs? |fedora-cvs+
------- Additional Comments From kevin@tummy.com 2008-02-09 14:46 EST ------- Should be fixed now. Can you check and confirm?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-pear-HTTP-Upload - Secure managment of files submitted via HTML Forms Alias: pear-HTTP-Upload
https://bugzilla.redhat.com/show_bug.cgi?id=397031
------- Additional Comments From chris.stone@gmail.com 2008-02-09 15:54 EST ------- Yep, fixed now, thx :)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-pear-HTTP-Upload - Secure managment of files submitted via HTML Forms Alias: pear-HTTP-Upload
https://bugzilla.redhat.com/show_bug.cgi?id=397031
------- Additional Comments From updates@fedoraproject.org 2008-02-12 23:56 EST ------- php-pear-HTTP-Upload-0.9.1-2.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-pear-HTTP-Upload - Secure managment of files submitted via HTML Forms Alias: pear-HTTP-Upload
https://bugzilla.redhat.com/show_bug.cgi?id=397031
updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |CURRENTRELEASE Fixed In Version| |0.9.1-2.fc8
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-pear-HTTP-Upload - Secure managment of files submitted via HTML Forms Alias: pear-HTTP-Upload
https://bugzilla.redhat.com/show_bug.cgi?id=397031
------- Additional Comments From chris.stone@gmail.com 2008-02-13 16:22 EST ------- Built successfully on all branches, thanks for the review! :D
package-review@lists.fedoraproject.org