[Bug 1654670] Review Request: perl-Crypt-U2F-Server - Low level wrapper around the U2F C library (server side)

https://bugzilla.redhat.com/show_bug.cgi?id=1654670

--- Comment #9 from Petr Pisar  ---
URL and Source0 addresses are usable. Ok.
TODO: Remove a trailing space from URL value.

Source0 archive (SHA-512:
d27f23bb44ab69ffbab1e1a6d3adea54af83a19d9c45d304dcdfa119e98fb2350e125594aaebe7c9184703c0d10f3f66c384d8df85bab6d5077fe635c8c063e7)
is original. Ok.
Summary verified from lib/Crypt/U2F/Server.pm. Ok.

TODO: The description is quite crude. Could you rephrase it like this:

This is a very low level wrapper around libu2f-server C library. You
  might rather use a high-level Crypt::U2F::Server::Simple instead.

FIX: The license tag does not cover all licenses. It also must be in an SPDX
format.
Licenses found:
lib/Crypt/U2F/Server.pm: BSD-2-Clause
lib/Crypt/U2F/Server/Simple.pm: BSD-2-Clause
u2f.c: BSD-2-Clause
u2f.h: BSD-2-Clause
ppport.h: GPL-1.0-or-later OR Artistic-1.0-Perl
README: GPL-1.0-or-later OR Artistic-1.0-Perl
I believe the correct license tag is: BSD-2-Clause AND (GPL-1.0-or-later OR
Artistic-1.0-Perl)

TODO: Build-require 'perl(:VERSION) >= 5.18.1' (Makefile.PL:1).
FIX: Build-require perl(ExtUtils::Constant) (Makefile.PL:30). The branch with
File::Copy cannot work because there is no "fallback" directory in the sources.
FIX: Do not build- and run-require 'perl(DynaLoader)'. It's used nowhere.
FIX: Build-require 'perl(constant)' (t/12-full-test.t:8).
FIX: Build-require 'perl(Data::Dumper)' (t/01-lowlevel-basic.t:17).
FIX: Do not run-require 'perl(:MODULE_COMPAT_...)'. It's handled by
perl-generators now.

TODO: Add NO_PACKLIST=1 NO_PERLLOCAL=1 arguments to Makefile.PL and use
%{make_install} as recommended in
https://fedoraproject.org/wiki/Perl/Tips#ExtUtils::MakeMaker. You will then
be able to remove all the find commands except of "find $RPM_BUILD_ROOT -type f
-name '*.bs' -size 0 -exec rm -f {} ;" which could be simplified to "find
$RPM_BUILD_ROOT -type f -name '*.bs' -size 0 -delete" and you have to
build-require "findutils" for that.

FIX: Build-require 'coreutils' (perl-Crypt-U2F-Server.spec:45).
FIX: Build-require 'make' (perl-Crypt-U2F-Server.spec:48).

TODO: Do not package META.json. It does not contain any unique data which
cannot be found elsewhere.
FIX: Do not use top-level globs in %files section, especially at the manual
pages
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_explicit_lists.

FIX: The package does not build because 'perl(Authen::U2F::Tester)'
build-dependency is not packaged in Fedora. Either package it first, or remove
the dependency. It's an optional test.