Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225294
Summary: Merge Review: authd Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: nobody@fedoraproject.org QAContact: fedora-package-review@redhat.com CC: stransky@redhat.com
Fedora Merge Review: authd
http://cvs.fedora.redhat.com/viewcvs/devel/authd/
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: authd
https://bugzilla.redhat.com/show_bug.cgi?id=225294
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora Version|devel |rawhide
limb@jcomserv.net changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |limb@jcomserv.net Status|NEW |ASSIGNED Flag| |fedora-review?
------- Additional Comments From limb@jcomserv.net 2008-02-05 15:12 EST ------- rpmlint on srpm:
authd.src:7: W: unversioned-explicit-obsoletes pidentd The specfile contains an unversioned Obsoletes: token, which will match all older, equal and newer versions of the obsoleted thing. This may cause update problems, restrict future package/provides naming, and may match something it was originally not inteded to match -- make the Obsoletes versioned if possible.
authd.src:18: W: prereq-use xinetd The use of PreReq is deprecated. In the majority of cases, a plain Requires is enough and the right thing to do. Sometimes Requires(pre), Requires(post), Requires(preun) and/or Requires(postun) can also be used instead of PreReq.
authd.src: W: no-url-tag The URL tag is missing.
These need fixing.
rpmlint on rpms:
authd.i386: E: non-readable /etc/ident.key 0640 The file can't be read by everybody. If this is expected (for security reasons), contact your rpmlint distributor to get it added to the list of exceptions for your distro (or add it to your local configuration if you installed rpmlint from the source tarball).
authd.i386: E: zero-length /etc/ident.key
authd.i386: W: conffile-without-noreplace-flag /etc/ident.key A configuration file is stored in your package without the noreplace flag. A way to resolve this is to put the following in your SPEC file:
%config(noreplace) /etc/your_config_file_here
These are OK.
authd.i386: W: dangerous-command-in-%post chown
Fix if possible, might want to use the full path to chown.
In addition to needing a URL tag, the Source tag needs a url pointing to the upstream tarball. If Fedora or RH are upstream, get a space on hosted.
License tag should be GPLv2+.
Error in rawhide mock build:
Executing(%build): /bin/sh -e /var/tmp/rpm-tmp.30946 + umask 022 + cd /builddir/build/BUILD + cd authd-1.4.3 + LANG=C + export LANG + unset DISPLAY + make prefix=/usr gcc -std=gnu99 -Wall -W -DNDEBUG -g -O -lcrypto -o in.authd authd.c authd.c: In function 'created_pton_hex': authd.c:198: error: 'struct in6_addr' has no member named 'in6_u' authd.c:202: error: 'struct in6_addr' has no member named 'in6_u' authd.c: In function 'initialize_crypto': authd.c:784: warning: pointer targets in passing argument 4 of 'EVP_BytesToKey' differ in signedness make: *** [in.authd] Error 1 error: Bad exit status from /var/tmp/rpm-tmp.30946 (%build)
RPM build errors: Bad exit status from /var/tmp/rpm-tmp.30946 (%build) EXCEPTION: Command failed. See logs for output. # bash -l -c 'rpmbuild -bb --target i386 --nodeps //builddir/build/SPECS/authd.spec' Traceback (most recent call last): File "/usr/lib/python2.5/site-packages/mock/trace_decorator.py", line 70, in trace result = func(*args, **kw) File "/usr/lib/python2.5/site-packages/mock/util.py", line 286, in do raise mock.exception.Error, ("Command failed. See logs for output.\n # %s" % (command,), ret) Error: Command failed. See logs for output. # bash -l -c 'rpmbuild -bb --target i386 --nodeps //builddir/build/SPECS/authd.spec' LEAVE do --> EXCEPTION RAISED
Other than that, looks good, no other blockers.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: authd
https://bugzilla.redhat.com/show_bug.cgi?id=225294
limb@jcomserv.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jsafrane@redhat.com
------- Additional Comments From limb@jcomserv.net 2008-02-06 07:32 EST ------- Adding authd maintainer listed in pkgdb to cc.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: authd
https://bugzilla.redhat.com/show_bug.cgi?id=225294
------- Additional Comments From jsafrane@redhat.com 2008-02-13 05:02 EST ------- (In reply to comment #1)
rpmlint on srpm:
authd.src:7: W: unversioned-explicit-obsoletes pidentd
Fixed
authd.src:18: W: prereq-use xinetd
Fixed
authd.src: W: no-url-tag
See below
authd.i386: E: non-readable /etc/ident.key 0640
That's an intention, it's secret password.
authd.i386: E: zero-length /etc/ident.key
That's an intention, it's zero-length secret password.
authd.i386: W: conffile-without-noreplace-flag /etc/ident.key
That's an intention, do not overwrite the password.
These are OK.
authd.i386: W: dangerous-command-in-%post chown Fix if possible, might want to use the full path to chown.
Chown is needed, and there *is* full path to /bin/chown.
In addition to needing a URL tag, the Source tag needs a url pointing to the upstream tarball. If Fedora or RH are upstream, get a space on hosted.
I did not find any upstream of authd, did I miss something? If there is not any, I'll go to fedorahosted.org
License tag should be GPLv2+.
Fixed
Error in rawhide mock build:
Fixed
Other than that, looks good, no other blockers.
Thanks for the review!
After the fixes (authd-1.4.3-14.rpm), rpmlint complains about: authd.i386: E: non-readable /etc/ident.key 0640 authd.i386: E: zero-length /etc/ident.key authd.i386: W: no-url-tag authd.i386: W: conffile-without-noreplace-flag /etc/ident.key authd.i386: W: dangerous-command-in-%post chown authd.src: W: no-url-tag authd-debuginfo.i386: W: no-url-tag
All these errors except url are described above.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: authd
https://bugzilla.redhat.com/show_bug.cgi?id=225294
------- Additional Comments From limb@jcomserv.net 2008-02-13 08:23 EST ------- You're welcome!
authd.i386: W: dangerous-command-in-%post chown Fix if possible, might want to use the full path to chown.
Chown is needed, and there *is* full path to /bin/chown.
Sorry, I meant full path to chmod, line 59.
Otherwise, yes, I'd get a spot on hosted and update with the results.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: authd
https://bugzilla.redhat.com/show_bug.cgi?id=225294
jsafrane@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |rrakus@redhat.com
------- Additional Comments From jsafrane@redhat.com 2008-02-27 08:43 EST ------- authd got a new maintaner: rrakus@redhat.com.
Roman, please try to find upstream and if it does not exist, please create your own on fedorahosted.org. You can ask maintainers of other distributions to cooperate and unify your patches. Or kick authd out of Fedora, if nobody uses it :)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: authd
https://bugzilla.redhat.com/show_bug.cgi?id=225294
rrakus@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |RAWHIDE
------- Additional Comments From rrakus@redhat.com 2008-03-05 10:25 EST ------- Upstream not exists. Created on fedorahosted.org: https://fedorahosted.org/authd/ Also added dist tag.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: authd
https://bugzilla.redhat.com/show_bug.cgi?id=225294
limb@jcomserv.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |ASSIGNED Keywords| |Reopened Resolution|RAWHIDE |
------- Additional Comments From limb@jcomserv.net 2008-03-05 10:34 EST ------- Sorry, can't close until approved.
Looks goos, but Source0 needs to include URL to tarball, i.e. https://fedorahosted.org/authd/attachment/wiki/WikiStart/authd-1.4.3.tar.gz
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: authd
https://bugzilla.redhat.com/show_bug.cgi?id=225294
------- Additional Comments From rrakus@redhat.com 2008-03-06 04:20 EST ------- I'm sorry for my mistake. Source0 fixed. Looks like to be good now. Can you please check it once again? Thank you.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: authd
https://bugzilla.redhat.com/show_bug.cgi?id=225294
------- Additional Comments From limb@jcomserv.net 2008-03-06 07:31 EST ------- Looks perfectly cromulent now. Oddly, the md5sums between the Source0: tarball and the one from the koji SRPM don't match. gunzip fails and file says it's html.
Looks like https://fedorahosted.org/authd/attachment/wiki/WikiStart/authd-1.4.3.tar.gz?... will work, but will add the ?format=raw to the end of the filename.
THEN the md5sum matches. So it looks like the tag needs changing one more time, with a note about the filename in the spec.
Sorry. :)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: authd
https://bugzilla.redhat.com/show_bug.cgi?id=225294
------- Additional Comments From rrakus@redhat.com 2008-03-06 10:00 EST ------- Done some changes. Sources uploaded to svn - http://svn.fedorahosted.org/svn/authd/ Changed homepage - https://fedorahosted.org/authd/ Changed spec file Source0. Now it must be perfect! :)
Can you take a look at it, please? :)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: authd
https://bugzilla.redhat.com/show_bug.cgi?id=225294
limb@jcomserv.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |RAWHIDE Flag|fedora-review? |fedora-review+
------- Additional Comments From limb@jcomserv.net 2008-03-06 10:47 EST ------- Beauteous. :) Thank you!
APPROVED.
package-review@lists.fedoraproject.org