Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: rubygem-showoff - Ruby web app that reads simple configuration files for a presentation
https://bugzilla.redhat.com/show_bug.cgi?id=771318
Summary: Review Request: rubygem-showoff - Ruby web app that reads simple configuration files for a presentation Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: mfojtik@redhat.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: ---
Spec URL: http://omicron.mifo.sk/rubygem-showoff.spec SRPM URL: http://omicron.mifo.sk/rubygem-rubygem-showoff-0.7.0-2.fc14.src.rpm
Description:
ShowOff is a Sinatra web app that reads simple configuration files for a presentation. It is sort of like a Keynote web app engine - think S5 + Slidedown.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=771318
Michal Fojtik mfojtik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends on| |771314, 771311, 771297
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=771318
--- Comment #1 from Michal Fojtik mfojtik@redhat.com 2012-01-03 06:36:26 EST --- Sorry for wrong links (again ;-)
Spec URL: http://omicron.mifo.sk/rubygem-showoff.spec SRPM URL: http://omicron.mifo.sk/rubygem-showoff-0.7.0-2.fc14.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=771318
--- Comment #2 from Michal Fojtik mfojtik@redhat.com 2012-01-03 08:31:00 EST --- Revision -3:
Spec URL: http://omicron.mifo.sk/rubygem-showoff.spec SRPM URL: http://omicron.mifo.sk/rubygem-showoff-0.7.0-3.fc14.src.rpm
* Mon Jan 03 2012 Michal Fojtik mfojtik@redhat.com - 0.7.0-3
- Removed rspec dependency - Fixed licenses for some javascript files - Added RMagick dependency for handling image resizing
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=771318
Michal Fojtik mfojtik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: |Review Request: showoff - |rubygem-showoff - Ruby web |Ruby web app that reads |app that reads simple |simple configuration files |configuration files for a |for a presentation |presentation |
--- Comment #3 from Michal Fojtik mfojtik@redhat.com 2012-01-03 08:46:44 EST --- Revision -4:
Spec URL: http://omicron.mifo.sk/showoff.spec SRPM URL: http://omicron.mifo.sk/showoff-0.7.0-4.fc14.src.rpm
* Mon Jan 03 2012 Michal Fojtik mfojtik@redhat.com - 0.7.0-4
- Switched to application package type instead of gem
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=771318
--- Comment #4 from Michal Fojtik mfojtik@redhat.com 2012-01-03 09:10:21 EST --- Revision -5:
Spec URL: http://omicron.mifo.sk/showoff.spec SRPM URL: http://omicron.mifo.sk/showoff-0.7.0-5.fc14.src.rpm
* Mon Jan 03 2012 Michal Fojtik mfojtik@redhat.com - 0.7.0-5 - Changed package group to Applications/Publishing
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=771318
Lubomir Rintel lkundrak@v3.sk changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |lkundrak@v3.sk
--- Comment #5 from Lubomir Rintel lkundrak@v3.sk 2012-01-08 17:48:36 EST --- * Name alright * Versioning correct * Source file matches upstream * SPEC file clean and legible * Builds fine in mock
1.) Require list not correct
Requires: ruby(abi) = 1.8
Please drop this -- you don't install modules into 1.8 release specific location and thus don't need to require a particular ABI.
2.) Licensing is suspicious
You need to clarify this: # Unknown license (same as JQuery?) %{app_root}/public/js/jquery.batchImageLoad.js %{app_root}/public/js/jquery.uuid.js
3.) Rpmlint not happy
showoff.src:60: E: files-attr-not-set A file or a directory entry in a %files section does not have attributes set which may result in security issues in the resulting binary package depending on the system where the package is built. Add default attributes using %defattr before it in the %files section, or use per line %attr's.
showoff.src: W: no-%clean-section The spec file doesn't contain a %clean section to remove the files installed by the %install section.
showoff.src:11: W: mixed-use-of-spaces-and-tabs (spaces: line 3, tab: line 11) The specfile mixes use of spaces and tabs for indentation, which is a cosmetic annoyance. Use either spaces or tabs for indentation, not both.
https://bugzilla.redhat.com/show_bug.cgi?id=771318 Bug 771318 depends on bug 771311, which changed state.
Bug 771311 Summary: Review Request: rubygem-gli - Git-Like Interface Command Line Parser for Ruby https://bugzilla.redhat.com/show_bug.cgi?id=771311
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |NOTABUG
https://bugzilla.redhat.com/show_bug.cgi?id=771318
James Hogarth james.hogarth@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On|771314 |
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=771314 [Bug 771314] Review Request: rubygem-parslet - Parser construction library with great error reporting in Ruby
https://bugzilla.redhat.com/show_bug.cgi?id=771318 Bug 771318 depends on bug 771297, which changed state.
Bug 771297 Summary: Review Request: rubygem-bluecloth - A Ruby implementation of John Gruber's Markdown https://bugzilla.redhat.com/show_bug.cgi?id=771297
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |NOTABUG
package-review@lists.fedoraproject.org