[Bug 475055] New: Review Request: gfan - Software for Computing Gröbner Fans and Tropical Varieties

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: gfan - Software for Computing Gröbner Fans and Tropical Varieties

https://bugzilla.redhat.com/show_bug.cgi?id=475055

Summary: Review Request: gfan - Software for Computing Gröbner
                    Fans and Tropical Varieties
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
   Estimated Hours: 0.0
    Classification: Fedora

Spec URL: http://konradm.fedorapeople.org/fedora/SPECS/gfan.spec
SRPM URL: http://konradm.fedorapeople.org/fedora/SRPMS/gfan-0.3-1.fc9.src.rpm
Description:
The software computes all marked reduced Gröbner bases of an ideal.
Their union is a universal Gröbner basis. Gfan contains algorithms for
computing this complex for general ideals and specialized algorithms
for tropical curves, tropical hypersurfaces and tropical varieties of
prime ideals. In addition to the above core functions the package
contains many tools which are useful in the study of Gröbner bases,
initial ideals and tropical geometry. Among these are an interactive
traversal program for Gröbner fans and programs for graphical renderings.

[Bug 475055] Review Request: gfan - Software for Computing Gröbner Fans and Tropical Varieties

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=475055

--- Comment #1 from Rex Dieter   2008-12-11 14:55:45 EDT ---
Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=993871

[Bug 475055] Review Request: gfan - Software for Computing Gröbner Fans and Tropical Varieties

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=475055

--- Comment #2 from Conrad Meyer   2008-12-12 04:54:59 EDT ---
New URLs:

http://konradm.fedorapeople.org/fedora/SPECS/gfan.spec
http://konradm.fedorapeople.org/fedora/SRPMS/gfan-0.3-2.fc9.src.rpm

Scratch build:

http://koji.fedoraproject.org/koji/taskinfo?taskID=994565

[Bug 475055] Review Request: gfan - Software for Computing Gröbner Fans and Tropical Varieties

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=475055

Mamoru Tasaka  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|[e-mail]    |[e-mail]
               Flag|                            |fedora-review?

--- Comment #3 from Mamoru Tasaka   2008-12-26 12:16:13 EDT ---
Some notes:

* License
  - The license tag should be "GPL+" as no version is specified
  - However LICENSE (and also README) file also says that files 
    under doc/ are non-free.
    Please follow

https://fedoraproject.org/wiki/Packaging/SourceURL#When_Upstream_uses_Prohib...
    and remove all files under doc/ from the source tarball
    completely.
  - Include LICENSE file as %doc as this is important.

* CFLAGS
  - I guess
-------------------------------------------------------------
export CFLAGS="%{optflags}"
export CXXFLAGS="%{optflags}"
-------------------------------------------------------------
    is not needed.

[Bug 475055] Review Request: gfan - Software for Computing Gröbner Fans and Tropical Varieties

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=475055

--- Comment #4 from Conrad Meyer   2008-12-30 21:38:22 EDT ---
Fixed; see:

http://konradm.fedorapeople.org/fedora/SPECS/gfan.spec
http://konradm.fedorapeople.org/fedora/SRPMS/gfan-0.3-3.fc9.src.rpm

Sorry for the delay.

However, LICENSE only says this:
"""
The manual for Gfan is NOT distributed under the GNU GENERAL PUBLIC LICENSE.
The manual may be freely redistributed but is not allowed to be changed.
The manual may be removed from the software package.
"""

Does that violate Fedora guidelines? I don't think so. (But I have removed doc/
from the srpm as per your advice anyways.)

[Bug 475055] Review Request: gfan - Software for Computing Gröbner Fans and Tropical Varieties

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=475055

--- Comment #5 from Mamoru Tasaka   2009-01-01 10:31:18 EDT ---
Okay.

----------------------------------------------------------
   This package (gfan) is APPROVED by mtasaka
----------------------------------------------------------

(In reply to comment #4)
> However, LICENSE only says this:
> """
> The manual for Gfan is NOT distributed under the GNU GENERAL PUBLIC LICENSE.
> The manual may be freely redistributed but is not allowed to be changed.
> The manual may be removed from the software package.
> """
>
> Does that violate Fedora guidelines? I don't think so.

"The manual is not allowed to be changed" is definitely non-free,
so this part cannot be in Fedora:
https://fedoraproject.org/wiki/Licensing/FAQ

[Bug 475055] Review Request: gfan - Software for Computing Gröbner Fans and Tropical Varieties

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=475055

--- Comment #6 from Conrad Meyer   2009-01-01 16:07:07 EDT ---
(In reply to comment #5)
> (In reply to comment #4)
> > However, LICENSE only says this:
> > """
> > The manual for Gfan is NOT distributed under the GNU GENERAL PUBLIC LICENSE.
> > The manual may be freely redistributed but is not allowed to be changed.
> > The manual may be removed from the software package.
> > """
> >
> > Does that violate Fedora guidelines? I don't think so.
>
> "The manual is not allowed to be changed" is definitely non-free,
> so this part cannot be in Fedora:
> https://fedoraproject.org/wiki/Licensing/FAQ

"""
  Does Fedora permit anything under "Non-Free" licensing?

When it comes to software or fonts, the answer is definitely no. We strongly
prefer that items classified as content (see Code Vs Content) are under a Free
license, but we only require that they be freely distributable without
restrictions.
"""

I think a manual is content as opposed to code and therefore freely
distributable is ok.

[Bug 475055] Review Request: gfan - Software for Computing Gröbner Fans and Tropical Varieties

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=475055

Conrad Meyer  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |182235

[Bug 475055] Review Request: gfan - Software for Computing Gröbner Fans and Tropical Varieties

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=475055

Tom "spot" Callaway  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #7 from Tom "spot" Callaway   2009-01-12 17:47:53 EDT ---
(In reply to comment #6)
> I think a manual is content as opposed to code and therefore freely
> distributable is ok.

I hate this loophole. I really really really do. Can you ask upstream if we can
have permission to make derived works of the manual?

[Bug 475055] Review Request: gfan - Software for Computing Gröbner Fans and Tropical Varieties

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=475055

--- Comment #8 from Conrad Meyer   2009-01-12 18:36:36 EDT ---
(For those too lazy to read above: the current state of the package is that we
are *not* shipping the manual.)

I will ask upstream to put something in their LICENSE about allowing derived
works for the manual. If they insist upon not allowing derived works, I take it
you (spot) would prefer we not ship the manual?

[Bug 475055] Review Request: gfan - Software for Computing Gröbner Fans and Tropical Varieties

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=475055

--- Comment #9 from Conrad Meyer   2009-01-12 18:37:49 EDT ---
Oh, and because it is freely redistributable, is it ok to *not* cull this from
the upstream tarball at each release (just remove it in %prep)?

[Bug 475055] Review Request: gfan - Software for Computing Gröbner Fans and Tropical Varieties

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=475055

--- Comment #10 from Conrad Meyer   2009-01-12 18:46:23 EDT ---
Created an attachment (id=328805)
 --> (https://bugzilla.redhat.com/attachment.cgi?id=328805)
Email Body

This is the body of the email query I sent to Gfan's author.

[Bug 475055] Review Request: gfan - Software for Computing Gröbner Fans and Tropical Varieties

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=475055

--- Comment #11 from Tom "spot" Callaway   2009-01-13 10:26:41 EDT ---
(In reply to comment #9)
> Oh, and because it is freely redistributable, is it ok to *not* cull this from
> the upstream tarball at each release (just remove it in %prep)?

Yes. There is no need to hack up the upstream tarball to remove this.

I'd really prefer we didn't ship the manual. I'm thinking seriously about
closing this loophole with FESCo.

[Bug 475055] Review Request: gfan - Software for Computing Gröbner Fans and Tropical Varieties

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=475055

Conrad Meyer  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

--- Comment #12 from Conrad Meyer   2009-01-13 12:47:33 EDT ---
New Package CVS Request
=======================
Package Name: gfan
Short Description: Software for Computing Gröbner Fans and Tropical Varieties
Owners: konradm
Branches: F-10 F-9
InitialCC:

[Bug 475055] Review Request: gfan - Software for Computing Gröbner Fans and Tropical Varieties

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=475055

Conrad Meyer  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |

--- Comment #13 from Conrad Meyer   2009-01-13 12:50:34 EDT ---
Oh, just kidding -- I didn't notice you changed the review flag back to '?'.

[Bug 475055] Review Request: gfan - Software for Computing Gröbner Fans and Tropical Varieties

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=475055

Mamoru Tasaka  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #14 from Mamoru Tasaka   2009-01-14 10:11:36 EDT ---
Okay, I re-approve this package.

[Bug 475055] Review Request: gfan - Software for Computing Gröbner Fans and Tropical Varieties

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=475055

Conrad Meyer  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

--- Comment #15 from Conrad Meyer   2009-01-14 11:36:22 EDT ---
Thanks!

[Bug 475055] Review Request: gfan - Software for Computing Gröbner Fans and Tropical Varieties

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=475055

--- Comment #16 from Kevin Fenzi   2009-01-14 16:19:08 EDT ---
This is still blocking FE_LEGAL. 
Spot: should this be oked now? Or is it waiting pending something further?

[Bug 475055] Review Request: gfan - Software for Computing Gröbner Fans and Tropical Varieties

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=475055

--- Comment #17 from Tom "spot" Callaway   2009-01-14 16:27:03 EDT ---
(In reply to comment #16)
> This is still blocking FE_LEGAL. 
> Spot: should this be oked now? Or is it waiting pending something further?

Conrad, did you remove the manual from the package (not the tarball)?

[Bug 475055] Review Request: gfan - Software for Computing Gröbner Fans and Tropical Varieties

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=475055

--- Comment #18 from Conrad Meyer   2009-01-14 18:38:32 EDT ---
(In reply to comment #17)
> (In reply to comment #16)
> > This is still blocking FE_LEGAL. 
> > Spot: should this be oked now? Or is it waiting pending something further?
>
> Conrad, did you remove the manual from the package (not the tarball)?

Yup. (Went back to using the original (not-stripped) tarball though.)

[Bug 475055] Review Request: gfan - Software for Computing Gröbner Fans and Tropical Varieties

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=475055

Tom "spot" Callaway  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|182235                      |

--- Comment #19 from Tom "spot" Callaway   2009-01-15 11:00:49 EDT ---
(In reply to comment #18)
> (In reply to comment #17)
> > (In reply to comment #16)
> > > This is still blocking FE_LEGAL. 
> > > Spot: should this be oked now? Or is it waiting pending something further?
> >
> > Conrad, did you remove the manual from the package (not the tarball)?
>
> Yup. (Went back to using the original (not-stripped) tarball though.)

Lifting FE-Legal then. :)

[Bug 475055] Review Request: gfan - Software for Computing Gröbner Fans and Tropical Varieties

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=475055

Kevin Fenzi  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

--- Comment #20 from Kevin Fenzi   2009-01-15 15:25:24 EDT ---
cvs done.

[Bug 475055] Review Request: gfan - Software for Computing Gröbner Fans and Tropical Varieties

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=475055

--- Comment #21 from Mamoru Tasaka   2009-01-17 08:31:40 EDT ---
Please submit push request also for F-9 on bodhi.

[Bug 475055] Review Request: gfan - Software for Computing Gröbner Fans and Tropical Varieties

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=475055

--- Comment #22 from Conrad Meyer   2009-01-17 19:10:58 EDT ---
(In reply to comment #21)
> Please submit push request also for F-9 on bodhi.

When I tried to submit updates on bodhi I kept getting 500 server errors. I'll
try again.

[Bug 475055] Review Request: gfan - Software for Computing Gröbner Fans and Tropical Varieties

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=475055

--- Comment #23 from Conrad Meyer   2009-01-17 19:15:58 EDT ---
Ok, bodhi thinks that "gfan-0.3-3.fc9 update already exists!" But it doesn't
show up in the list nor do searches show anything.

[Bug 475055] Review Request: gfan - Software for Computing Gröbner Fans and Tropical Varieties

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=475055

Mamoru Tasaka  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #24 from Mamoru Tasaka   2009-01-18 09:19:49 EDT ---
(In reply to comment #23)
> Ok, bodhi thinks that "gfan-0.3-3.fc9 update already exists!" But it doesn't
> show up in the list nor do searches show anything.

I see this issue (I tried to submit gfan 0.3-3.fc9 updates
request and got the same error).

CCing to Toshio. Would you examine what is happening?

[Bug 475055] Review Request: gfan - Software for Computing Gröbner Fans and Tropical Varieties

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=475055

Luke Macken  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #25 from Luke Macken   2009-01-19 12:40:11 EDT ---
The bodhi issue should be fixed.  There was a stray PackageBuild lying around,
without the corresponding PackageUpdate.  You should be able to re-submit it
without problems.

[Bug 475055] Review Request: gfan - Software for Computing Gröbner Fans and Tropical Varieties

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=475055

--- Comment #26 from Conrad Meyer   2009-01-19 14:35:59 EDT ---
Thanks.

[Bug 475055] Review Request: gfan - Software for Computing Gröbner Fans and Tropical Varieties

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=475055

Mamoru Tasaka  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE

--- Comment #27 from Mamoru Tasaka   2009-01-20 12:02:30 EDT ---
Okay, now this review request is closed.

[Bug 475055] Review Request: gfan - Software for Computing Gröbner Fans and Tropical Varieties

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=475055

Mark Chappell  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
               Flag|fedora-cvs+                 |fedora-cvs?

--- Comment #28 from Mark Chappell  2010-03-17 04:08:02 EDT ---
Package Change Request
======================
Package Name: gfan
New Branches: EL-5
Owners: tremble

Fedora owner not interested in EL:
https://bugzilla.redhat.com/show_bug.cgi?id=574081

[Bug 475055] Review Request: gfan - Software for Computing Gröbner Fans and Tropical Varieties

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=475055

Kevin Fenzi  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

--- Comment #29 from Kevin Fenzi  2010-03-17 14:03:26 EDT ---
cvs done.