Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: libqt4intf - Wrapper library for Qt4
https://bugzilla.redhat.com/show_bug.cgi?id=542458
Summary: Review Request: libqt4intf - Wrapper library for Qt4 Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: matthias@nlinux.org QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://listaller.nlinux.org/factory/rpmbuild/libqtintf4.spec SRPM URL: http://listaller.nlinux.org/factory/rpmbuild/libqt4intf5-1.72_Qt4.5.2-6.1.sr... Description: The libqt4intf library allows applications which use Free Pascal and Lazarus to be compiled for Qt4. The binding can be used with Lazarus >= 0.9.28 or without the LCL in "pure Pascal" programs. It is also possible for other non-C++ languages to link against libqt4intf.so access Qt4.
I'm new to RPM packaging, I hope this package isn't too buggy.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=542458
Alagunambi Welkin alagunambiwelkin@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |alagunambiwelkin@gmail.com
--- Comment #1 from Alagunambi Welkin alagunambiwelkin@gmail.com 2009-12-29 15:20:03 EDT --- (In reply to comment #0) Hi,
Just a quick suggestions
################################################################################ rpmlint on libqtintf4.spec throwed this, ################################################################################ libqtintf4.spec:24: W: setup-not-quiet libqtintf4.spec: E: no-cleaning-of-buildroot %install libqtintf4.spec: E: no-cleaning-of-buildroot %clean libqtintf4.spec: E: no-buildroot-tag 0 packages and 1 specfiles checked; 3 errors, 1 warnings. ################################################################################rpmlint on libqt4intf5.src.rpm ################################################################################ libqt4intf5.src: E: invalid-spec-name libqt4intf5.src:24: W: setup-not-quiet libqt4intf5.src: E: no-cleaning-of-buildroot %install libqt4intf5.src: E: no-cleaning-of-buildroot %clean libqt4intf5.src: E: no-buildroot-tag libqt4intf5.src: W: non-standard-group System/Libraries libqt4intf5.src: W: no-version-in-last-changelog libqt4intf5.src: W: invalid-license LGPL v2+ libqt4intf5.src: W: no-url-tag 1 packages and 0 specfiles checked; 4 errors, 5 warnings. ################################################################################ Few suggested corrections: ################################################################################ #) Change the release form "0" to "1" #) Change COPYING.TXT it is not mentioning which version of LGPL used #) In SPEC Try to use "%{name}" and "%{version}" like macros, which will be easy to update #) In Group change "System/Libraries" to "Development/Libraries" refer to /usr/share/doc/rpm-[version]/GROUPS #) add "-q" along with your %setup to make it quiet: Error 1 #) echo will not be effective here #) uncomment the "rm -rf %{buildroot}" in %clean: Error 3 #) Add "rm -rf %{buildroot}" in %{install}: Error 2 #) Error 4 can be ignored unless if you want this package to be on EPEL #) Add your project url from where project source can be downloaded in URL tag #) The availability of source in internet is *must* ################################################################################ For your reference ################################################################################ http://fedoraproject.org/wiki/Packaging/NamingGuidelines http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Spec_file_name http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#GPL_and_LGPL https://fedoraproject.org/wiki/Packaging/RPMMacros https://fedoraproject.org/wiki/PackagingDrafts/Changelog https://fedoraproject.org/wiki/Packaging/SourceURL https://fedoraproject.org/wiki/PackagingGuidelines#Shared_Libraries https://fedoraproject.org/wiki/Archive:PackagingDrafts/BuildRootHandling ################################################################################
Please do rpmlint to your spec and *.rpm files before uploading
Alagunambi Welkin
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=542458
--- Comment #2 from matthias@nlinux.org 2009-12-29 16:50:13 EDT --- Okay, I fixed everything. Lintian is now silent, except for "E: no-buildroot-tag "
You can find the updated specfile and the new src.rpm here: http://listaller.nlinux.org/factory/rpmbuild/libqt4intf5-1.72_Qt4.5.2-1.src.... http://listaller.nlinux.org/factory/rpmbuild/libqtintf4.spec
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=542458
--- Comment #3 from Rex Dieter rdieter@math.unl.edu 2010-01-20 16:27:35 EST --- A couple of initial comments/questions, then I'll do a formal review...
1. SHOULD: please come up with a better package summary. Wrapper library for Qt4 is not very descriptive.
2. Why the BuildRequires: phonon-backend-xine ?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=542458
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |needinfo?(matthias@nlinux.o | |rg)
--- Comment #4 from Rex Dieter rdieter@math.unl.edu 2010-01-20 16:32:44 EST --- and some small simplifications and cosmetics would help, like
3. MUST use the following scriptlets instead: %post -p /sbin/ldconfig
%postun -p /sbin/ldconfig
4. MUST: instead of /usr/%_lib use %{_libdir}
5. SHOULD: no need to quote stuff in %files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=542458
matthias@nlinux.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|needinfo?(matthias@nlinux.o | |rg) |
--- Comment #5 from matthias@nlinux.org 2010-01-20 17:19:55 EST --- There is a new release now which has a qmake-file. I will update the package. But the new version of libqt4pas will then be usable with Lazarus 0.9.30, which is still in development.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=542458
--- Comment #6 from Rex Dieter rdieter@math.unl.edu 2010-04-08 10:11:41 EDT --- ping? any news? :)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=542458
matthias@nlinux.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Alias| |libqt4pas, packaging
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=542458
matthias@nlinux.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Alias|packaging |libqt4intf
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=542458
--- Comment #7 from matthias@nlinux.org 2010-04-09 09:37:18 EDT --- Upstream changed the name of this library, so I made this package: Spec URL: http://listaller.nlinux.org/factory/rpmbuild/libqtpas4.spec Source tarball: http://listaller.nlinux.org/factory/rpmbuild/libqt4pas_2.1Qt4.5.3.tar.gz
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=542458
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |rdieter@math.unl.edu Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=542458
--- Comment #8 from Rex Dieter rdieter@math.unl.edu 2010-04-09 10:32:09 EDT --- hrm, I see 2 package names used here, libqt4inf and libqt4pas , which is it?
I'll assume comment #7 is what is under scrutiny here. Please confirm, and we can adjust this the bug summary to match.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=542458
--- Comment #9 from matthias@nlinux.org 2010-04-09 10:35:59 EDT --- The right name for this lib is libqt4pas. Libqt4intf was the previous upstream name.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=542458
matthias@nlinux.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: libqt4intf |Review Request: libqt4pas - |- Wrapper library for Qt4 |Wrapper library for Qt4
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=542458
matthias@nlinux.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Alias|libqt4intf, libqt4pas |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=542458
--- Comment #10 from Rex Dieter rdieter@math.unl.edu 2010-04-09 10:53:12 EDT --- 1 MUST: missing upstream project URL: tag
2 MUST: Source: tags should contain full URLs (to at least be able to verify validity of upstream sources) If a full URL cannot be provided, please include a comment in the .spec explaining why. See https://fedoraproject.org/wiki/Packaging:SourceURL#Referencing_Source
3 MUST: Version tag is strange, 2.1Qt4.5.3 , I'd suggest using simply Version: 2.1 I don't see much purpose encoding Qt or qt version here. See https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Package_Version
4 MUST: many of the BuildRequires: are superfluous or not needed, I'd suggest trimming them down to simply: BuildRequires: libxml2-devl BuildRequires: qt4-devel See https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRequires
5 MUST: Requires can be reduced to just: Requires: qt4%{?_isa} >= %{_qt4_version} See https://fedoraproject.org/wiki/Packaging/Guidelines#Requires
6 MUST: scripts can be adjusted to: %post -p /sbin/ldconfig %postun -p /sbin/ldconfig See https://fedoraproject.org/wiki/Packaging/Guidelines#Shared_Libraries
7 SHOULD: can use %{qt4_qmake} macro instead of qmake-qt4 (but that's up to you).
8 SHOULD: in %build, use make %{?_smp_mflags} if parallel make isn't supported, please add comment in .spec saying why
9 MUST: Summary: Qt4 interface bindings is vague, please adjust to mention Pascal, maybe something like Summary: Qt4 interface bindings for Pascal
10 MUST: -devel subpkg requires should be tightened to: Requires: %{name} = %{version}-%{release} See https://fedoraproject.org/wiki/Packaging/Guidelines#Requiring_Base_Package
11 MUST: Group: tags invalid (or missing), I suggest Group: System Environment/Libraries and for -devel subpkg Group: Development/Libraries
12 MUST: License tag invalid, use License: LGPLv2+ instead. See https://fedoraproject.org/wiki/Licensing#Good_Licenses
13 SHOULD: use of %{?dist} is highly recommended, I'd suggest using Release: 1%{?dist} Seehttps://fedoraproject.org/wiki/Packaging/NamingGuidelines#Using_the_.25.7B.3...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=542458
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Alias| |libqt4pas
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=542458
--- Comment #11 from matthias@nlinux.org 2010-04-09 13:46:59 EDT --- Many thanks for this detailed description! I use Debian as primary workstation and Fedora on a second machine. Cause I changed the specs on Debian this time and hadn't checked rpmlint, I've overseen those issues. -> All changed
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=542458
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #12 from Rex Dieter rdieter@math.unl.edu 2010-04-21 11:53:46 EDT ---
7. I made a typo, correct macro is %{_qt4_qmake} . sorry.
but I won't consider that a blocker.
I should note that whenever making any changes (even for review), please document them in the %changelog , and increment Release when doing so.
The .spec now looks clean and conformant, APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=542458
--- Comment #13 from Rex Dieter rdieter@math.unl.edu 2010-04-21 11:55:03 EDT --- ok, one more small suggestion, I'd recommend using the %{_datadir} macro, instead of hard-coding /usr/share (unless there's a compelling reason to do otherwise, if so, please document that in a comment in the .spec).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=542458
--- Comment #14 from matthias@nlinux.org 2010-05-07 07:36:03 EDT --- Changed. Thanks!
http://listaller.nlinux.org/factory/rpmbuild/libqtpas4.spec
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=542458
--- Comment #15 from Rex Dieter rdieter@math.unl.edu 2010-05-11 17:00:14 EDT --- A couple of minor issues, Source + Source0 %qt4_qmake vs %_qt4_qmake
fixed, so I could do a koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2181345
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=542458
--- Comment #16 from Rex Dieter rdieter@math.unl.edu 2010-08-09 17:59:50 EDT --- Haven't heard back in awhile, please follow the next steps of the process,
http://fedoraproject.org/wiki/PackageMaintainers/Join#Add_Package_to_Source_...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=542458
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Blocks| |201449(FE-DEADREVIEW) Resolution| |NOTABUG Flag|fedora-review+ | Last Closed| |2011-09-02 11:08:39
--- Comment #17 from Rex Dieter rdieter@math.unl.edu 2011-09-02 11:08:39 EDT --- No response marking as stalled review per, http://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
please to ping back and re-open if you want to pursue this further.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla