[Bug 459871] New: Review Request: samefile - An utility to find identical files on the file system

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: samefile - An utility to find identical files on the file system

https://bugzilla.redhat.com/show_bug.cgi?id=459871

Summary: Review Request: samefile - An utility to find
                    identical files on the file system
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
   Estimated Hours: 0.0
    Classification: Fedora

Spec URL: http://rishi.fedorapeople.org/samefile.spec
SRPM URL: http://rishi.fedorapeople.org/samefile-2.12-1.fc8.src.rpm
Description: 
The samefile utility finds files with identical contents, independent of file 
name. This program is for you if you are notoriously low on disk space, keep 
exceeding your disk quota, pay for your storage by the megabyte, run any kind 
of file server, need to reduce the size of your backups, or just want to get 
a feeling for how much redundant files are there on your system.

[Bug 459871] Review Request: samefile - An utility to find identical files on the file system

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=459871

--- Comment #1 from Rakesh Pandit   2008-08-23 14:29:48 EDT ---
This is an unofficial quick review(as I am not a sponsor) to help this package:
1. You should add

%check 
 make test

to use test cases provided.
2. Confirm from upstream about license. From project page it looks to be BSD.
But it is always good to verify.
3. Optional Suggestion: You may like to remove macros from URL.

+rpmlint clean
+Build on mock -- successfully
+summary -- okay
+description -- okay
+build root -- okay
   I give priority to this:
   %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX)

+md5sum source from package:
 5e51411512f693897f9cfd59c45071f7 
 from project resource:
 5e51411512f693897f9cfd59c45071f7

- license tag correct, few source files (i confirm 1+)src files have license
txt included but most of them don't have. So, you may like to confirm it from
upstream.
+package naming 
+spec file & base package name match
+macros used consistently, sane spec file
+compiler flags are appropriate
 -you may like to request including a license file to upstream, though this is
optional here -- moreover only few src files have license block.
+You may also like to contact upstream about you being packaging for fedora and
they may -- once passed update there project page. Right now they have point to
different RPMs (third party may be)

[Bug 459871] Review Request: samefile - An utility to find identical files on the file system

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=459871

--- Comment #2 from Rakesh Pandit   2008-08-23 14:36:36 EDT ---
You should add FE-NEEDSPONSOR to 'Blocks' field, so that sponsors will notice
your ticket and do read:
https://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored

[Bug 459871] Review Request: samefile - An utility to find identical files on the file system

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=459871

--- Comment #3 from Mamoru Tasaka   2008-08-25 01:15:14 EDT ---
(Removing NEEDSPONSOR: bug 458624)

[Bug 459871] Review Request: samefile - An utility to find identical files on the file system

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=459871

--- Comment #4 from vivek shah   2008-08-25 09:35:44 EDT ---
Thanks for the reviews, I have updated the %check section and also added the
ChangeLog file

SPEC URL: http://bonii.fedorapeople.org/spec/samefile.spec
SRPM URL: http://bonii.fedorapeople.org/srpms/samefile-2.12-2.fc8.src.rpm

The license is BSD since this is the license specified in the spec file for
creating the rpm for OpenSUSE distribution by the upstream author which is also
included in the source tar.

[Bug 459871] Review Request: samefile - An utility to find identical files on the file system

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=459871

Rakesh Pandit  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]    |[e-mail]

--- Comment #5 from Rakesh Pandit   2008-08-25 11:35:21 EDT ---
I will do a detailed review today or at least tomorrow ;-)

[Bug 459871] Review Request: samefile - An utility to find identical files on the file system

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=459871

--- Comment #6 from Rakesh Pandit   2008-09-03 09:22:55 EDT ---

[  APPROVED  ]

rpmlint is clean

rp => rpmlint
[rakesh@thulsadoom SRPMS]$ rp samefile-2.12-2.fc10.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

[rakesh@thulsadoom x86_64]$ rp samefile-2.12-2.fc10.x86_64.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

[rakesh@thulsadoom x86_64]$ rp samefile-debuginfo-2.12-2.fc10.x86_64.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

Required:
[x] Name (in accordance guidelines)
[x] spec file name
[x] License approved by fedora
[x] Spec file is in American Eng and legible
[x] Build successfully
[x] BuildRequires okay 
[x] Duplicate files - nil
[NA] locale
[x] permissions -- okay
[x]  source link correct
[x] packaging guidlines
[x] Buildroot correct
[x] owns every directory it creates
[x] file encoding - checked
[x] package has no dependency on files in %doc
[NA] gui
[x] No dependencies outside FHS guidelines
[!] Source0 URL is wrong. It should be
http://www.schweikhardt.net/%%7Bname%7D-%%7Bversion%7D.tar.gz . Without www it does not
work.
[x] md5sum

Source from srpm:
[rakesh@thulsadoom x86_64]$ md5sum samefile-2.12.tar.gz 
5e51411512f693897f9cfd59c45071f7 
Using Source0 as http://www.schweikhardt.net/%%7Bname%7D-%%7Bversion%7D.tar.gz 
[rakesh@thulsadoom samefile]$ md5sum samefile-2.12.tar.gz 
5e51411512f693897f9cfd59c45071f7

md5sum matches

[x] unnecessary files excluded 
[x] native compiler test
[NA] devel package contains right files

Optional suggestions:
[!] request upstream to include license file.
[!] Include ChangeLog (it has important info)

*You may like to ignore them*

Key NA = N/A, x = Check, ! = Problem, ? = Not evaluated

Please correct URL before importing. You may also like to look at optional
suggestions.

[Bug 459871] Review Request: samefile - An utility to find identical files on the file system

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=459871

--- Comment #7 from vivek shah   2008-09-03 09:40:15 EDT ---
Thanks for the review, I will look into the SOURCE0 URL and fix it if it is not
working without www.

New Package CVS Request
=======================
Package Name: samefile
Short Description: An utility to find identical files on the file system
Owners: bonii
Branches: F-8 F-9
InitialCC:

[Bug 459871] Review Request: samefile - An utility to find identical files on the file system

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=459871

--- Comment #8 from Kevin Fenzi   2008-09-03 16:23:04 EDT ---
cvs done.

[Bug 459871] Review Request: samefile - An utility to find identical files on the file system

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=459871

--- Comment #9 from Fedora Update System   2008-09-05 09:08:16 EDT ---
samefile-2.12-3.fc9 has been submitted as an update for Fedora 9.
http://admin.fedoraproject.org/updates/samefile-2.12-3.fc9

[Bug 459871] Review Request: samefile - An utility to find identical files on the file system

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=459871

--- Comment #10 from Fedora Update System   2008-09-05 09:08:20 EDT ---
samefile-2.12-3.fc8 has been submitted as an update for Fedora 8.
http://admin.fedoraproject.org/updates/samefile-2.12-3.fc8

[Bug 459871] Review Request: samefile - An utility to find identical files on the file system

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=459871

Rakesh Pandit  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

[Bug 459871] Review Request: samefile - An utility to find identical files on the file system

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=459871

Rakesh Pandit  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE

--- Comment #11 from Rakesh Pandit   2008-09-10 02:52:19 EDT ---
It has been submitted as an update.

I am closing it as 'NEXTRELEASE'

[Bug 459871] Review Request: samefile - An utility to find identical files on the file system

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=459871

--- Comment #12 from Fedora Update System   2008-09-24 19:59:14 EDT ---
samefile-2.12-3.fc8 has been pushed to the Fedora 8 stable repository.  If
problems still persist, please make note of it in this bug report.

[Bug 459871] Review Request: samefile - An utility to find identical files on the file system

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=459871

--- Comment #13 from Fedora Update System   2008-09-24 20:00:19 EDT ---
samefile-2.12-3.fc9 has been pushed to the Fedora 9 stable repository.  If
problems still persist, please make note of it in this bug report.

[Bug 459871] Review Request: samefile - An utility to find identical files on the file system

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=459871

Dmitry Butskoy  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
               Flag|fedora-cvs+                 |fedora-cvs?

--- Comment #14 from Dmitry Butskoy  2012-02-13 06:59:20 EST ---
Package Change Request
======================
Package Name: samefile
New Branches: el6
Owners: buc

[Bug 459871] Review Request: samefile - An utility to find identical files on the file system

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=459871

--- Comment #15 from Jon Ciesla  2012-02-13 09:51:12 EST ---
Git done (by process-git-requests).