[Bug 675976] New: Review Request: jgoodies-common - Common library shared by JGoodies libraries and applications

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: jgoodies-common - Common library shared by JGoodies libraries and applications

https://bugzilla.redhat.com/show_bug.cgi?id=675976

Summary: Review Request: jgoodies-common - Common library
                    shared by JGoodies libraries and applications
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
   Estimated Hours: 0.0
    Classification: Fedora

Spec URL:
http://melmorabity.fedorapeople.org/packages/jgoodies-common/jgoodies-common...
SRPM URL:
http://melmorabity.fedorapeople.org/packages/jgoodies-common/jgoodies-common...
Description:
The JGoodies Common library provides convenience code for other JGoodies
libraries and applications.

Note:
This package is required by latest versions of jgoodies libraries
(jgoodies-forms/looks in the repos).

[Bug 675976] Review Request: jgoodies-common - Common library shared by JGoodies libraries and applications

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=675976

Alexander Kurtakov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
         AssignedTo|[e-mail]    |[e-mail]
               Flag|                            |fedora-review?

--- Comment #1 from Alexander Kurtakov  2011-02-17 14:26:06 EST ---
I'll do this one.

[Bug 675976] Review Request: jgoodies-common - Common library shared by JGoodies libraries and applications

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=675976

--- Comment #2 from Alexander Kurtakov  2011-02-17 14:36:06 EST ---
Package Review
==============

Key:
- = N/A
x = Check
! = Problem
? = Not evaluated

=== REQUIRED ITEMS ===
[x]  Rpmlint output:
2 packages and 0 specfiles checked; 0 errors, 0 warnings.
[x]  Package is named according to the Package Naming Guidelines[1].
[x]  Spec file name must match the base package name, in the format
%{name}.spec.
[x]  Package meets the Packaging Guidelines[2].
[x]  Package successfully compiles and builds into binary rpms.
[!]  Buildroot definition is not present
[x]  Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging
Guidelines[3,4].
[x]  License field in the package spec file matches the actual license.
License type: BSD
[x]  If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
[-]  All independent sub-packages have license of their own
[x]  Spec file is legible and written in American English.
[x]  Sources used to build the package matches the upstream source, as provided
in the spec URL.
MD5SUM this package    :48cd0511251611669e6bfedb1a34f0ea
MD5SUM upstream package:48cd0511251611669e6bfedb1a34f0ea
[x]  All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines[5].
[x]  Package must own all directories that it creates.
[x]  Package requires other packages for directories it uses.
[x]  Package does not contain duplicates in %files.
[x]  Permissions on files are set properly.
[!]  Package does NOT have a %clean section which contains rm -rf %{buildroot}
(or $RPM_BUILD_ROOT). (not needed anymore)
[x]  Package consistently uses macros (no %{buildroot} and $RPM_BUILD_ROOT
mixing)
[x]  Package contains code, or permissable content.
[x]  Fully versioned dependency in subpackages, if present.
[-]  Package contains a properly installed %{name}.desktop file if it is a GUI
application.
[x]  Package does not own files or directories owned by other packages.
[x]  Javadoc documentation files are generated and included in -javadoc
subpackage
[x]  Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlinks)
[x]  Packages have proper BuildRequires/Requires on jpackage-utils
[x]  Javadoc subpackages have Require: jpackage-utils
[-]  Package uses %global not %define
[-]  If package uses tarball from VCS include comment how to re-create that
tarball (svn export URL, git clone URL, ...)
[x]  If source tarball includes bundled jar/class files these need to be
removed prior to building
[x]  All filenames in rpm packages must be valid UTF-8.
[x]  Jar files are installed to %{_javadir}/%{name}.jar (see [6] for details)
[-]  If package contains pom.xml files install it (including depmaps) even when
building with ant
[-]  pom files has correct add_to_maven_depmap call which resolves to the pom
file (use "JPP." and "JPP-" correctly)

=== Maven ===
[-]  Use %{_mavenpomdir} macro for placing pom files instead of
%{_datadir}/maven2/poms
[-]  If package uses "-Dmaven.test.skip=true" explain why it was needed in a
comment
[-]  If package uses custom depmap "-Dmaven2.jpp.depmap.file=*" explain why
it's needed in a comment
[-]  Package uses %update_maven_depmap in %post/%postun
[-]  Packages have Requires(post) and Requires(postun) on jpackage-utils (for
%update_maven_depmap macro)

=== Other suggestions ===
[-]  If possible use upstream build method (maven/ant/javac)
[x]  Avoid having BuildRequires on exact NVR unless necessary
[x]  Package has BuildArch: noarch (if possible)
[x]  Latest version is packaged.

=== Issues ===
1.Remove buildroot
2.Remove  clean section
3.Remove rm -rf $RPM_BUILD_ROOT from install section.

Overall the package is quite good, just remove some old and not used anymore
parts of it.

[Bug 675976] Review Request: jgoodies-common - Common library shared by JGoodies libraries and applications

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=675976

--- Comment #3 from Mohamed El Morabity  2011-02-19 08:45:30 EST ---
Thanks for your review. The obsolete code is generated by rpmdev-newspec.
Anyway here is a cleaned version:

Spec URL:
http://melmorabity.fedorapeople.org/packages/jgoodies-common/jgoodies-common...
SRPM URL:
http://melmorabity.fedorapeople.org/packages/jgoodies-common/jgoodies-common...

[Bug 675976] Review Request: jgoodies-common - Common library shared by JGoodies libraries and applications

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=675976

Alexander Kurtakov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #4 from Alexander Kurtakov  2011-02-19 13:44:36 EST ---
Thanks, looks good.

APPROVED.

[Bug 675976] Review Request: jgoodies-common - Common library shared by JGoodies libraries and applications

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=675976

Mohamed El Morabity  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

--- Comment #5 from Mohamed El Morabity  2011-02-19 14:07:11 EST ---
New Package SCM Request
=======================
Package Name: jgoodies-common
Short Description: Common library shared by JGoodies libraries and applications
Owners: melmorabity
Branches: f15
InitialCC:

[Bug 675976] Review Request: jgoodies-common - Common library shared by JGoodies libraries and applications

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=675976

--- Comment #6 from Jason Tibbitts  2011-02-19 15:19:15 EST ---
Git done (by process-git-requests).

[Bug 675976] Review Request: jgoodies-common - Common library shared by JGoodies libraries and applications

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=675976

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |MODIFIED

[Bug 675976] Review Request: jgoodies-common - Common library shared by JGoodies libraries and applications

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=675976

--- Comment #7 from Fedora Update System  2011-02-19 19:38:09 EST ---
jgoodies-common-1.1.1-2.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/jgoodies-common-1.1.1-2.fc15

[Bug 675976] Review Request: jgoodies-common - Common library shared by JGoodies libraries and applications

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=675976

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |ON_QA

--- Comment #8 from Fedora Update System  2011-02-19 23:12:47 EST ---
jgoodies-common-1.1.1-2.fc15 has been pushed to the Fedora 15 testing
repository.  If problems still persist, please make note of it in this bug
report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update jgoodies-common'.  You can
provide feedback for this update here:
https://admin.fedoraproject.org/updates/jgoodies-common-1.1.1-2.fc15

[Bug 675976] Review Request: jgoodies-common - Common library shared by JGoodies libraries and applications

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=675976

--- Comment #9 from Fedora Update System  2011-03-07 21:15:25 EST ---
jgoodies-common-1.1.1-2.fc15 has been pushed to the Fedora 15 stable
repository.  If problems still persist, please make note of it in this bug
report.

[Bug 675976] Review Request: jgoodies-common - Common library shared by JGoodies libraries and applications

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=675976

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |CLOSED
   Fixed In Version|                            |jgoodies-common-1.1.1-2.fc1
                   |                            |5
         Resolution|                            |ERRATA
        Last Closed|                            |2011-03-07 21:15:32

[Bug 675976] Review Request: jgoodies-common - Common library shared by JGoodies libraries and applications

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=675976

Mohamed El Morabity  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs+                 |fedora-cvs?

--- Comment #10 from Mohamed El Morabity  2011-12-21 21:06:42 EST ---
Package Change Request
======================
Package Name: jgoodies-common
New Branches: el6
Owners: melmorabity

[Bug 675976] Review Request: jgoodies-common - Common library shared by JGoodies libraries and applications

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=675976

--- Comment #11 from Jon Ciesla  2011-12-22 08:11:41 EST ---
Git done (by process-git-requests).