https://bugzilla.redhat.com/show_bug.cgi?id=1481986
Bug ID: 1481986 Summary: Review Request: python-consul - Python client for Consul (http://www.consul.io/) Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: ykarel@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://raw.githubusercontent.com/karelyatin/consulpackaging/master/python-c... SRPM URL: https://raw.githubusercontent.com/karelyatin/consulpackaging/master/python-c... Description: Python client for Consul.io Fedora Account System Username: ykarel
Koji scratch builds:- f27: https://koji.fedoraproject.org/koji/taskinfo?taskID=21258510 f25: https://koji.fedoraproject.org/koji/taskinfo?taskID=21258459
https://bugzilla.redhat.com/show_bug.cgi?id=1481986
Haïkel Guémar karlthered@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |karlthered@gmail.com Blocks| |1427510 (RDO-PIKE) Assignee|nobody@fedoraproject.org |karlthered@gmail.com Flags| |fedora-review?
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1427510 [Bug 1427510] Tracker: Blockers and Review requests for new RDO Pike packages
https://bugzilla.redhat.com/show_bug.cgi?id=1481986
--- Comment #1 from Haïkel Guémar karlthered@gmail.com --- This line is likely a typo?
requirements.txt
You shouldn't need to duplicate sources
No need to list all files in %files, I'd also list treq as a required dependency for twisted support (not mandatory to have it packaged for initial review though)
https://bugzilla.redhat.com/show_bug.cgi?id=1481986
--- Comment #2 from Yatin Karel ykarel@redhat.com --- Incorporated comments, Updated Spec File and SRPM:-
Spec URL: https://raw.githubusercontent.com/karelyatin/consulpackaging/master/python-c... SRPM URL: https://raw.githubusercontent.com/karelyatin/consulpackaging/master/python-c...
Koji build successful: https://koji.fedoraproject.org/koji/taskinfo?taskID=21417553
https://bugzilla.redhat.com/show_bug.cgi?id=1481986
--- Comment #3 from Yatin Karel ykarel@redhat.com --- python-treq is available in testing now, so updated the spec to use it:-
Spec URL: https://raw.githubusercontent.com/karelyatin/consulpackaging/master/python-c... SRPM URL: https://raw.githubusercontent.com/karelyatin/consulpackaging/master/python-c...
Koji Build Successful: https://koji.fedoraproject.org/koji/taskinfo?taskID=21678759
package-review@lists.fedoraproject.org