https://bugzilla.redhat.com/show_bug.cgi?id=2149698
Bug ID: 2149698 Summary: Review Request: sile - The SILE Typesetter Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: hegjon@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://jonny.fedorapeople.org/sile.spec SRPM URL: https://jonny.fedorapeople.org/sile-0.14.5-1.fc36.src.rpm
Description: SILE is a typesetting system; its job is to produce beautiful printed documents. Conceptually, SILE is similar to TeX—from which it borrows some concepts and even syntax and algorithms—but the similarities end there. Rather than being a derivative of the TeX family SILE is a new typesetting and layout engine written from the ground up using modern technologies and borrowing some ideas from graphical systems such as InDesign.
Fedora Account System Username: jonny
https://bugzilla.redhat.com/show_bug.cgi?id=2149698
Jonny Heggheim hegjon@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value Depends On| |2142798, 2143056, 2143351, | |2142671, 2143382, 2143020, | |2142653, 2143050, 2142786, | |2143391, 2143028, 2149626, | |2149686
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2142653 [Bug 2142653] Review Request: lua-cldr - Lua interface to Unicode CLDR data https://bugzilla.redhat.com/show_bug.cgi?id=2142671 [Bug 2142671] Review Request: lua-cosmo - Safe templates for Lua https://bugzilla.redhat.com/show_bug.cgi?id=2142786 [Bug 2142786] Review Request: lua-epnf - Extended PEG Notation Format (easy grammars for LPeg) https://bugzilla.redhat.com/show_bug.cgi?id=2142798 [Bug 2142798] Review Request: lua-fluent - Lua implementation of Project Fluent https://bugzilla.redhat.com/show_bug.cgi?id=2143020 [Bug 2143020] Review Request: lua-linenoise - A binding for the linenoise command line library https://bugzilla.redhat.com/show_bug.cgi?id=2143028 [Bug 2143028] Review Request: lua-loadkit - Loadkit allows you to load arbitrary files within the Lua package path https://bugzilla.redhat.com/show_bug.cgi?id=2143050 [Bug 2143050] Review Request: lua-zlib - Simple streaming interface to zlib for Lua https://bugzilla.redhat.com/show_bug.cgi?id=2143056 [Bug 2143056] Review Request: lua-cliargs - A command-line argument parser https://bugzilla.redhat.com/show_bug.cgi?id=2143351 [Bug 2143351] Review Request: lua-vstruct - Lua library to manipulate binary data https://bugzilla.redhat.com/show_bug.cgi?id=2143382 [Bug 2143382] Review Request: lua-luarepl - REPL.lua - a reusable Lua REPL written in Lua https://bugzilla.redhat.com/show_bug.cgi?id=2143391 [Bug 2143391] Review Request: lua-utf8 - A UTF-8 support module for Lua https://bugzilla.redhat.com/show_bug.cgi?id=2149626 [Bug 2149626] Review Request: libertinus-fonts - The Libertinus Fonts project https://bugzilla.redhat.com/show_bug.cgi?id=2149686 [Bug 2149686] Review Request: hack-fonts - A typeface designed for source code
https://bugzilla.redhat.com/show_bug.cgi?id=2149698 Bug 2149698 depends on bug 2143351, which changed state.
Bug 2143351 Summary: Review Request: lua-vstruct - Lua library to manipulate binary data https://bugzilla.redhat.com/show_bug.cgi?id=2143351
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE
https://bugzilla.redhat.com/show_bug.cgi?id=2149698 Bug 2149698 depends on bug 2143056, which changed state.
Bug 2143056 Summary: Review Request: lua-cliargs - A command-line argument parser https://bugzilla.redhat.com/show_bug.cgi?id=2143056
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE
https://bugzilla.redhat.com/show_bug.cgi?id=2149698 Bug 2149698 depends on bug 2142786, which changed state.
Bug 2142786 Summary: Review Request: lua-epnf - Extended PEG Notation Format (easy grammars for LPeg) https://bugzilla.redhat.com/show_bug.cgi?id=2142786
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE
https://bugzilla.redhat.com/show_bug.cgi?id=2149698 Bug 2149698 depends on bug 2143382, which changed state.
Bug 2143382 Summary: Review Request: lua-luarepl - REPL.lua - a reusable Lua REPL written in Lua https://bugzilla.redhat.com/show_bug.cgi?id=2143382
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE
https://bugzilla.redhat.com/show_bug.cgi?id=2149698 Bug 2149698 depends on bug 2142671, which changed state.
Bug 2142671 Summary: Review Request: lua-cosmo - Safe templates for Lua https://bugzilla.redhat.com/show_bug.cgi?id=2142671
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE
https://bugzilla.redhat.com/show_bug.cgi?id=2149698 Bug 2149698 depends on bug 2142653, which changed state.
Bug 2142653 Summary: Review Request: lua-cldr - Lua interface to Unicode CLDR data https://bugzilla.redhat.com/show_bug.cgi?id=2142653
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE
https://bugzilla.redhat.com/show_bug.cgi?id=2149698 Bug 2149698 depends on bug 2149626, which changed state.
Bug 2149626 Summary: Review Request: alerque-libertinus-fonts - The Libertinus Fonts project https://bugzilla.redhat.com/show_bug.cgi?id=2149626
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE
https://bugzilla.redhat.com/show_bug.cgi?id=2149698 Bug 2149698 depends on bug 2149686, which changed state.
Bug 2149686 Summary: Review Request: source-foundry-hack-fonts - A typeface designed for source code https://bugzilla.redhat.com/show_bug.cgi?id=2149686
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=2149698 Bug 2149698 depends on bug 2143050, which changed state.
Bug 2143050 Summary: Review Request: lua-zlib - Simple streaming interface to zlib for Lua https://bugzilla.redhat.com/show_bug.cgi?id=2143050
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |CURRENTRELEASE
https://bugzilla.redhat.com/show_bug.cgi?id=2149698 Bug 2149698 depends on bug 2143391, which changed state.
Bug 2143391 Summary: Review Request: lua-luautf8 - A UTF-8 support module for Lua https://bugzilla.redhat.com/show_bug.cgi?id=2143391
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |CURRENTRELEASE
https://bugzilla.redhat.com/show_bug.cgi?id=2149698
--- Comment #1 from Jonny Heggheim hegjon@gmail.com --- Updated to version 0.14.9, new SRPM URL:
Spec URL: https://jonny.fedorapeople.org/sile.spec SRPM URL: https://jonny.fedorapeople.org/sile-0.14.9-1.fc36.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=2149698 Bug 2149698 depends on bug 2142798, which changed state.
Bug 2142798 Summary: Review Request: lua-fluent - Lua implementation of Project Fluent https://bugzilla.redhat.com/show_bug.cgi?id=2142798
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE
https://bugzilla.redhat.com/show_bug.cgi?id=2149698 Bug 2149698 depends on bug 2143020, which changed state.
Bug 2143020 Summary: Review Request: lua-linenoise - A binding for the linenoise command line library https://bugzilla.redhat.com/show_bug.cgi?id=2143020
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=2149698
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://sile-typesetter.org | |/
--- Comment #3 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6300310 (failed)
Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please make sure the package builds successfully at least for Fedora Rawhide.
- If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2149698
Robert-André Mauchin 🐧 zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(hegjon@gmail.com) CC| |zebob.m@gmail.com
--- Comment #4 from Robert-André Mauchin 🐧 zebob.m@gmail.com --- - Please use autochangelog/autorelease
- Requires: libtexpdf = %{version}
-> should include arch:
Requires: libtexpdf%{?_isa} = %{version}-%{release}
- Why is this bundled? Was it modified by the project?
Provides: bundled(lua-lunamark)
- Same question about libtexpdf
%package -n libtexpdf Summary: bundled with SILE
It seems that it is straight taken from another repo. Why don't you package it separately?
Also that Summary is a no go. We don't care about the fact that it is bundled in the summary, the user needs to know what this package do.
I saw https://github.com/sile-typesetter/libtexpdf/issues/25 and it seems there is no release tarball anymore, but you can still grab an archive from a commit.
I saw this too https://github.com/sile-typesetter/libtexpdf/issues/3#issuecomment-130176798... but there is a cmake script now and you only need zlib and libpng.
Please consider it.
https://bugzilla.redhat.com/show_bug.cgi?id=2149698
Jonny Heggheim hegjon@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Link ID| |Github | |sile-typesetter/sile/issues | |/669
--- Comment #5 from Jonny Heggheim hegjon@gmail.com --- (In reply to Robert-André Mauchin 🐧 from comment #4)
- Please use autochangelog/autorelease
I will update the spec.
- Requires: libtexpdf = %{version}
-> should include arch:
Yes, arch should also be included.
Requires: libtexpdf%{?_isa} = %{version}-%{release}
- Why is this bundled? Was it modified by the project?
I think it is extracted from Tex Live into its own git repo by the SILE team. This git repo have no releases. This git repo have only been integrated with SILE as a git submodule.
Provides: bundled(lua-lunamark)
- Same question about libtexpdf
Seems like they are working on unbundling lunamark: https://github.com/sile-typesetter/sile/issues/669
%package -n libtexpdf Summary: bundled with SILE
It seems that it is straight taken from another repo. Why don't you package it separately?
Also that Summary is a no go. We don't care about the fact that it is bundled in the summary, the user needs to know what this package do.
That is a good point.
I saw https://github.com/sile-typesetter/libtexpdf/issues/25 and it seems there is no release tarball anymore, but you can still grab an archive from a commit.
I saw this too https://github.com/sile-typesetter/libtexpdf/issues/3#issuecomment- 1301767989 but there is a cmake script now and you only need zlib and libpng.
Please consider it.
I will try to package it directly from the commit that is used by SILE.
https://bugzilla.redhat.com/show_bug.cgi?id=2149698 Bug 2149698 depends on bug 2143028, which changed state.
Bug 2143028 Summary: Review Request: lua-loadkit - Loadkit allows you to load arbitrary files within the Lua package path https://bugzilla.redhat.com/show_bug.cgi?id=2143028
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=2149698
Jonny Heggheim hegjon@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(hegjon@gmail.com) |
--- Comment #6 from Jonny Heggheim hegjon@gmail.com --- (In reply to Robert-André Mauchin 🐧 from comment #4)
I saw this too https://github.com/sile-typesetter/libtexpdf/issues/3#issuecomment- 1301767989 but there is a cmake script now and you only need zlib and libpng.
Seems like cmake is broken in libtexpdf https://github.com/sile-typesetter/libtexpdf/issues/28
https://bugzilla.redhat.com/show_bug.cgi?id=2149698
Robert-André Mauchin 🐧 zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(hegjon@gmail.com)
--- Comment #7 from Robert-André Mauchin 🐧 zebob.m@gmail.com --- Do you have a sample of the SPEC you've written for libtexpdf?
https://bugzilla.redhat.com/show_bug.cgi?id=2149698
--- Comment #8 from Robert-André Mauchin 🐧 zebob.m@gmail.com --- Ok let's check this SPEC: https://eclipseo.fedorapeople.org/libtexpdf/
It's based on the Meson PR on the repository. Check if it build with Sile.
https://bugzilla.redhat.com/show_bug.cgi?id=2149698
Jonny Heggheim hegjon@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(hegjon@gmail.com) |
--- Comment #9 from Jonny Heggheim hegjon@gmail.com --- (In reply to Robert-André Mauchin 🐧 from comment #7)
Do you have a sample of the SPEC you've written for libtexpdf?
This was what I started with https://jonny.fedorapeople.org/libtexpdf.spec
https://bugzilla.redhat.com/show_bug.cgi?id=2149698
--- Comment #10 from Caleb Maclennan caleb@alerque.com --- Hey, upstream SILE and libtexpdf maintainer here.
Long term I 100% agree that getting the libtexpdf projects split out into its own project is the goal we want to achieve, but we're not there yet. We already have it as a separate Git repository because we knew we wanted to allow it to be independent, but it really isn't there yet. To date it has no stand-alone releases and the Makefile even makes assumptions about being a submodule of the SILE repository.
Until it has it's own releases and fully stand alone build system I would suggest just building with it being installed as part of the SILE package. As soon as it does have it's own tagged releases then a new package could provide the library and the SILE package could be changed to depend on it.
https://bugzilla.redhat.com/show_bug.cgi?id=2149698
Jonny Heggheim hegjon@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(zebob.m@gmail.com | |)
--- Comment #11 from Jonny Heggheim hegjon@gmail.com --- Based on the feedback from upstream, I would like to keep SILE and libtexpdf in the same spec/build.
I updated SILE to the latest version 0.14.12 and made changes based on the review. Could you have another look?
Spec URL: https://jonny.fedorapeople.org/sile.spec SRPM URL: https://jonny.fedorapeople.org/sile-0.14.12-1.fc38.src.rpm
Build result: https://copr.fedorainfracloud.org/coprs/jonny/SILE/build/6571793/
https://bugzilla.redhat.com/show_bug.cgi?id=2149698
--- Comment #12 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6575034 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2149698
Jonny Heggheim hegjon@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(zebob.m@gmail.com | |)
--- Comment #13 from Jonny Heggheim hegjon@gmail.com --- Could you have a new look at this review Robert-André Mauchin please :)? It is the last package needed for SILE to work on Fedora.
https://bugzilla.redhat.com/show_bug.cgi?id=2149698
--- Comment #14 from Jonny Heggheim hegjon@gmail.com --- Updated to version 0.14.14, new SRPM URL:
Spec URL: https://jonny.fedorapeople.org/sile.spec SRPM URL: https://jonny.fedorapeople.org/sile-0.14.14-1.fc39.src.rpm
COPR build: https://copr.fedorainfracloud.org/coprs/jonny/SILE/build/6822153/
https://bugzilla.redhat.com/show_bug.cgi?id=2149698
--- Comment #15 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 2006254 --> https://bugzilla.redhat.com/attachment.cgi?id=2006254&action=edit The .spec file difference from Copr build 6575034 to 6823507
https://bugzilla.redhat.com/show_bug.cgi?id=2149698
--- Comment #16 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6823507 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2149698
--- Comment #17 from Jonny Heggheim hegjon@gmail.com --- Updated to version 0.14.16, new SRPM URL:
Spec URL: https://jonny.fedorapeople.org/sile.spec SRPM URL: https://jonny.fedorapeople.org/sile-0.14.16-1.fc39.src.rpm
COPR build: https://copr.fedorainfracloud.org/coprs/jonny/SILE/build/6970514/
https://bugzilla.redhat.com/show_bug.cgi?id=2149698
--- Comment #18 from Jonny Heggheim hegjon@gmail.com --- Updated to version 0.14.17, new SRPM URL:
Spec URL: https://jonny.fedorapeople.org/sile.spec SRPM URL: https://jonny.fedorapeople.org/sile-0.14.17-1.fc39.src.rpm
COPR build: https://copr.fedorainfracloud.org/coprs/jonny/SILE/build/7000270/
https://bugzilla.redhat.com/show_bug.cgi?id=2149698
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |AutomationTriaged
--- Comment #19 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/7000855 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2149698
--- Comment #20 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 2015841 --> https://bugzilla.redhat.com/attachment.cgi?id=2015841&action=edit The .spec file difference from Copr build 7000855 to 7000856
https://bugzilla.redhat.com/show_bug.cgi?id=2149698
--- Comment #21 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/7000856 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2149698
Caleb Maclennan caleb@alerque.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(zebob.m@gmail.com | |) | |needinfo?(zebob.m@gmail.com | |) |
--- Comment #22 from Caleb Maclennan caleb@alerque.com --- What should be happening next here, how do we move this forward?
package-review@lists.fedoraproject.org