[Bug 1583023] New: Review Request: shobhika-fonts - Free Indian truetype/ open type fonts

https://bugzilla.redhat.com/show_bug.cgi?id=1583023

Bug ID: 1583023
           Summary: Review Request: shobhika-fonts - Free Indian
                    truetype/open type fonts
           Product: Fedora
           Version: rawhide
         Component: Package Review
          Severity: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]

Spec URL:
https://copr-be.cloud.fedoraproject.org/results/vishalvvr/shobhika-fonts/fed...

SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/vishalvvr/shobhika-fonts/fed...

Description: Shobhika is a free, open source, Unicode compliant, OpenType font
with support for Devanāgarī, Latin, and Cyrillic scripts. It is available in
two weights—regular and bold. The font is designed with over 1600 Devanāgarī
glyphs, including support for over 1100 conjunct consonants, as well as vedic
accents.

Fedora Account System Username: vishalvvr

[Bug 1583023] Review Request: shobhika-fonts - Free Indian truetype/ open type fonts

https://bugzilla.redhat.com/show_bug.cgi?id=1583023

Parag AN(पराग)  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
           Assignee|[e-mail]    |[e-mail]
              Flags|                            |fedora-review?

[Bug 1583023] Review Request: shobhika-fonts - Free Indian truetype/ open type fonts

https://bugzilla.redhat.com/show_bug.cgi?id=1583023

--- Comment #1 from Parag AN(पराग)  ---
Suggestions:
1) You have added common_desc macro but not used it anywhere. Also, I don't
think you need it as this is not generating more than one subpackage.

2) You can use %autosetup macro instead of %setup as
%autosetup -n Shobhika-%{version}

3) You can also add Appstream metainfo file for font. So if you have that as
Source2 in spec file then you can add it as
# Add AppStream metadata file
install -Dm 0644 -p %{SOURCE2} \
        %{buildroot}%{_datadir}/metainfo/%{fontname}.metainfo.xml

%check
appstream-util validate-relax --nonet \
        %{buildroot}%{_datadir}/metainfo/%{fontname}.metainfo.xml

then add this file entry to %_font_pkg macro of main package.

4) When you will update spec file, increase release count as 2 and add related
changelog entry and submit new SPEC and SRPM urls for further review.

[Bug 1583023] Review Request: shobhika-fonts - Free Indian truetype/ open type fonts

https://bugzilla.redhat.com/show_bug.cgi?id=1583023

--- Comment #2 from vishalvvr  ---
Spec URL:
https://copr-be.cloud.fedoraproject.org/results/vishalvvr/shobhika-fonts/fed...

SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/vishalvvr/shobhika-fonts/fed...

Resolved the issues mentioned above.

[Bug 1583023] Review Request: shobhika-fonts - Free Indian truetype/ open type fonts

https://bugzilla.redhat.com/show_bug.cgi?id=1583023

--- Comment #3 from Parag AN(पराग)  ---
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

Suggestions:
1) fontconfig conf file is not correct. This package should use fontconfig file
similar to 65-1-lohit-devanagari.conf file.

fix this and submit new SPEC and SRPM.

===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated". 6 files have unknown license. Detailed
     output of licensecheck in /home/parag/1583023-shobhika-
     fonts/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 20480 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.

fonts:
[!]: Run repo-font-audit on all fonts in package.
     Note: Cannot find createrepo, install createrepo package to make a
     comprehensive font review.
     See: url: undefined
[x]: Run ttname on all fonts in package.
     Note: ttname analyze results in fonts/ttname.log.

Rpmlint
-------
Checking: shobhika-fonts-1.04-2.fc29.noarch.rpm
          shobhika-fonts-1.04-2.fc29.src.rpm
shobhika-fonts.noarch: W: spelling-error %description -l en_US vedic -> medic,
verdict
shobhika-fonts.src: W: spelling-error %description -l en_US vedic -> medic,
verdict
2 packages and 0 specfiles checked; 0 errors, 2 warnings.

Rpmlint (installed packages)
----------------------------
sh: /usr/bin/python: No such file or directory
shobhika-fonts.noarch: W: spelling-error %description -l en_US vedic -> medic,
verdict
shobhika-fonts.noarch: W: invalid-url URL:
https://github.com/Sandhi-IITBombay/Shobhika <urlopen error [Errno -2] Name or
service not known>
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

Requires
--------
shobhika-fonts (rpmlib, GLIBC filtered):
    config(shobhika-fonts)
    fontpackages-filesystem

Provides
--------
shobhika-fonts:
    config(shobhika-fonts)
    font(:lang=aa)
    font(:lang=ab)
    font(:lang=an)
    font(:lang=av)
    font(:lang=ay)
    font(:lang=ba)
    font(:lang=be)
    font(:lang=bg)
    font(:lang=bh)
    font(:lang=bho)
    font(:lang=bi)
    font(:lang=br)
    font(:lang=brx)
    font(:lang=bs)
    font(:lang=bua)
    font(:lang=ce)
    font(:lang=ch)
    font(:lang=chm)
    font(:lang=co)
    font(:lang=crh)
    font(:lang=cs)
    font(:lang=csb)
    font(:lang=cv)
    font(:lang=da)
    font(:lang=de)
    font(:lang=doi)
    font(:lang=en)
    font(:lang=eo)
    font(:lang=es)
    font(:lang=et)
    font(:lang=eu)
    font(:lang=fi)
    font(:lang=fil)
    font(:lang=fj)
    font(:lang=fo)
    font(:lang=fr)
    font(:lang=fur)
    font(:lang=fy)
    font(:lang=gd)
    font(:lang=gl)
    font(:lang=gv)
    font(:lang=hi)
    font(:lang=hne)
    font(:lang=ho)
    font(:lang=hr)
    font(:lang=hsb)
    font(:lang=ht)
    font(:lang=hu)
    font(:lang=ia)
    font(:lang=id)
    font(:lang=ie)
    font(:lang=ik)
    font(:lang=io)
    font(:lang=is)
    font(:lang=it)
    font(:lang=jv)
    font(:lang=kaa)
    font(:lang=kj)
    font(:lang=kk)
    font(:lang=kok)
    font(:lang=ku-tr)
    font(:lang=kum)
    font(:lang=kv)
    font(:lang=kwm)
    font(:lang=ky)
    font(:lang=lb)
    font(:lang=lez)
    font(:lang=li)
    font(:lang=lt)
    font(:lang=lv)
    font(:lang=mai)
    font(:lang=mg)
    font(:lang=mh)
    font(:lang=mn-mn)
    font(:lang=mr)
    font(:lang=ms)
    font(:lang=nb)
    font(:lang=nds)
    font(:lang=ne)
    font(:lang=ng)
    font(:lang=nl)
    font(:lang=nn)
    font(:lang=no)
    font(:lang=nr)
    font(:lang=nso)
    font(:lang=oc)
    font(:lang=om)
    font(:lang=os)
    font(:lang=pap-an)
    font(:lang=pap-aw)
    font(:lang=pl)
    font(:lang=pt)
    font(:lang=rm)
    font(:lang=rn)
    font(:lang=ru)
    font(:lang=rw)
    font(:lang=sa)
    font(:lang=sah)
    font(:lang=sat)
    font(:lang=sc)
    font(:lang=sel)
    font(:lang=sg)
    font(:lang=sh)
    font(:lang=sk)
    font(:lang=sl)
    font(:lang=sma)
    font(:lang=smj)
    font(:lang=sn)
    font(:lang=so)
    font(:lang=sq)
    font(:lang=sr)
    font(:lang=ss)
    font(:lang=st)
    font(:lang=su)
    font(:lang=sv)
    font(:lang=sw)
    font(:lang=tg)
    font(:lang=tk)
    font(:lang=tl)
    font(:lang=tn)
    font(:lang=tr)
    font(:lang=ts)
    font(:lang=tt)
    font(:lang=ty)
    font(:lang=tyv)
    font(:lang=uk)
    font(:lang=uz)
    font(:lang=vo)
    font(:lang=vot)
    font(:lang=wa)
    font(:lang=wen)
    font(:lang=xh)
    font(:lang=yap)
    font(:lang=za)
    font(:lang=zu)
    font(shobhika)
    font(shobhikabold)
    font(shobhikaregular)
    metainfo()
    metainfo(shobhika.metainfo.xml)
    shobhika-fonts

Source checksums
----------------
https://github.com/Sandhi-IITBombay/Shobhika/releases/download/v1.04/Shobhik...
:
  CHECKSUM(SHA256) this package     :
d2e476f8f64da74446a8d82892d6910794e1980b0e50b61e3b852b24e40cac90
  CHECKSUM(SHA256) upstream package :
d2e476f8f64da74446a8d82892d6910794e1980b0e50b61e3b852b24e40cac90

Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -b 1583023 -m fedora-rawhide-x86_64
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, fonts, Shell-api
Disabled plugins: Java, C/C++, Python, SugarActivity, Ocaml, Perl, Haskell, R,
PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

[Bug 1583023] Review Request: shobhika-fonts - Free Indian truetype/ open type fonts

https://bugzilla.redhat.com/show_bug.cgi?id=1583023

--- Comment #4 from vishalvvr  ---
SPEC URL :
https://copr-be.cloud.fedoraproject.org/results/vishalvvr/shobhika-fonts/fed...

SRPM URL :
https://copr-be.cloud.fedoraproject.org/results/vishalvvr/shobhika-fonts/fed...

Resolved the fontconfig conf file issue mentioned above.

[Bug 1583023] Review Request: shobhika-fonts - Free Indian truetype/ open type fonts

https://bugzilla.redhat.com/show_bug.cgi?id=1583023

--- Comment #5 from Parag AN(पराग)  ---
Looks good now.

Thanks for this package submission.

APPROVED.

[Bug 1583023] Review Request: shobhika-fonts - Free Indian truetype/ open type fonts

https://bugzilla.redhat.com/show_bug.cgi?id=1583023

Parag AN(पराग)  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+

[Bug 1583023] Review Request: shobhika-fonts - Free Indian truetype/ open type fonts

https://bugzilla.redhat.com/show_bug.cgi?id=1583023

Parag AN(पराग)  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |177841 (FE-NEEDSPONSOR)

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor

[Bug 1583023] Review Request: shobhika-fonts - Free Indian truetype/ open type fonts

https://bugzilla.redhat.com/show_bug.cgi?id=1583023

Parag AN(पराग)  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|177841 (FE-NEEDSPONSOR)     |

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor

[Bug 1583023] Review Request: shobhika-fonts - Free Indian truetype/ open type fonts

https://bugzilla.redhat.com/show_bug.cgi?id=1583023

--- Comment #6 from Gwyn Ciesla  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/shobhika-fonts

[Bug 1583023] Review Request: shobhika-fonts - Free Indian truetype/ open type fonts

https://bugzilla.redhat.com/show_bug.cgi?id=1583023

Elliott Sales de Andrade  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
                 CC|                            |[e-mail]
   Fixed In Version|                            |shobhika-fonts-1.04-3.fc29
         Resolution|---                         |RAWHIDE
        Last Closed|                            |2018-08-28 20:46:40

--- Comment #7 from Elliott Sales de Andrade  ---
Please re-open if necessary, but this appears to have been built.