https://bugzilla.redhat.com/show_bug.cgi?id=2126348
Bug ID: 2126348 Summary: Review Request: perl-Tickit - Perl bindings for Tickit Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: psalaba@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://rpm.urumasi.xyz/perl-Tickit/perl-Tickit.spec SRPM URL: https://rpm.urumasi.xyz/perl-Tickit/perl-Tickit-0.73-1.fc38.src.rpm Description: Perl bindings for Tickit, a high-level toolkit for creating full-screen terminal-based interactive programs. Fedora Account System Username: psalaba
https://bugzilla.redhat.com/show_bug.cgi?id=2126348
Jitka Plesnikova jplesnik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flags| |fedora-review? Assignee|nobody@fedoraproject.org |jplesnik@redhat.com CC| |jplesnik@redhat.com
--- Comment #1 from Jitka Plesnikova jplesnik@redhat.com --- Source file is ok Summary is ok License is ok Description is ok URL and Source0 are ok All tests passed
BuildRequires FIX: Please add build-requires: perl(base) - lib/Tickit/Pen.pm:356 perl(Carp) - lib/Tickit.pm:11 perl(Config) - spec file:54 perl(constant) - lib/Tickit/Pen.pm:357 perl(Errno) - t/30tickit.t:16 perl(integer) - lib/Tickit/Utils.pm:277 perl(IO::Handle) - lib/Tickit.pm:13 perl(List::Util) - lib/Tickit/RectSet.pm:11 perl(overload) - lib/Tickit/Pen.pm:345 perl(POSIX) - t/03utils.t:8 perl(Scalar::Util) - lib/Tickit.pm:15 perl(Test::Builder) - lib/Tickit/Test.pm:54 perl(Time::HiRes) - lib/Tickit.pm:16 perl(utf8) - t/03utils.t:23 perl(XSLoader) - lib/Tickit.pm:19
$ rpm -qp --requires perl-Tickit-0.73-1.fc38.x86_64.rpm | sort | uniq -c | grep -v rpmlib 1 libc.so.6()(64bit) 1 libc.so.6(GLIBC_2.2.5)(64bit) 1 libc.so.6(GLIBC_2.4)(64bit) 1 libc.so.6(GLIBC_2.7)(64bit) 1 libtickit.so.3()(64bit) 1 perl(base) 1 perl(Carp) 1 perl(constant) 1 perl(Exporter) 1 perl(IO::Handle) 1 perl(List::Util) 1 perl(:MODULE_COMPAT_5.36.0) 1 perl(overload) 1 perl(Scalar::Util) 1 perl(Struct::Dumb) >= 0.04 1 perl(Test::Builder) 1 perl(Tickit) 1 perl(Tickit::Debug) 1 perl(Tickit::Event) 1 perl(Tickit::Pen) >= 0.31 1 perl(Tickit::Rect) 1 perl(Tickit::RectSet) 1 perl(Tickit::RenderBuffer) 1 perl(Tickit::Term) 1 perl(Tickit::Test::MockTerm) 1 perl(Tickit::Utils) 1 perl(Tickit::Window) 1 perl(Time::HiRes) 1 perl(:VERSION) >= 5.14.0 1 perl(warnings) 1 rtld(GNU_HASH) FIX: Please add run-requires: perl(XSLoader) - lib/Tickit.pm:19
$ rpm -qp --requires perl-Tickit-tests-0.73-1.fc38.x86_64.rpm | sort | uniq -c | grep -v rpmlib 1 perl(Errno) 1 perl(IO::Handle) 1 perl(POSIX) 1 perl(Test::Builder::Tester) 2 perl(Test::Fatal) 1 perl(Test::Harness) 1 perl(Test::HexString) 1 perl(Test::More) 1 perl(Test::Refcount) 1 perl(Tickit) 1 perl-Tickit = 0.73-1.fc38 1 perl(Tickit::Pen) 1 perl(Tickit::Rect) 1 perl(Tickit::RectSet) 1 perl(Tickit::RenderBuffer) 1 perl(Tickit::StringPos) 1 perl(Tickit::Term) 1 perl(Tickit::Test) 1 perl(Tickit::Utils) 1 perl(Tickit::Window) 1 perl(Time::HiRes) 1 perl(utf8) 1 perl(:VERSION) >= 5.14.0 1 perl(warnings) 1 /usr/bin/perl 1 /usr/bin/sh FIX: Please remove duplicated run-require 'perl(Test::Fatal)' FIX: Please add run-requires 'perl(constant)'
$ rpm -qp --provides perl-Tickit-0.73-1.fc38.x86_64.rpm | sort | uniq -c 1 perl(Tickit) = 0.73 1 perl-Tickit = 0.73-1.fc38 1 perl(Tickit::Debug) = 0.73 1 perl(Tickit::Event) = 0.73 1 perl(Tickit::Pen) = 0.73 1 perl(Tickit::Pen::Immutable) = 0.73 1 perl(Tickit::Pen::Mutable) = 0.73 1 perl(Tickit::Rect) = 0.73 1 perl(Tickit::RectSet) = 0.73 1 perl(Tickit::RenderBuffer) = 0.73 1 perl(Tickit::StringPos) = 0.73 1 perl(Tickit::Term) = 0.73 1 perl(Tickit::Test) = 0.73 1 perl(Tickit::Test::MockTerm) = 0.73 1 perl(Tickit::Utils) = 0.73 1 perl(Tickit::Window) = 0.73 1 perl-Tickit(x86-64) = 0.73-1.fc38 $ rpm -qp --provides perl-Tickit-tests-0.73-1.fc38.x86_64.rpm | sort | uniq -c 1 perl-Tickit-tests = 0.73-1.fc38 1 perl-Tickit-tests(x86-64) = 0.73-1.fc38 Binary provides are Ok.
$ rpmlint ./perl-Tickit* Rpmlint is ok
FIX: In section %files, - please move LICENSE from %docs to %license - please remove META.json, it is only metadata - not useful
FIX: The t/99pod.t has to be removed from perl-Tickit-tests. Test::Pod check works only for lib/ in the repository. t/99pod.t ................. 1/1 # Failed test 'POD test for lib' # at /usr/share/perl5/vendor_perl/Test/Pod.pm line 184. # lib does not exist # Looks like you failed 1 test of 1. t/99pod.t ................. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/1 subtests
Otherwise the package is in line with Fedora and Perl packaging guide lines. Please correct all 'FIX' items and provide a new spec file.
Resolution: NOT Approved
https://bugzilla.redhat.com/show_bug.cgi?id=2126348
Jitka Plesnikova jplesnik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(psalaba@redhat.co | |m)
--- Comment #2 from Jitka Plesnikova jplesnik@redhat.com --- Any progress?
https://bugzilla.redhat.com/show_bug.cgi?id=2126348
Petr Salaba psalaba@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(psalaba@redhat.co | |m) |
--- Comment #3 from Petr Salaba psalaba@redhat.com --- Sorry for the late update, here's the fixed/updated files: Spec URL: https://rpm.urumasi.xyz/perl-Tickit/perl-Tickit.spec SRPM URL: https://rpm.urumasi.xyz/perl-Tickit/perl-Tickit-0.73-1.fc38.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=2126348
--- Comment #4 from Jitka Plesnikova jplesnik@redhat.com ---
BuildRequires FIX: Please add build-requires:
<...> Almost all missing dependencies were added only one is missing. FIX: Add BR - perl(Config) - spec file:54
FIX: Please add run-requires: perl(XSLoader) - lib/Tickit.pm:19
+# Runtime +Requires: perl(XSLoader) Ok.
$ rpm -qp --requires perl-Tickit-tests-0.73-1.fc38.x86_64.rpm | sort | uniq -c | grep -v rpmlib
<...>
FIX: Please remove duplicated run-require 'perl(Test::Fatal)'
-Requires: perl(Test::Fatal) Ok
FIX: Please add run-requires 'perl(constant)'
Still need to be fixed
FIX: In section %files, - please move LICENSE from %docs to %license - please remove META.json, it is only metadata - not useful
-%doc Changes examples LICENSE META.json README +%doc Changes examples README +%license LICENSE Ok.
FIX: The t/99pod.t has to be removed from perl-Tickit-tests. Test::Pod check works only for lib/ in the repository.
+rm %{buildroot}%{_libexecdir}/%{name}/t/99pod.t Ok.
Please correct all 'FIX' items and provide a new spec file.
Resolution: NOT Approved
https://bugzilla.redhat.com/show_bug.cgi?id=2126348
--- Comment #5 from Petr Salaba psalaba@redhat.com --- Checked and corrected all FIXes, thanks for the review Spec URL: https://rpm.urumasi.xyz/perl-Tickit/perl-Tickit.spec SRPM URL: https://rpm.urumasi.xyz/perl-Tickit/perl-Tickit-0.73-1.fc38.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=2126348
Jitka Plesnikova jplesnik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #6 from Jitka Plesnikova jplesnik@redhat.com --- (In reply to Jitka Plesnikova from comment #4)
BuildRequires FIX: Please add build-requires:
<...> Almost all missing dependencies were added only one is missing. FIX: Add BR - perl(Config) - spec file:54
+BuildRequires: perl(Config) Ok.
FIX: Please add run-requires 'perl(constant)'
Still need to be fixed
# Runtime +Requires: perl(constant) Requires: perl(XSLoader) Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
@@ -63,6 +63,7 @@ Summary: Tests for %{name} Requires: %{name} = %{?epoch:%{epoch}:}%{version}-%{release} Requires: perl(Test::Harness) +Requires: perl(constant)
The run-require should be added only to sub-package perl-Tickit-tests. FIX: Remove run-requires 'perl(constant)' from the main package perl-Tickit, because it is found by generators.
Please correct 'FIX' item. Otherwise the package is in line with Fedora and Perl packaging guide lines.
Resolution: Approved
https://bugzilla.redhat.com/show_bug.cgi?id=2126348
--- Comment #7 from Petr Salaba psalaba@redhat.com --- https://pagure.io/releng/fedora-scm-requests/issue/48759
https://bugzilla.redhat.com/show_bug.cgi?id=2126348
--- Comment #8 from Tomas Hrcka thrcka@redhat.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Tickit
https://bugzilla.redhat.com/show_bug.cgi?id=2126348
Petr Salaba psalaba@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version| |perl-Tickit-0.73-1.fc38 Resolution|--- |RAWHIDE Status|ASSIGNED |CLOSED Last Closed| |2022-11-07 18:46:01
package-review@lists.fedoraproject.org