[Bug 1622347] New: Review Request: libwpe - a renaming of wpewebkit

https://bugzilla.redhat.com/show_bug.cgi?id=1622347

Bug ID: 1622347
           Summary: Review Request: libwpe - a renaming of wpewebkit
           Product: Fedora
           Version: rawhide
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]

Spec URL: https://bunnyapocalypse.space/libwpe.spec
SRPM URL: https://bunnyapocalypse.space/libwpe-1.0.0-1.fc28.src.rpm
Description: Renaming of wpebackend to libwpe to represent upstream changes.
This is my first time renaming a package, so sorry if I made mistakes in the
obsoletes etc.
Fedora Account System Username: bunnyapocalypse

[Bug 1622347] Review Request: libwpe - a renaming of wpewebkit

https://bugzilla.redhat.com/show_bug.cgi?id=1622347

Michael Catanzaro  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Michael Catanzaro  ---
Sorry for renaming this upstream right after you packaged it, but I figured i
was better to get the stupid naming fixed sooner rather than later.

[Bug 1622347] Review Request: libwpe - a renaming of wpewebkit

https://bugzilla.redhat.com/show_bug.cgi?id=1622347

Robert-André Mauchin  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Robert-André Mauchin  ---
If a package is being renamed without any functional changes, or is a
compatible enough replacement to an existing package (where "enough" means that
it includes only changes of magnitude that are commonly found in version
upgrade changes), provide clean upgrade paths and compatibility with:

Provides: oldpackagename = $provEVR
Obsoletes: oldpackagename < $obsEVR

$provEVR refers to an (Epoch-)Version-Release tuple the original unchanged
package would have had if it had been version or release bumped. You usually
use macros here because the provides EVR should continue to go up as the
renamed package advances in version and release. $obsEVR is an
(Epoch-)Version-Release tuple arranged so that there is a clean upgrade path
but without gratuitously polluting the version space upwards. You usually do
not use macros for this as you're simply trying to advance beyond the last
known release under the old name.

Per this guidelines, it should be:

Provides: wpebackend = %{version}-%{release} 
Obsoletes: wpebackend < 0.2.0-2

- Source0 is 404. It should be:

Source0:       
https://github.com/WebPlatformForEmbedded/libwpe/releases/download/%%7Bversi...

- Split the description to stay below 80 characters per line. Shorten the
summary and remove the dot at the end

libwpe.x86_64: W: summary-ended-with-dot C General-purpose library specifically
developed for the WPE-flavored port of WebKit.
libwpe.x86_64: E: summary-too-long C General-purpose library specifically
developed for the WPE-flavored port of WebKit.
libwpe.x86_64: E: description-line-too-long C General-purpose library
specifically developed for the WPE-flavored port of WebKit.

- The %changelog Version-Release entry is not correct:

* Fri Jul 13 2018 Chris King  - 1.0.0-1

[Bug 1622347] Review Request: libwpe - a renaming of wpewebkit

https://bugzilla.redhat.com/show_bug.cgi?id=1622347

--- Comment #3 from Chris King  ---
(In reply to Robert-André Mauchin from comment #2)
> Per this guidelines, it should be:
>
> Provides: wpebackend = %{version}-%{release} 
> Obsoletes: wpebackend < 0.2.0-2

Ah, I had a feeling I messed up there, fixed.
> Source0 is 404. It should be:
>
> Source0:       
> https://github.com/WebPlatformForEmbedded/libwpe/releases/download/
> %{version}/%{name}-%{version}.tar.xz

I have made this change
> Split the description to stay below 80 characters per line. Shorten the
>
> summary and remove the dot at the end

Fixed
> The %changelog Version-Release entry is not correct:

Fixed

Thanks again for another wonderful review Robert!

New spec:
https://copr-be.cloud.fedoraproject.org/results/bunnyapocalypse/wpewebkit-ra...
New SRPM:
https://copr-be.cloud.fedoraproject.org/results/bunnyapocalypse/wpewebkit-ra...

[Bug 1622347] Review Request: libwpe - a renaming of wpewebkit

https://bugzilla.redhat.com/show_bug.cgi?id=1622347

Robert-André Mauchin  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |POST
           Assignee|[e-mail]    |[e-mail]
              Flags|                            |fedora-review+

--- Comment #4 from Robert-André Mauchin  ---
Package approved.

[Bug 1622347] Review Request: libwpe - a renaming of wpewebkit

https://bugzilla.redhat.com/show_bug.cgi?id=1622347

--- Comment #5 from Gwyn Ciesla  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/libwpe