Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: gnome-screenshot - A screenshot utility for GNOME
https://bugzilla.redhat.com/show_bug.cgi?id=756636
Summary: gnome-screenshot - A screenshot utility for GNOME Product: Fedora Version: rawhide Platform: Unspecified OS/Version: Unspecified Status: NEW Severity: unspecified Priority: unspecified Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: mclasen@redhat.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: ---
This used to be part of gnome-utils. gnome-utils has been split into individual applications, which is why there is an Obsoletes here. Once all the individual pieces are packages, gnome-utils will go away.
The desktop file in here does not validate, since it contains non-standard Canonical extensions. This is unfortunate, but needs to be addressed upstream.
Spec: http://mclasen.fedorapeople.org/gnome-screenshot.spec SRPM: http://mclasen.fedorapeople.org/gnome-screenshot-3.3.1-1.fc16.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=756636
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |panemade@gmail.com AssignedTo|nobody@fedoraproject.org |panemade@gmail.com Summary|gnome-screenshot - A |Review Request: |screenshot utility for |gnome-screenshot - A |GNOME |screenshot utility for | |GNOME Flag| |fedora-review+
--- Comment #1 from Parag AN(पराग) panemade@gmail.com 2011-11-24 05:16:59 EST --- Review:-
+ koji scratch build ->http://koji.fedoraproject.org/koji/taskinfo?taskID=3537183
+ rpmlint on rpms gave gnome-screenshot.src:35: W: macro-in-comment %{_datadir} gnome-screenshot.x86_64: W: obsolete-not-provided gnome-utils gnome-screenshot.x86_64: E: incorrect-fsf-address /usr/share/doc/gnome-screenshot-3.3.1/COPYING gnome-screenshot.x86_64: E: invalid-desktopfile /usr/share/applications/gnome-screenshot.desktop file contains group "Screen Shortcut Group", but groups extending the format should start with "X-" gnome-screenshot.x86_64: E: invalid-desktopfile /usr/share/applications/gnome-screenshot.desktop file contains group "Window Shortcut Group", but groups extending the format should start with "X-" 2 packages and 0 specfiles checked; 3 errors, 2 warnings.
+ source verified with upstream as (sha1sum) 734ecd3ee4f2ccbd463754ec5b28b54fcd54c4c3 gnome-screenshot-3.3.1.tar.xz 734ecd3ee4f2ccbd463754ec5b28b54fcd54c4c3 ../SOURCES/gnome-screenshot-3.3.1.tar.xz
+ follows packaging guidelines.
Suggestions: 1) you can fix the macro-in-comment rpmlint warning using %% instead of %
2) also you can ask upstream to update fsf address.
3) Has the desktop issue already reported in upstream?
APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=756636
--- Comment #2 from Parag AN(पराग) panemade@gmail.com 2011-12-21 05:11:32 EST --- any updates here?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=756636
--- Comment #3 from Matthias Clasen mclasen@redhat.com 2011-12-21 09:13:25 EST --- Thanks Parag, I'll address your suggestions when I do the initial upload.
To answer your question: the desktop file extensions are being discussed on xdg-list, currently.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=756636
Matthias Clasen mclasen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #4 from Matthias Clasen mclasen@redhat.com 2011-12-21 09:19:09 EST --- New Package SCM Request ======================= Package Name: gnome-screenshot Short Description: A screenshot utility for GNOME Owners: mclasen, cosimoc Branches: InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=756636
--- Comment #5 from Jon Ciesla limburgher@gmail.com 2011-12-21 09:37:05 EST --- Git done (by process-git-requests).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=756636
Matthias Clasen mclasen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |RAWHIDE Last Closed| |2011-12-21 11:32:16
--- Comment #6 from Matthias Clasen mclasen@redhat.com 2011-12-21 11:32:16 EST --- build underway
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla