[Bug 1382850] New: Review Request: libtoml - Fast C parser using Ragel to generate the state machine

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382850

Bug ID: 1382850
           Summary: Review Request: libtoml - Fast C parser using Ragel to
                    generate the state machine
           Product: Fedora
           Version: rawhide
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]

Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/libtoml.spec
SRPM URL:
https://ignatenkobrain.fedorapeople.org/for-review/libtoml-0-1git03e8a3a.fc2...
Description: Fast C parser using Ragel to generate the state machine
Fedora Account System Username: ignatenkobrain

[Bug 1382850] Review Request: libtoml - Fast C parser using Ragel to generate the state machine

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382850

Igor Gnatenko  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Alias|                            |libtoml

[Bug 1382850] Review Request: libtoml - Fast C parser using Ragel to generate the state machine

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382850

Brandon Nielsen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Brandon Nielsen  ---
Informal review:

Unable to build the SRPM:

Error during basic setup:

Neither directory contains a build file meson.build.
error: Bad exit status from /var/tmp/rpm-tmp.c42CN3 (%build)

RPM build errors:
    Bad exit status from /var/tmp/rpm-tmp.c42CN3 (%build)

rpmlint warnings when checking SRPM:

libtoml.src: W: summary-ended-with-dot C Fast C parser using Ragel to generate
the state machine.
libtoml.src: E: no-changelogname-tag

The description should expand upon the summary.

[Bug 1382850] Review Request: libtoml - Fast C parser using Ragel to generate the state machine

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382850

--- Comment #2 from Till Maas  ---
There are no changelog entries in the spec.

[Bug 1382850] Review Request: libtoml - Fast C parser using Ragel to generate the state machine

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382850

--- Comment #3 from Michael Schwendt  ---
> Release:        1git%{shortcommit}%{?dist}

Does not follow the versioning guidelines:
https://fedoraproject.org/wiki/Packaging:Versioning#Snapshot_packages
> %package devel

https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package
> %{_libdir}/%{name}.so.*

https://fedoraproject.org/wiki/Packaging:Guidelines#Shared_Libraries

[Bug 1382850] Review Request: libtoml - Fast C parser using Ragel to generate the state machine

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382850

--- Comment #4 from Igor Gnatenko  ---
https://ignatenkobrain.fedorapeople.org/for-review/libtoml.spec
https://ignatenkobrain.fedorapeople.org/for-review/libtoml-0-1.20161213git03...

[Bug 1382850] Review Request: libtoml - Fast C parser using Ragel to generate the state machine

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382850

--- Comment #5 from Brandon Nielsen  ---
Still needs a detailed description.

Need to run ldconfig in %post and %postun as per the shared libraries portion
of the guidelines.

https://fedoraproject.org/wiki/Packaging:Guidelines#Shared_Libraries

[Bug 1382850] Review Request: libtoml - Fast C parser using Ragel to generate the state machine

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382850

Ilya Gradina  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
           Assignee|[e-mail]    |[e-mail]

[Bug 1382850] Review Request: libtoml - Fast C parser using Ragel to generate the state machine

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382850

--- Comment #6 from Ilya Gradina  ---
===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "BSD (3 clause)", "Unknown or generated". 23 files have unknown
     license. Detailed output of licensecheck in
     /home/ilgrad/1382850-libtoml/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[-]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[!]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in libtoml-
     debuginfo
[x]: Package functions as described.
[x]: Latest version is packaged.
[-]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[-]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.

*****************
rpmlint: libtoml.x86_64: E: library-without-ldconfig-postin
/usr/lib64/libtoml.so.0.0.0
*****************
fix it.
********
The package looks good.

[Bug 1382850] Review Request: libtoml - Fast C parser using Ragel to generate the state machine

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382850

Ilya Gradina  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review?

[Bug 1382850] Review Request: libtoml - Fast C parser using Ragel to generate the state machine

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382850

Ilya Gradina  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+

[Bug 1382850] Review Request: libtoml - Fast C parser using Ragel to generate the state machine

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382850

--- Comment #7 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/libtoml

[Bug 1382850] Review Request: libtoml - Fast C parser using Ragel to generate the state machine

https://bugzilla.redhat.com/show_bug.cgi?id=1382850

Igor Gnatenko  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |POST

[Bug 1382850] Review Request: libtoml - Fast C parser using Ragel to generate the state machine

https://bugzilla.redhat.com/show_bug.cgi?id=1382850

Igor Gnatenko  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|POST                        |CLOSED
         Resolution|---                         |WONTFIX
        Last Closed|                            |2018-08-22 03:31:08

--- Comment #8 from Igor Gnatenko  ---
Unfortunately I don't have time to work on these review requests anymore,
sorry.