[Bug 659895] New: Review Request: makedepf90 - Create Makefile dependency list for Fortran source files

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: makedepf90 - Create Makefile dependency list for Fortran source files

https://bugzilla.redhat.com/show_bug.cgi?id=659895

Summary: Review Request: makedepf90 - Create Makefile
                    dependency list for Fortran source files
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
   Estimated Hours: 0.0
    Classification: Fedora

Spec URL: http://rathann.fedorapeople.org/review/makedepf90.spec
SRPM URL:
http://rathann.fedorapeople.org/review/makedepf90-2.8.8-1.fc12.src.rpm
Description:
Makedepf90 is a program for automatic creation of Makefile dependency
lists for Fortran source code. Makedepf90 supports MODULE:s, INCLUDE:s,
cpp #include:s, f90ppr $include:s and coco ??include:s and set-files.

The original idea was to provide the same functionality for Fortran as

gcc -MM *.c

does for C.

[Bug 659895] Review Request: makedepf90 - Create Makefile dependency list for Fortran source files

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=659895

Dominik 'Rathann' Mierzejewski  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |659896

[Bug 659895] Review Request: makedepf90 - Create Makefile dependency list for Fortran source files

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=659895

Dominik 'Rathann' Mierzejewski  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Alias|                            |makedepf90

[Bug 659895] Review Request: makedepf90 - Create Makefile dependency list for Fortran source files

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=659895

Jussi Lehtola  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
         AssignedTo|[e-mail]    |[e-mail]
               Flag|                            |fedora-review+

--- Comment #1 from Jussi Lehtola  2010-12-05 05:54:41 EST ---
rpmlint output:
makedepf90.src: W: spelling-error %description -l en_US cpp -> cop, cp, pp
makedepf90.src: W: spelling-error %description -l en_US gcc -> cc, acc, g cc
makedepf90.x86_64: W: spelling-error %description -l en_US cpp -> cop, cp, pp
makedepf90.x86_64: W: spelling-error %description -l en_US gcc -> cc, acc, g cc
3 packages and 0 specfiles checked; 0 errors, 4 warnings.

MUST: The package does not yet exist in Fedora. The Review Request is not a
duplicate. OK

MUST: The spec file for the package is legible and macros are used
consistently. OK
- IMHO using macros for rm and make is a bit silly, but it's not disallowed.

MUST: The package must be named according to the Package Naming Guidelines. OK
MUST: The spec file name must match the base package %{name}. OK
MUST: The package must be licensed with a Fedora approved license and meet the 
Licensing Guidelines. OK
MUST: The License field in the package spec file must match the actual license.
OK

MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL. OK
514a32147e956264ac5e60cc12fd5f5d  makedepf90-2.8.8.tar.gz
514a32147e956264ac5e60cc12fd5f5d  ../SOURCES/makedepf90-2.8.8.tar.gz

MUST: The package MUST successfully compile and build into binary rpms. OK
MUST: The spec file MUST handle locales properly. N/A

MUST: Optflags are used and time stamps preserved. ~OK
- Please add INSTALL="install -p" to make install so that time stamp of the man
page is preserved.

MUST: Packages containing shared library files must call ldconfig. N/A
MUST: A package must own all directories that it creates or require the package
that owns the directory. N/A
MUST: Files only listed once in %files listings. OK
MUST: Debuginfo package is complete. OK
MUST: Permissions on files must be set properly. OK
MUST: Large documentation files must go in a -doc subpackage. N/A
MUST: All relevant items are included in %doc. Items in %doc do not affect
runtime of application. OK
MUST: Header files must be in a -devel package. N/A
MUST: Static libraries must be in a -static package. N/A
MUST: If a package contains library files with a suffix then library files
ending in .so must go in a -devel package. N/A
MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency. N/A
MUST: Packages does not contain any .la libtool archives. N/A
MUST: Desktop files are installed properly. N/A
MUST: No file conflicts with other packages and no general names. OK
SHOULD: %{?dist} tag is used in release. OK
SHOULD: If the package does not include license text(s) as separate files from
upstream, the packager should query upstream to include it. OK
SHOULD: The package builds in mock. OK
EPEL: Clean section exists. OK
EPEL: Buildroot cleaned before install. OK
EPEL: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'. N/A

Package APPROVED. Please check the time stamp issue before importing to git.

[Bug 659895] Review Request: makedepf90 - Create Makefile dependency list for Fortran source files

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=659895

Dominik 'Rathann' Mierzejewski  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

--- Comment #2 from Dominik 'Rathann' Mierzejewski  2010-12-06 18:40:08 EST ---
Excellent! Thanks for the speedy review. I'll fix the timestamp issue on
import.

New Package SCM Request
=======================
Package Name: makedepf90
Short Description: Create Makefile dependency list for Fortran source files
Owners: rathann
Branches: f13 f14 el6
InitialCC:

[Bug 659895] Review Request: makedepf90 - Create Makefile dependency list for Fortran source files

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=659895

--- Comment #3 from Jussi Lehtola  2010-12-08 09:19:36 EST ---
If you want to return the favor, please see bug #661143 and bug #661154 , both
quite simple packages.

[Bug 659895] Review Request: makedepf90 - Create Makefile dependency list for Fortran source files

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=659895

--- Comment #4 from Jens Petersen  2010-12-08 20:06:02 EST ---
Git done (by process-git-requests).

[Bug 659895] Review Request: makedepf90 - Create Makefile dependency list for Fortran source files

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=659895

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |MODIFIED

[Bug 659895] Review Request: makedepf90 - Create Makefile dependency list for Fortran source files

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=659895

--- Comment #5 from Fedora Update System  2010-12-09 09:09:06 EST ---
makedepf90-2.8.8-1.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/makedepf90-2.8.8-1.fc14

[Bug 659895] Review Request: makedepf90 - Create Makefile dependency list for Fortran source files

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=659895

--- Comment #6 from Fedora Update System  2010-12-09 09:09:14 EST ---
makedepf90-2.8.8-1.fc13 has been submitted as an update for Fedora 13.
https://admin.fedoraproject.org/updates/makedepf90-2.8.8-1.fc13

[Bug 659895] Review Request: makedepf90 - Create Makefile dependency list for Fortran source files

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=659895

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |ON_QA

--- Comment #7 from Fedora Update System  2010-12-09 17:00:47 EST ---
makedepf90-2.8.8-1.fc14 has been pushed to the Fedora 14 testing repository. 
If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update makedepf90'.  You can provide
feedback for this update here:
https://admin.fedoraproject.org/updates/makedepf90-2.8.8-1.fc14

[Bug 659895] Review Request: makedepf90 - Create Makefile dependency list for Fortran source files

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=659895

--- Comment #8 from Fedora Update System  2010-12-11 19:02:07 EST ---
makedepf90-2.8.8-1.fc13 has been pushed to the Fedora 13 stable repository.  If
problems still persist, please make note of it in this bug report.

[Bug 659895] Review Request: makedepf90 - Create Makefile dependency list for Fortran source files

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=659895

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |CLOSED
   Fixed In Version|                            |makedepf90-2.8.8-1.fc13
         Resolution|                            |ERRATA
        Last Closed|                            |2010-12-11 19:02:12

[Bug 659895] Review Request: makedepf90 - Create Makefile dependency list for Fortran source files

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=659895

--- Comment #9 from Fedora Update System  2010-12-11 19:02:46 EST ---
makedepf90-2.8.8-1.fc14 has been pushed to the Fedora 14 stable repository.  If
problems still persist, please make note of it in this bug report.

[Bug 659895] Review Request: makedepf90 - Create Makefile dependency list for Fortran source files

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=659895

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Fixed In Version|makedepf90-2.8.8-1.fc13     |makedepf90-2.8.8-1.fc14

[Bug 659895] Review Request: makedepf90 - Create Makefile dependency list for Fortran source files

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=659895

Dominik 'Rathann' Mierzejewski  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs+                 |fedora-cvs?

--- Comment #10 from Dominik 'Rathann' Mierzejewski  2011-03-06 05:45:23 EST ---
Package Change Request
=======================
Package Name: makedepf90
New Branches: el5
Owners: rathann

[Bug 659895] Review Request: makedepf90 - Create Makefile dependency list for Fortran source files

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=659895

--- Comment #11 from Jason Tibbitts  2011-03-06 13:28:35 EST ---
Git done (by process-git-requests).