[Bug 2150517] New: Review Request: rust-svg_metadata - Extracts metadata (like the viewBox, width, and height) from SVG graphics

https://bugzilla.redhat.com/show_bug.cgi?id=2150517

Bug ID: 2150517
           Summary: Review Request: rust-svg_metadata - Extracts metadata
                    (like the viewBox, width, and height) from SVG
                    graphics
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL: https://kalev.fedorapeople.org/rust-svg_metadata.spec
SRPM URL: https://kalev.fedorapeople.org/rust-svg_metadata-0.4.2-8.fc38.src.rpm
Description:
Extracts metadata (like the viewBox, width, and height) from SVG graphics.

Fedora Account System Username: kalev

Note that this is a re-review as the package was retired from Fedora because
nothing used it any more.

[Bug 2150517] Review Request: rust-svg_metadata - Extracts metadata (like the viewBox, width, and height) from SVG graphics

https://bugzilla.redhat.com/show_bug.cgi?id=2150517

--- Comment #1 from Kalev Lember  ---
Koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=94884101

The package is at version 0.4.2 because 0.4.3 needs newer rust-roxmltree than
what's currently in Fedora. Should be easy to update once roxmltree is updated.

[Bug 2150517] Review Request: rust-svg_metadata - Extracts metadata (like the viewBox, width, and height) from SVG graphics

https://bugzilla.redhat.com/show_bug.cgi?id=2150517

--- Comment #2 from Kalev Lember  ---
I went ahead and updated rust-roxmltree to 0.15.1 that this package needs and
with this I was able to update it to 0.4.3:

* Sat Dec 03 2022 Kalev Lember  0.4.3-1
- Update to 0.4.3

Spec URL: https://kalev.fedorapeople.org/rust-svg_metadata.spec
SRPM URL: https://kalev.fedorapeople.org/rust-svg_metadata-0.4.3-1.fc38.src.rpm

Koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=94889493

[Bug 2150517] Review Request: rust-svg_metadata - Extracts metadata (like the viewBox, width, and height) from SVG graphics

https://bugzilla.redhat.com/show_bug.cgi?id=2150517

Fabio Valentini  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review?
                 CC|                            |[e-mail]
             Status|NEW                         |ASSIGNED
           Assignee|[e-mail]    |[e-mail]

--- Comment #3 from Fabio Valentini  ---
Looks good to me, with one possible exception:
> ## Credits
>
> The SVG fixtures used for testing are provided by
> [Openclipart](https://en.wikipedia.org/wiki/Openclipart)
> [SVG Specification Examples](https://www.w3.org/TR/SVG2/)
> [W3C SVG Working Group](https://www.w3.org/Graphics/SVG/)
>
> under their respective licenses.

This applies to the files under the "/fixtures" directory.

Openclipart: CC0-1.0, is OK for content.

SVG Specification examples:
Seems to be covered by this license:
https://www.w3.org/Consortium/Legal/2015/doc-license
Not sure if it's OK for content in Fedora.

W3C SVG Working Group: No idea where examples came from or what license applies
to them.

It might be easiest to just nuke the "fixtures" directory and use a "clean"
source tarball ...
Not sure why / how this wasn't caught during the last package review (but it
seems to have been a bit ... rushed:
https://bugzilla.redhat.com/show_bug.cgi?id=1910871)

[Bug 2150517] Review Request: rust-svg_metadata - Extracts metadata (like the viewBox, width, and height) from SVG graphics

https://bugzilla.redhat.com/show_bug.cgi?id=2150517

Fabio Valentini  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |needinfo?([e-mail]
                   |                            |m)

[Bug 2150517] Review Request: rust-svg_metadata - Extracts metadata (like the viewBox, width, and height) from SVG graphics

https://bugzilla.redhat.com/show_bug.cgi?id=2150517

Kalev Lember  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |NOTABUG
              Flags|needinfo?([e-mail] |
                   |m)                          |
             Status|ASSIGNED                    |CLOSED
        Last Closed|                            |2023-03-24 09:43:12

--- Comment #4 from Kalev Lember  ---
Sorry for the delay on my part!

I think I'm actually going to close this review request: I was packaging
svg_metadata for loupe, but loupe has dropped the dep in
https://gitlab.gnome.org/Incubator/loupe/-/commit/42d558d22fcc870bffd7ed6d55...
just a few days ago so I don't need it packaged any more.

[Bug 2150517] Review Request: rust-svg_metadata - Extracts metadata (like the viewBox, width, and height) from SVG graphics

https://bugzilla.redhat.com/show_bug.cgi?id=2150517

--- Comment #5 from Fabio Valentini  ---
Thanks for the update!

The linked commit sure looks like dropping svg_metadata resulted in a lot fewer
dependencies ... so that's definitely nice from a packaging point of view :)