Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226283
Summary: Merge Review: perl-URI Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: nobody@fedoraproject.org QAContact: fedora-package-review@redhat.com CC: rnorwood@redhat.com
Fedora Merge Review: perl-URI
http://cvs.fedora.redhat.com/viewcvs/devel/perl-URI/ Initial Owner: rnorwood@redhat.com
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: perl-URI
https://bugzilla.redhat.com/show_bug.cgi?id=226283
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora
------- Additional Comments From panemade@gmail.com 2007-10-20 08:56 EST ------- 1)perl as BR is not needed. mock build without it worked successfully. remove redundant dependency on perl >= 1:5.6.1 2)drop "|| :" from %check 3) make test output skipped one test t/urn-isbn.......skipped all skipped: Needs the Business::ISBN module installed I think you need to add that(Business::ISBN) perl module as BR
4)rpmlint complained -> perl-URI.noarch: W: file-not-utf8 /usr/share/doc/perl-URI-1.35/Changes The character encoding of this file is not UTF-8. Consider converting it in the specfile for example using iconv(1). ==> Use iconv command
perl-URI.src: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 3) The specfile mixes use of spaces and tabs for indentation, which is a cosmetic annoyance. Use either spaces or tabs for indentation, not both. ==> Use sed
perl-URI.src: W: strange-permission filter-requires-perl-URI.sh 0755 A file that you listed to include in your package has strange permissions. Usually, a file should have 0644 permissions. ==> This can be Ignored.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: perl-URI
https://bugzilla.redhat.com/show_bug.cgi?id=226283
panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |panemade@gmail.com Status|NEW |ASSIGNED Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: perl-URI
https://bugzilla.redhat.com/show_bug.cgi?id=226283
------- Additional Comments From rnorwood@redhat.com 2007-10-25 01:04 EST ------- 1, 2, and 4) all fixed.
3) perl(Business::ISBN) is not available in Fedora yet - submitted review request here: https://bugzilla.redhat.com/show_bug.cgi?id=351761
The BR: perl(Business::ISBN) is commented out for now.
New version is 1.35-4.fc9
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: perl-URI
https://bugzilla.redhat.com/show_bug.cgi?id=226283
------- Additional Comments From panemade@gmail.com 2007-10-26 01:55 EST ------- I will wait for perl(Business::ISBN) then will review this.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: perl-URI
https://bugzilla.redhat.com/show_bug.cgi?id=226283
------- Additional Comments From panemade@gmail.com 2007-11-14 01:25 EST ------- Can you update package with adding BR: perl(Business::ISBN)?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: perl-URI
https://bugzilla.redhat.com/show_bug.cgi?id=226283
panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEEDINFO Flag| |needinfo?(rnorwood@redhat.co | |m)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: perl-URI
https://bugzilla.redhat.com/show_bug.cgi?id=226283
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Version|devel |rawhide
------- Additional Comments From panemade@gmail.com 2007-12-04 09:04 EST ------- updates please?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: perl-URI
https://bugzilla.redhat.com/show_bug.cgi?id=226283
panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora-perl-devel- | |list@redhat.com
------- Additional Comments From panemade@gmail.com 2007-12-17 12:54 EST ------- Any updates?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: perl-URI
https://bugzilla.redhat.com/show_bug.cgi?id=226283
rnorwood@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |ASSIGNED Flag|needinfo?(rnorwood@redhat.co| |m) |
------- Additional Comments From rnorwood@redhat.com 2007-12-17 13:42 EST ------- Sorry, meant to update this. Building perl-URI fails with the BR: perl(Business::ISBN) :
t/urn-isbn.......Can't locate object method "country_code" via package "Business::ISBN10" at perl-URI/devel/URI-1.35/blib/lib/URI/urn/isbn.pm line 40.
And I haven't looked into why yet. I'll take another look today.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: perl-URI
https://bugzilla.redhat.com/show_bug.cgi?id=226283
panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEEDINFO Flag| |needinfo?(rnorwood@redhat.co | |m)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: perl-URI
https://bugzilla.redhat.com/show_bug.cgi?id=226283
panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |CLOSED Resolution| |RAWHIDE Flag|fedora-review?, |fedora-review+ |needinfo?(rnorwood@redhat.co| |m) |
------- Additional Comments From panemade@gmail.com 2008-01-30 03:37 EST ------- It clearly looked like bug in tests of perl-URI as perl(Business::ISBN) does not contain country_code.
perl-Business-ISBN is new package so tests of perl-URI should be updated according to this package.
I don't want to block review here waiting tests to be fixed. You better file bug against perl-URI.
Otherwise packaging looks good. APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226283
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |ppisar@redhat.com Flag| |fedora-cvs?
--- Comment #9 from Petr Pisar ppisar@redhat.com 2012-01-20 09:44:05 EST --- Package Change Request ====================== Package Name: perl-URI Branches: f15 f16 Owners: InitialCC: perl-sig
Please add perl-sig user with watch* permissions only to all Fedora branches.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226283
--- Comment #10 from Jon Ciesla limburgher@gmail.com 2012-01-20 09:54:58 EST --- Done.
package-review@lists.fedoraproject.org