[Bug 1341099] New: Review Request: taskotron-trigger - Triggering Taskotron jobs on fedmsgs
https://bugzilla.redhat.com/show_bug.cgi?id=1341099
Bug ID: 1341099 Summary: Review Request: taskotron-trigger - Triggering Taskotron jobs on fedmsgs Product: Fedora Version: rawhide Component: Package Review Assignee: nobody@fedoraproject.org Reporter: mkrizek@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://mkrizek.fedorapeople.org/specs/taskotron-trigger.spec SRPM URL: https://mkrizek.fedorapeople.org/srpms/taskotron-trigger-0.3.16-2.fc23.src.r... Description: Triggering Taskotron jobs on fedmsgs FAS: mkrizek
https://bugzilla.redhat.com/show_bug.cgi?id=1341099
--- Comment #1 from Martin Krizek mkrizek@redhat.com --- Found some issues, updated version:
Spec URL: https://mkrizek.fedorapeople.org/specs/taskotron-trigger.spec SRPM URL: https://mkrizek.fedorapeople.org/srpms/taskotron-trigger-0.3.16-3.fc23.src.r...
https://bugzilla.redhat.com/show_bug.cgi?id=1341099
Jiri Kulda jkulda@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jkulda@redhat.com Assignee|nobody@fedoraproject.org |jkulda@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=1341099
--- Comment #2 from Jiri Kulda jkulda@redhat.com --- Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL (v2 or later)", "Unknown or generated". 20 files have unknown license. [x]: Package must own all directories that it creates. Note: Directories without known owners: /etc/logrotate.d [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required [x]: Sources contain only permissible code or content. [x]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
Python: [!]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [!]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep
===== SHOULD items =====
Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [?]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [!]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment).
Rpmlint ------- Checking: taskotron-trigger-0.3.16-3.fc22.noarch.rpm taskotron-trigger-0.3.16-3.fc22.src.rpm taskotron-trigger.noarch: W: non-standard-uid /var/log/taskotron-trigger fedmsg taskotron-trigger.noarch: W: non-standard-gid /var/log/taskotron-trigger fedmsg taskotron-trigger.noarch: E: script-without-shebang /etc/fedmsg.d/taskotron-trigger.py taskotron-trigger.noarch: W: non-conffile-in-etc /etc/fedmsg.d/taskotron-trigger.pyc taskotron-trigger.noarch: W: non-standard-uid /var/lib/taskotron-trigger fedmsg taskotron-trigger.noarch: W: non-standard-gid /var/lib/taskotron-trigger fedmsg taskotron-trigger.noarch: W: non-conffile-in-etc /etc/fedmsg.d/taskotron-trigger.pyo taskotron-trigger.noarch: W: no-manual-page-for-binary jobrunner 2 packages and 0 specfiles checked; 1 errors, 7 warnings.
Rpmlint (installed packages) ---------------------------- taskotron-trigger.noarch: W: non-standard-uid /var/log/taskotron-trigger fedmsg taskotron-trigger.noarch: W: non-standard-gid /var/log/taskotron-trigger fedmsg taskotron-trigger.noarch: E: script-without-shebang /etc/fedmsg.d/taskotron-trigger.py taskotron-trigger.noarch: W: non-conffile-in-etc /etc/fedmsg.d/taskotron-trigger.pyc taskotron-trigger.noarch: W: non-standard-uid /var/lib/taskotron-trigger fedmsg taskotron-trigger.noarch: W: non-standard-gid /var/lib/taskotron-trigger fedmsg taskotron-trigger.noarch: W: non-conffile-in-etc /etc/fedmsg.d/taskotron-trigger.pyo taskotron-trigger.noarch: W: no-manual-page-for-binary jobrunner 1 packages and 0 specfiles checked; 1 errors, 7 warnings.
Requires -------- taskotron-trigger (rpmlib, GLIBC filtered): /usr/bin/python PyYAML config(taskotron-trigger) fedmsg fedmsg-hub git koji python(abi) python-requests python-twisted
Provides -------- taskotron-trigger: config(taskotron-trigger) taskotron-trigger
Source checksums ---------------- https://qadevel.cloud.fedoraproject.org/releases/taskotron-trigger/taskotron... : CHECKSUM(SHA256) this package : daa15bea166449ae286b34dce7b253b21d8a79ebc1193dff1fe6f4b07c60a25c CHECKSUM(SHA256) upstream package : daa15bea166449ae286b34dce7b253b21d8a79ebc1193dff1fe6f4b07c60a25c
Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/usr/bin/fedora-review --rpm-spec -n Downloads/taskotron-trigger-0.3.16-3.fc23.src.rpm Buildroot used: fedora-22-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
Comments -------- - rm -rf %{buildroot} in the beginning of %install section should be removed.
- I think python will download extra dependencies listed in setup.py: moksha.hub - probably fedmsg - probably not because it is in Requires requests - Same case as fedmsg If not they need to be added into requires...
- In readme should be "In /etc/fedmsg.d/logging.py, add the following handler::" instead of "In /etc/fedmsg.d/logging, add the following handler::" but it's minority.
- In installing there should be added options for preserving timestamp
https://bugzilla.redhat.com/show_bug.cgi?id=1341099
Jaroslav Škarvada jskarvad@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jskarvad@redhat.com
--- Comment #3 from Jaroslav Škarvada jskarvad@redhat.com --- (In reply to Jiri Kulda from comment #2)
- I think python will download extra dependencies listed in setup.py: moksha.hub - probably fedmsg - probably not because it is in Requires requests - Same case as fedmsg If not they need to be added into requires...
I think these are runtime deps, IMHO they should be added to the requires.
https://bugzilla.redhat.com/show_bug.cgi?id=1341099
--- Comment #4 from Martin Krizek mkrizek@redhat.com --- (In reply to Jiri Kulda from comment #2)
Package Review
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL (v2 or later)", "Unknown or generated". 20 files have unknown license. [x]: Package must own all directories that it creates. Note: Directories without known owners: /etc/logrotate.d [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required [x]: Sources contain only permissible code or content. [x]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
Python: [!]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [!]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep
===== SHOULD items =====
Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [?]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [!]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment).
Rpmlint
Checking: taskotron-trigger-0.3.16-3.fc22.noarch.rpm taskotron-trigger-0.3.16-3.fc22.src.rpm taskotron-trigger.noarch: W: non-standard-uid /var/log/taskotron-trigger fedmsg taskotron-trigger.noarch: W: non-standard-gid /var/log/taskotron-trigger fedmsg taskotron-trigger.noarch: E: script-without-shebang /etc/fedmsg.d/taskotron-trigger.py taskotron-trigger.noarch: W: non-conffile-in-etc /etc/fedmsg.d/taskotron-trigger.pyc taskotron-trigger.noarch: W: non-standard-uid /var/lib/taskotron-trigger fedmsg taskotron-trigger.noarch: W: non-standard-gid /var/lib/taskotron-trigger fedmsg taskotron-trigger.noarch: W: non-conffile-in-etc /etc/fedmsg.d/taskotron-trigger.pyo taskotron-trigger.noarch: W: no-manual-page-for-binary jobrunner 2 packages and 0 specfiles checked; 1 errors, 7 warnings.
Rpmlint (installed packages)
taskotron-trigger.noarch: W: non-standard-uid /var/log/taskotron-trigger fedmsg taskotron-trigger.noarch: W: non-standard-gid /var/log/taskotron-trigger fedmsg taskotron-trigger.noarch: E: script-without-shebang /etc/fedmsg.d/taskotron-trigger.py taskotron-trigger.noarch: W: non-conffile-in-etc /etc/fedmsg.d/taskotron-trigger.pyc taskotron-trigger.noarch: W: non-standard-uid /var/lib/taskotron-trigger fedmsg taskotron-trigger.noarch: W: non-standard-gid /var/lib/taskotron-trigger fedmsg taskotron-trigger.noarch: W: non-conffile-in-etc /etc/fedmsg.d/taskotron-trigger.pyo taskotron-trigger.noarch: W: no-manual-page-for-binary jobrunner 1 packages and 0 specfiles checked; 1 errors, 7 warnings.
Requires
taskotron-trigger (rpmlib, GLIBC filtered): /usr/bin/python PyYAML config(taskotron-trigger) fedmsg fedmsg-hub git koji python(abi) python-requests python-twisted
Provides
taskotron-trigger: config(taskotron-trigger) taskotron-trigger
Source checksums
https://qadevel.cloud.fedoraproject.org/releases/taskotron-trigger/taskotron... trigger-0.3.16.tar.gz : CHECKSUM(SHA256) this package : daa15bea166449ae286b34dce7b253b21d8a79ebc1193dff1fe6f4b07c60a25c CHECKSUM(SHA256) upstream package : daa15bea166449ae286b34dce7b253b21d8a79ebc1193dff1fe6f4b07c60a25c
Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/usr/bin/fedora-review --rpm-spec -n Downloads/taskotron-trigger-0.3.16-3.fc23.src.rpm Buildroot used: fedora-22-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
Comments
rm -rf %{buildroot} in the beginning of %install section should be removed.
I think python will download extra dependencies listed in setup.py: moksha.hub - probably fedmsg - probably not because it is in Requires requests - Same case as fedmsg If not they need to be added into requires...
I will remove moksha.hub from setup.py upstream since it's dep of fedmsg.
- In readme should be "In /etc/fedmsg.d/logging.py, add the following
handler::" instead of "In /etc/fedmsg.d/logging, add the following handler::" but it's minority.
Good catch, will fix that upstream.
- In installing there should be added options for preserving timestamp
Thanks for the review!
Updated version: Spec URL: https://mkrizek.fedorapeople.org/specs/taskotron-trigger.spec SRPM URL: https://mkrizek.fedorapeople.org/srpms/taskotron-trigger-0.3.16-4.fc23.src.r...
https://bugzilla.redhat.com/show_bug.cgi?id=1341099
--- Comment #5 from Jiri Kulda jkulda@redhat.com --- Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. [x]: Package must own all directories that it creates. Note: Directories without known owners: /etc/logrotate.d [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep
===== SHOULD items =====
Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [!]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment).
Rpmlint ------- Checking: taskotron-trigger-0.3.16-4.fc22.noarch.rpm taskotron-trigger-0.3.16-4.fc22.src.rpm taskotron-trigger.noarch: W: non-conffile-in-etc /etc/fedmsg.d/taskotron-trigger.py taskotron-trigger.noarch: W: non-standard-uid /var/log/taskotron-trigger fedmsg taskotron-trigger.noarch: W: non-standard-gid /var/log/taskotron-trigger fedmsg taskotron-trigger.noarch: W: non-standard-uid /var/lib/taskotron-trigger fedmsg taskotron-trigger.noarch: W: non-standard-gid /var/lib/taskotron-trigger fedmsg taskotron-trigger.noarch: W: no-manual-page-for-binary jobrunner 2 packages and 0 specfiles checked; 0 errors, 6 warnings.
Rpmlint (installed packages) ---------------------------- taskotron-trigger.noarch: W: non-conffile-in-etc /etc/fedmsg.d/taskotron-trigger.py taskotron-trigger.noarch: W: non-standard-uid /var/log/taskotron-trigger fedmsg taskotron-trigger.noarch: W: non-standard-gid /var/log/taskotron-trigger fedmsg taskotron-trigger.noarch: W: non-standard-uid /var/lib/taskotron-trigger fedmsg taskotron-trigger.noarch: W: non-standard-gid /var/lib/taskotron-trigger fedmsg taskotron-trigger.noarch: W: no-manual-page-for-binary jobrunner 1 packages and 0 specfiles checked; 0 errors, 6 warnings.
Requires -------- taskotron-trigger (rpmlib, GLIBC filtered): /usr/bin/python PyYAML config(taskotron-trigger) fedmsg fedmsg-hub git koji python(abi) python-moksha-hub python-requests python-twisted
Provides -------- taskotron-trigger: config(taskotron-trigger) taskotron-trigger
Source checksums ---------------- https://qadevel.cloud.fedoraproject.org/releases/taskotron-trigger/taskotron... : CHECKSUM(SHA256) this package : daa15bea166449ae286b34dce7b253b21d8a79ebc1193dff1fe6f4b07c60a25c CHECKSUM(SHA256) upstream package : daa15bea166449ae286b34dce7b253b21d8a79ebc1193dff1fe6f4b07c60a25c
Comments -------- - Packages should try to preserve timestamps: install should have -p option to preserve timestamps
If preserving timestamps are not review blockers then It's ok with me.
https://bugzilla.redhat.com/show_bug.cgi?id=1341099
Jiri Kulda jkulda@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+
https://bugzilla.redhat.com/show_bug.cgi?id=1341099
--- Comment #6 from Jon Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/taskotron-trigger
https://bugzilla.redhat.com/show_bug.cgi?id=1341099
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- taskotron-trigger-0.4.0-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-6bd8252b0a
https://bugzilla.redhat.com/show_bug.cgi?id=1341099
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ON_QA
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- taskotron-trigger-0.4.0-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-74b0f2a36a
https://bugzilla.redhat.com/show_bug.cgi?id=1341099
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- taskotron-trigger-0.4.0-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-47efa5e800
https://bugzilla.redhat.com/show_bug.cgi?id=1341099
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- taskotron-trigger-0.4.1-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-8cc8f5a18a
https://bugzilla.redhat.com/show_bug.cgi?id=1341099
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- taskotron-trigger-0.4.1-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-5727de3374
https://bugzilla.redhat.com/show_bug.cgi?id=1341099
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- taskotron-trigger-0.4.1-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-222f28e6b3
https://bugzilla.redhat.com/show_bug.cgi?id=1341099
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- taskotron-trigger-0.4.2-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-b9394b72a1
https://bugzilla.redhat.com/show_bug.cgi?id=1341099
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1341099
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- taskotron-trigger-0.4.2-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-9c6f20ddf8
https://bugzilla.redhat.com/show_bug.cgi?id=1341099
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- taskotron-trigger-0.4.2-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-cb1f7e0ff9
https://bugzilla.redhat.com/show_bug.cgi?id=1341099
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #16 from Fedora Update System updates@fedoraproject.org --- taskotron-trigger-0.4.2-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-b9394b72a1
https://bugzilla.redhat.com/show_bug.cgi?id=1341099
--- Comment #17 from Fedora Update System updates@fedoraproject.org --- taskotron-trigger-0.4.2-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-9c6f20ddf8
https://bugzilla.redhat.com/show_bug.cgi?id=1341099
--- Comment #18 from Fedora Update System updates@fedoraproject.org --- taskotron-trigger-0.4.2-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-cb1f7e0ff9
https://bugzilla.redhat.com/show_bug.cgi?id=1341099
--- Comment #19 from Fedora Update System updates@fedoraproject.org --- taskotron-trigger-0.4.3-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-3eab8acf22
https://bugzilla.redhat.com/show_bug.cgi?id=1341099
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1341099
--- Comment #20 from Fedora Update System updates@fedoraproject.org --- taskotron-trigger-0.4.3-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-b175c3dd22
https://bugzilla.redhat.com/show_bug.cgi?id=1341099
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #21 from Fedora Update System updates@fedoraproject.org --- taskotron-trigger-0.4.3-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-3eab8acf22
https://bugzilla.redhat.com/show_bug.cgi?id=1341099
--- Comment #22 from Fedora Update System updates@fedoraproject.org --- taskotron-trigger-0.4.3-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-b175c3dd22
https://bugzilla.redhat.com/show_bug.cgi?id=1341099
--- Comment #23 from Fedora Update System updates@fedoraproject.org --- taskotron-trigger-0.4.4-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-5ad5ad7c3e
https://bugzilla.redhat.com/show_bug.cgi?id=1341099
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1341099
--- Comment #24 from Fedora Update System updates@fedoraproject.org --- taskotron-trigger-0.4.4-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-e11280f62f
https://bugzilla.redhat.com/show_bug.cgi?id=1341099
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #25 from Fedora Update System updates@fedoraproject.org --- taskotron-trigger-0.4.4-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-e11280f62f
https://bugzilla.redhat.com/show_bug.cgi?id=1341099
--- Comment #26 from Fedora Update System updates@fedoraproject.org --- taskotron-trigger-0.4.4-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-5ad5ad7c3e
https://bugzilla.redhat.com/show_bug.cgi?id=1341099
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2017-02-01 16:50:23
--- Comment #27 from Fedora Update System updates@fedoraproject.org --- taskotron-trigger-0.4.4-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1341099
--- Comment #28 from Fedora Update System updates@fedoraproject.org --- taskotron-trigger-0.4.4-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com -
Red Hat Bugzilla