Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=450483
Summary: libibmad package Product: Fedora Version: rawhide Platform: noarch URL: http://people.redhat.com/dledford/Infiniband/f10/SRPMS/ OS/Version: Linux Status: NEW Severity: low Priority: low Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: dledford@redhat.com QAContact: extras-qa@fedoraproject.org CC: fedora-package-review@redhat.com,notting@redhat.com
+++ This bug was initially created as a clone of Bug #450482 +++
+++ This bug was initially created as a clone of Bug #450481 +++
+++ This bug was initially created as a clone of Bug #450470 +++
This package is a pre-cursor, helper package to opensm, the InfiniBand subnet manager. It relies upon the libibumad package this bug was cloned from.
src rpm can be found under
http://people.redhat.com/dledford/Infiniband/f10/SRPMS/
x86_64 rpms can be found under
http://people.redhat.com/dledford/Infiniband/f10/x86_64/
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: libibmad package
https://bugzilla.redhat.com/show_bug.cgi?id=450483
dledford@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO| |450616 nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: libibmad package
https://bugzilla.redhat.com/show_bug.cgi?id=450483
ed@eh3.com changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |ed@eh3.com Status|NEW |ASSIGNED Flag| |fedora-review?
------- Additional Comments From ed@eh3.com 2008-06-28 11:01 EST ------- Hi Doug, here's a quick review:
GOOD: + source matches upstream SHA1SUM: 1a2b36d0f309690ad660c9c1ff177f76c2484104 libibcommon-1.1.0.tar.gz 1a2b36d0f309690ad660c9c1ff177f76c2484104 libibcommon-1.1.0.tar.gz.UP + license is correct and correctly included in the main package + specfile looks clean and macros sane + proper use of ldconfig + *.la files are removed + proper use of -devel and -static + has %clean + builds in mock F8 x86_64 + rpmlint reports just two ignore-able warnings: libibcommon-devel.x86_64: W: no-documentation libibcommon-static.x86_64: W: no-documentation + dir ownership looks good + permissions look good
NEEDSWORK: - according to the review guidelines, the spec must have: rm -rf %{buildroot} or the equivalent at the start of %install section. - Is the ExclusiveArch really necessary? Could it just be deleted? I'm only asking because the review guidelines now include specific rules concerning ExcludeArch and, if the ExclusiveArch is removed, then I think the package will be fine wrt those guidelines. Maybe a comment such as "is known to work on arches ... but has not been tested on ..." would be enough?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: libibmad package
https://bugzilla.redhat.com/show_bug.cgi?id=450483
------- Additional Comments From ed@eh3.com 2008-06-28 12:02 EST ------- Please ignore comment #1 above.
I'm trying to review the IB-related packages and I accidentally pasted the above comment into this bz entry. My apologies!
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: libibmad package
https://bugzilla.redhat.com/show_bug.cgi?id=450483
------- Additional Comments From ed@eh3.com 2008-06-28 14:06 EST ------- Perhaps I can paste the correct review notes into the little Firefox text box this time. Let's watch and see how it goes...
GOOD: + source matched upstream SHA1SUM: 743b35ca9257cf8f5f3d022df6161acc31301994 libibmad-1.2.0.tar.gz 743b35ca9257cf8f5f3d022df6161acc31301994 libibmad-1.2.0.tar.gz.UP + license is correct and correctly included + builds locally on F8 x86_64 w/ libibumad-devel installed + proper use of ldconfig + the *.la are deleted + permissions and dir ownership look good + rpmlint reports these two ignore-able warnings: libibmad-devel.x86_64: W: no-documentation libibmad-static.x86_64: W: no-documentation
NEEDSWORK: - please remove the ExclusiveArch: - please add "rm -rf %{buildroot}" or equivalent to the beginning of %install
Yup, I think that was the one. [*shakes head slowly and walks away*]
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: libibmad package
https://bugzilla.redhat.com/show_bug.cgi?id=450483
------- Additional Comments From dledford@redhat.com 2008-06-28 22:15 EST ------- Hehehe...%install fixed and exclusivearch removed ;-)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: libibmad package
https://bugzilla.redhat.com/show_bug.cgi?id=450483
ed@eh3.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
------- Additional Comments From ed@eh3.com 2008-06-29 09:33 EST ------- APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: libibmad package
https://bugzilla.redhat.com/show_bug.cgi?id=450483
dledford@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
------- Additional Comments From dledford@redhat.com 2008-06-30 09:21 EST ------- New Package CVS Request ======================= Package Name: libibmad Short Description: OpenFabrics Alliance InfiniBand MAD library Owners: dledford Branches: F-8 F-9 InitialCC: Cvsextras Commits: yes
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: libibmad package
https://bugzilla.redhat.com/show_bug.cgi?id=450483
kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
------- Additional Comments From kevin@tummy.com 2008-06-30 12:19 EST ------- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=450483
Bug 450483 depends on bug 450482, which changed state.
Bug 450482 Summary: libibumad package https://bugzilla.redhat.com/show_bug.cgi?id=450482
What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |RAWHIDE Status|ASSIGNED |CLOSED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=450483
Doug Ledford dledford@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |RAWHIDE Last Closed| |2012-01-03 15:59:49
package-review@lists.fedoraproject.org