https://bugzilla.redhat.com/show_bug.cgi?id=1382755
Bug ID: 1382755 Summary: Review Request: legion - A data-centric parallel programming system Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: junghans@votca.org QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: http://junghans.github.io/fedora-review/legion/legion.spec SRPM URL: http://junghans.github.io/fedora-review/legion/legion-16.10.0-1.fc26.src.rpm
Description: Legion is a data-centric parallel programming system for writing portable high performance programs targeted at distributed heterogeneous architectures. Legion presents abstractions which allow programmers to describe properties of program data (e.g. independence, locality). By making the Legion programming system aware of the structure of program data, it can automate many of the tedious tasks programmers currently face, including correctly extracting task- and data-level parallelism and moving data around complex memory hierarchies. A novel mapping interface provides explicit programmer controlled placement of data in the memory hierarchy and assignment of tasks to processors in a way that is orthogonal to correctness, thereby enabling easy porting and tuning of Legion applications to new architectures. Fedora Account System Username: junghans
fedora-review test run on Travis: Build log: https://travis-ci.org/junghans/fedora-review/builds/165850056 Raw Build log: https://s3.amazonaws.com/archive.travis-ci.org/jobs/165850057/log.txt Review.txt: http://junghans.github.io/fedora-review/legion/review.txt
https://bugzilla.redhat.com/show_bug.cgi?id=1382755
--- Comment #1 from Igor Gnatenko ignatenko@redhat.com ---
License: Apache-2.0
ASL 2.0
Group: Productivity/Networking/Other Group: Development/Libraries/C and C++
no need for that
%{_includedir}/*
this is dangerous
* Missing BuildRequires: gcc * Missing BuildRequires: gcc-c++ * Can you reorder %files sections (I was a bit confused ;))
https://bugzilla.redhat.com/show_bug.cgi?id=1382755
--- Comment #2 from Christoph Junghans junghans@votca.org --- (In reply to Igor Gnatenko from comment #1)
License: Apache-2.0
ASL 2.0
Fixed.
Group: Productivity/Networking/Other Group: Development/Libraries/C and C++
no need for that
Dropped.
%{_includedir}/*
this is dangerous
Made more specific.
- Missing BuildRequires: gcc
- Missing BuildRequires: gcc-c++
Hmm, fedora review says: Issues: ======= - All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: These BR are not needed: gcc gcc-c++ See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2
- Can you reorder %files sections (I was a bit confused ;))
Sure, done.
Spec URL: http://junghans.github.io/fedora-review/legion/legion.spec SRPM URL: http://junghans.github.io/fedora-review/legion/legion-16.10.0-1.fc26.src.rpm Review.txt: http://junghans.github.io/fedora-review/legion/review.txt Build log: https://travis-ci.org/junghans/fedora-review/builds/165966382 Raw Build log: https://s3.amazonaws.com/archive.travis-ci.org/jobs/165966383/log.txt
https://bugzilla.redhat.com/show_bug.cgi?id=1382755
--- Comment #3 from Christoph Junghans junghans@votca.org --- Undid adding gcc-c++ and added as-needed to LDFLAGS:
Spec URL: http://junghans.github.io/fedora-review/legion/legion.spec SRPM URL: http://junghans.github.io/fedora-review/legion/legion-16.10.0-1.fc26.src.rpm Review.txt: http://junghans.github.io/fedora-review/legion/review.txt Build log: https://travis-ci.org/junghans/fedora-review/builds/166379013 Raw Build log: https://s3.amazonaws.com/archive.travis-ci.org/jobs/166379014/log.txt
https://bugzilla.redhat.com/show_bug.cgi?id=1382755
--- Comment #4 from Igor Gnatenko ignatenko@redhat.com ---
Undid adding gcc-c++
By guidelines you must include all dependencies which you are using.
Don't rely completely on fedora-review. https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#...
It is important that your package list all necessary build dependencies using the BuildRequires: tag. You may assume that enough of an environment exists for RPM to function and execute basic shell scripts, but you should not assume any other packages are present as RPM dependencies and anything brought into the buildroot by the build system may change over time.
https://bugzilla.redhat.com/show_bug.cgi?id=1382755
--- Comment #5 from Christoph Junghans junghans@votca.org --- Re-added gcc-c++
Spec URL: http://junghans.github.io/fedora-review/legion/legion.spec SRPM URL: http://junghans.github.io/fedora-review/legion/legion-16.10.0-1.fc26.src.rpm Review.txt: http://junghans.github.io/fedora-review/legion/review.txt Build log: https://travis-ci.org/junghans/fedora-review/builds/166436975 Raw Build log: https://s3.amazonaws.com/archive.travis-ci.org/jobs/166436976/log.txt
https://bugzilla.redhat.com/show_bug.cgi?id=1382755
--- Comment #6 from Christoph Junghans junghans@votca.org --- @ignatenko: anything else?
https://bugzilla.redhat.com/show_bug.cgi?id=1382755
Björn "besser82" Esser fedora@besser82.io changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |fedora@besser82.io Assignee|nobody@fedoraproject.org |fedora@besser82.io Flags| |fedora-review?
--- Comment #7 from Björn "besser82" Esser fedora@besser82.io --- Taken! =)
https://bugzilla.redhat.com/show_bug.cgi?id=1382755
Christoph Junghans junghans@votca.org changed:
What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://github.com/Stanford | |Legion/legion/issues/202
--- Comment #8 from Christoph Junghans junghans@votca.org --- Arm builds are broken: http://koji.fedoraproject.org/koji/taskinfo?taskID=16199958
https://bugzilla.redhat.com/show_bug.cgi?id=1382755
--- Comment #9 from Christoph Junghans junghans@votca.org --- Excluded arm for now: http://koji.fedoraproject.org/koji/taskinfo?taskID=16243810
Spec URL http://junghans.github.io/fedora-review/legion/legion.spec SRPM URL http://junghans.github.io/fedora-review/legion/legion-16.10.0-1.fc26.src.rpm Review.txt http://junghans.github.io/fedora-review/legion/review.txt Build log https://travis-ci.org/junghans/fedora-review/builds/171508738 Raw Build log https://s3.amazonaws.com/archive.travis-ci.org/jobs/171508739/log.txt
https://bugzilla.redhat.com/show_bug.cgi?id=1382755
--- Comment #10 from Björn "besser82" Esser fedora@besser82.io --- (In reply to Christoph Junghans from comment #8)
Arm builds are broken: http://koji.fedoraproject.org/koji/taskinfo?taskID=16199958
Looks like those builds are b0rk3n, because %{arm} arches don't support SSE-instructions. Upstream should implement a workaround for this…
https://bugzilla.redhat.com/show_bug.cgi?id=1382755
--- Comment #11 from Christoph Junghans junghans@votca.org --- I fixed it https://github.com/StanfordLegion/legion/pull/204
Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=16275958 Spec URL: http://junghans.github.io/fedora-review/legion/legion.spec SRPM URL: http://junghans.github.io/fedora-review/legion/legion-16.10.0-1.fc26.src.rpm Review.txt: http://junghans.github.io/fedora-review/legion/review.txt
https://bugzilla.redhat.com/show_bug.cgi?id=1382755
--- Comment #12 from Christoph Junghans junghans@votca.org --- @besser82: I think this is ready for review now!
https://bugzilla.redhat.com/show_bug.cgi?id=1382755
--- Comment #13 from Christoph Junghans junghans@votca.org --- Added mpi subpackages: http://koji.fedoraproject.org/koji/taskinfo?taskID=16809701
https://bugzilla.redhat.com/show_bug.cgi?id=1382755
Antonio Trande anto.trande@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |anto.trande@gmail.com Flags| |needinfo?(fedora@besser82.i | |o)
https://bugzilla.redhat.com/show_bug.cgi?id=1382755
--- Comment #14 from Christoph Junghans junghans@votca.org --- ping @besser82
https://bugzilla.redhat.com/show_bug.cgi?id=1382755
--- Comment #15 from Christoph Junghans junghans@votca.org --- Bump to version 17.02.0
Task info: https://koji.fedoraproject.org/koji/taskinfo?taskID=18053736 Spec URL: http://junghans.github.io/fedora-review/legion/legion.spec SRPM URL: http://junghans.github.io/fedora-review/legion/legion-17.02.0-1.fc26.src.rpm Review.txt: http://junghans.github.io/fedora-review/legion/review.txt
https://bugzilla.redhat.com/show_bug.cgi?id=1382755
Antonio Trande anto.trande@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1382755
Antonio Trande anto.trande@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|besser82@fedoraproject.org |anto.trande@gmail.com Flags|fedora-review? | |needinfo?(besser82@fedorapr | |oject.org) |
--- Comment #16 from Antonio Trande anto.trande@gmail.com --- Taken in place of besser82.
https://bugzilla.redhat.com/show_bug.cgi?id=1382755
--- Comment #17 from Antonio Trande anto.trande@gmail.com --- - MPI builds are not using MPI compilers:
OpenMPI build must use mpic++ that's located in '/usr/lib64/openmpi/bin'. MPICH build must use mpic++ that's located in '/usr/lib64/mpich/bin'.
Force CXX flags after %{_mpich_load} and %{_openmpi_load} with:
export CXX=mpic++
- Use %{_mpich_load} and %{_openmpi_load} into '%install' section too.
- There are test files available for testing 'legion'
- *.cmake file go in '/usr/lib(64)/cmake/legion', not under /usr/share.
- 'fedora-review' tool seems not able to download src-rpm from github.io; please, use your 'fedorapeople' space if you can.
https://bugzilla.redhat.com/show_bug.cgi?id=1382755
--- Comment #18 from Christoph Junghans junghans@votca.org --- (In reply to Antonio Trande from comment #17)
- MPI builds are not using MPI compilers:
OpenMPI build must use mpic++ that's located in '/usr/lib64/openmpi/bin'. MPICH build must use mpic++ that's located in '/usr/lib64/mpich/bin'.
Force CXX flags after %{_mpich_load} and %{_openmpi_load} with:
export CXX=mpic++
Legion doesn't actually depends on MPI and hence using mpic++ as a compiler might lead to overlinking. Legion only depends on Gasnet, which comes in two mpi variants. The reason that legion looks for mpi can be found here: https://github.com/StanfordLegion/legion/pull/205 And doesn't really apply on Fedora as we are using shared libs for gasnet.
- Use %{_mpich_load} and %{_openmpi_load} into '%install' section too.
Will do.
- There are test files available for testing 'legion'
Last time I checked the tests only work in the non-cmake build system, but I will check again.
- *.cmake file go in '/usr/lib(64)/cmake/legion', not under /usr/share.
Ok.
- 'fedora-review' tool seems not able to download src-rpm from github.io;
please, use your 'fedorapeople' space if you can.
Ok, is there a way to pull the srpm from koji?
https://bugzilla.redhat.com/show_bug.cgi?id=1382755
--- Comment #20 from Christoph Junghans junghans@votca.org --- (In reply to Antonio Trande from comment #19)
(In reply to Christoph Junghans from comment #18)
(In reply to Antonio Trande from comment #17)
- MPI builds are not using MPI compilers:
OpenMPI build must use mpic++ that's located in '/usr/lib64/openmpi/bin'. MPICH build must use mpic++ that's located in '/usr/lib64/mpich/bin'.
Force CXX flags after %{_mpich_load} and %{_openmpi_load} with:
export CXX=mpic++
Legion doesn't actually depends on MPI and hence using mpic++ as a compiler might lead to overlinking. Legion only depends on Gasnet, which comes in two mpi variants. The reason that legion looks for mpi can be found here: https://github.com/StanfordLegion/legion/pull/205 And doesn't really apply on Fedora as we are using shared libs for gasnet.
Let me understand, please: Legion does not depend on MPI but neither Gasnet looks linked to mpi, in fact Legion is inheriting all undefined-non-weak-symbol from Gasnet (https://bugzilla.redhat.com/show_bug.cgi?id=1375744#c9). I'm asking to myself why Legion-MPI libraries are compiled.
Yes, legion is using gasnet to do its communication, it doesn't use mpi directly. (mpi-devel is still a build requirement as otherwise the mpi module cannot be loaded and $MPI_LIB is needed to find the right gasnet libraries.) The gasnet libraries get linked against mpi here: http://pkgs.fedoraproject.org/cgit/rpms/gasnet.git/tree/gasnet.spec#n141 and hence $ module load mpi/openmpi-x86_64 $ ldd /usr/lib64/openmpi/lib/libgasnet-mpi-par.so | grep libmpi.so libmpi.so.12 => /usr/lib64/openmpi/lib/libmpi.so.12 (0x00007fe0bdbd9000) Does that make sense?
https://bugzilla.redhat.com/show_bug.cgi?id=1382755
--- Comment #19 from Antonio Trande anto.trande@gmail.com --- (In reply to Christoph Junghans from comment #18)
(In reply to Antonio Trande from comment #17)
- MPI builds are not using MPI compilers:
OpenMPI build must use mpic++ that's located in '/usr/lib64/openmpi/bin'. MPICH build must use mpic++ that's located in '/usr/lib64/mpich/bin'.
Force CXX flags after %{_mpich_load} and %{_openmpi_load} with:
export CXX=mpic++
Legion doesn't actually depends on MPI and hence using mpic++ as a compiler might lead to overlinking. Legion only depends on Gasnet, which comes in two mpi variants. The reason that legion looks for mpi can be found here: https://github.com/StanfordLegion/legion/pull/205 And doesn't really apply on Fedora as we are using shared libs for gasnet.
Let me understand, please: Legion does not depend on MPI but neither Gasnet looks linked to mpi, in fact Legion is inheriting all undefined-non-weak-symbol from Gasnet (https://bugzilla.redhat.com/show_bug.cgi?id=1375744#c9). I'm asking to myself why Legion-MPI libraries are compiled.
- Use %{_mpich_load} and %{_openmpi_load} into '%install' section too.
Will do.
- There are test files available for testing 'legion'
Last time I checked the tests only work in the non-cmake build system, but I will check again.
- *.cmake file go in '/usr/lib(64)/cmake/legion', not under /usr/share.
Ok.
- 'fedora-review' tool seems not able to download src-rpm from github.io;
please, use your 'fedorapeople' space if you can.
Ok, is there a way to pull the srpm from koji?
No, i guess. You can use Copr.
https://bugzilla.redhat.com/show_bug.cgi?id=1382755
--- Comment #21 from Antonio Trande anto.trande@gmail.com --- (In reply to Christoph Junghans from comment #20)
(In reply to Antonio Trande from comment #19)
(In reply to Christoph Junghans from comment #18)
(In reply to Antonio Trande from comment #17)
- MPI builds are not using MPI compilers:
OpenMPI build must use mpic++ that's located in '/usr/lib64/openmpi/bin'. MPICH build must use mpic++ that's located in '/usr/lib64/mpich/bin'.
Force CXX flags after %{_mpich_load} and %{_openmpi_load} with:
export CXX=mpic++
Legion doesn't actually depends on MPI and hence using mpic++ as a compiler might lead to overlinking. Legion only depends on Gasnet, which comes in two mpi variants. The reason that legion looks for mpi can be found here: https://github.com/StanfordLegion/legion/pull/205 And doesn't really apply on Fedora as we are using shared libs for gasnet.
Let me understand, please: Legion does not depend on MPI but neither Gasnet looks linked to mpi, in fact Legion is inheriting all undefined-non-weak-symbol from Gasnet (https://bugzilla.redhat.com/show_bug.cgi?id=1375744#c9). I'm asking to myself why Legion-MPI libraries are compiled.
Yes, legion is using gasnet to do its communication, it doesn't use mpi directly. (mpi-devel is still a build requirement as otherwise the mpi module cannot be loaded and $MPI_LIB is needed to find the right gasnet libraries.) The gasnet libraries get linked against mpi here: http://pkgs.fedoraproject.org/cgit/rpms/gasnet.git/tree/gasnet.spec#n141 and hence $ module load mpi/openmpi-x86_64 $ ldd /usr/lib64/openmpi/lib/libgasnet-mpi-par.so | grep libmpi.so libmpi.so.12 => /usr/lib64/openmpi/lib/libmpi.so.12 (0x00007fe0bdbd9000) Does that make sense?
More or less. Legion uses MPI through gasnet.
https://bugzilla.redhat.com/show_bug.cgi?id=1382755
--- Comment #22 from Christoph Junghans junghans@votca.org --- All done!
Spec URL: http://junghans.github.io/fedora-review/legion/legion.spec SRPM URL: http://junghans.github.io/fedora-review/legion/legion-17.02.0-2.fc27.src.rpm or https://fedorapeople.org/cgit/junghans/public_git/fedora-review.git/tree/legion/legion-17.02.0-2.fc27.src.rpm?h=gh-pages
Review.txt: http://junghans.github.io/fedora-review/legion/review.txt Build log: https://travis-ci.org/junghans/fedora-review/builds/210704614 Raw Build log: https://s3.amazonaws.com/archive.travis-ci.org/jobs/210704615/log.txt
https://bugzilla.redhat.com/show_bug.cgi?id=1382755
--- Comment #23 from Christoph Junghans junghans@votca.org --- Sorry, or here: https://junghans.fedorapeople.org/legion-17.02.0-1.fc27.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=1382755
--- Comment #24 from Christoph Junghans junghans@votca.org --- (In reply to Christoph Junghans from comment #23)
Sorry, or here: https://junghans.fedorapeople.org/legion-17.02.0-1.fc27.src.rpm
https://junghans.fedorapeople.org/legion-17.02.0-2.fc27.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=1382755
--- Comment #25 from Antonio Trande anto.trande@gmail.com --- Tests are failing on rawhide:
+ make -C serial test make: Entering directory '/builddir/build/BUILD/legion-legion-17.02.0/serial' Running tests... /usr/bin/ctest --force-new-ctest-process Test project /builddir/build/BUILD/legion-legion-17.02.0/serial Start 1: attach_file 1/18 Test #1: attach_file ......................***Exception: SegFault 0.20 sec Start 2: circuit 2/18 Test #2: circuit ..........................***Exception: SegFault 0.07 sec Start 3: dynamic_registration 3/18 Test #3: dynamic_registration .............***Exception: SegFault 0.08 sec Start 4: ghost 4/18 Test #4: ghost ............................***Exception: SegFault 0.07 sec Start 5: ghost_pull 5/18 Test #5: ghost_pull .......................***Exception: SegFault 0.08 sec Start 6: realm_saxpy 6/18 Test #6: realm_saxpy ......................***Exception: SegFault 0.06 sec Start 7: spmd_cgsolver 7/18 Test #7: spmd_cgsolver ....................***Exception: SegFault 0.07 sec Start 8: hello_world 8/18 Test #8: hello_world ......................***Exception: SegFault 0.57 sec Start 9: tasks_and_futures 9/18 Test #9: tasks_and_futures ................***Exception: SegFault 0.07 sec Start 10: index_tasks 10/18 Test #10: index_tasks ......................***Exception: SegFault 0.07 sec Start 11: global_vars 11/18 Test #11: global_vars ......................***Exception: SegFault 0.07 sec Start 12: logical_regions 12/18 Test #12: logical_regions ..................***Exception: SegFault 0.07 sec Start 13: physical_regions 13/18 Test #13: physical_regions .................***Exception: SegFault 0.07 sec Start 14: privileges 14/18 Test #14: privileges .......................***Exception: SegFault 0.08 sec Start 15: partitioning 15/18 Test #15: partitioning .....................***Exception: SegFault 0.10 sec Start 16: multiple_partitions 16/18 Test #16: multiple_partitions ..............***Exception: SegFault 0.10 sec Start 17: custom_mapper 17/18 Test #17: custom_mapper ....................***Exception: SegFault 0.08 sec Start 18: attach_file_mini 18/18 Test #18: attach_file_mini .................***Exception: SegFault 0.08 sec 0% tests passed, 18 tests failed out of 18 Total Test time (real) = 2.01 sec The following tests FAILED: 1 - attach_file (SEGFAULT) 2 - circuit (SEGFAULT) 3 - dynamic_registration (SEGFAULT) 4 - ghost (SEGFAULT) 5 - ghost_pull (SEGFAULT) 6 - realm_saxpy (SEGFAULT) 7 - spmd_cgsolver (SEGFAULT) 8 - hello_world (SEGFAULT) 9 - tasks_and_futures (SEGFAULT) 10 - index_tasks (SEGFAULT) 11 - global_vars (SEGFAULT) 12 - logical_regions (SEGFAULT) 13 - physical_regions (SEGFAULT) 14 - privileges (SEGFAULT) 15 - partitioning (SEGFAULT) 16 - multiple_partitions (SEGFAULT) 17 - custom_mapper (SEGFAULT) 18 - attach_file_mini (SEGFAULT) Errors while running CTest
https://bugzilla.redhat.com/show_bug.cgi?id=1382755
--- Comment #26 from Christoph Junghans junghans@votca.org --- It ran on travis inside docker, is there a way to debug the koji build?
https://bugzilla.redhat.com/show_bug.cgi?id=1382755
Christoph Junghans junghans@votca.org changed:
What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://github.com/Stanford | |Legion/legion/issues/229
https://bugzilla.redhat.com/show_bug.cgi?id=1382755
Christoph Junghans junghans@votca.org changed:
What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://github.com/Stanford | |Legion/legion/issues/230
https://bugzilla.redhat.com/show_bug.cgi?id=1382755
--- Comment #27 from Antonio Trande anto.trande@gmail.com --- (In reply to Christoph Junghans from comment #26)
It ran on travis inside docker, is there a way to debug the koji build?
No, i guess. If useful, these are koji's memory limits:
buildvm's all have 10GB memory. buildhw's all have 20GB memory.
https://bugzilla.redhat.com/show_bug.cgi?id=1382755
--- Comment #28 from Christoph Junghans junghans@votca.org --- Got it, there was a return value missing for single thread systems, patch submitted and merged: https://github.com/StanfordLegion/legion/pull/232
3 tests are still failing on ppc64 due unusal core number through hwloc: https://github.com/StanfordLegion/legion/issues/233 Hopefully this will be fixed in the next release. I disabled these 3 tests on ppc64 for now.
TaskInfo: https://koji.fedoraproject.org/koji/taskinfo?taskID=18479809 Spec URL: http://junghans.github.io/fedora-review/legion/legion.spec SRPM URL: https://junghans.fedorapeople.org/legion-17.02.0-3.fc27.src.rpm Review.txt: http://junghans.github.io/fedora-review/legion/review.txt Build log: https://travis-ci.org/junghans/fedora-review/builds/212819791 Raw Build log: https://s3.amazonaws.com/archive.travis-ci.org/jobs/212819792/log.txt
https://bugzilla.redhat.com/show_bug.cgi?id=1382755
--- Comment #30 from Gwyn Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/legion
https://bugzilla.redhat.com/show_bug.cgi?id=1382755
Antonio Trande anto.trande@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #29 from Antonio Trande anto.trande@gmail.com --- Please, fix following issues. Package approved.
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
Issues: ======= - Add 'Requires: openmpi' and 'Requires: mpich'
- Spec use %global instead of %define unless justified. Note: %define requiring justification: %define testargs ARGS='-V -E \(ghost\|ghost_pull\|custom_mapper\)', %define testargs ARGS='-V'
See http://fedoraproject.org/wiki/Packaging:Guidelines#.25global_preferred_over_...
===== MUST items =====
C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "Unknown or generated", "*No copyright* Apache (v2.0)". 93 files have unknown license. Detailed output of licensecheck in /home/sagitter/1382755-legion/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib64/mpich, /usr/lib64/openmpi/lib, /usr/lib64/openmpi, /usr/lib64/cmake, /usr/lib64/mpich/lib [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 30720 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in legion- debuginfo [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Scriptlets must be sane, if used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [!]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define testargs ARGS='-V -E \(ghost\|ghost_pull\|custom_mapper\)', %define testargs ARGS='-V' [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: legion-17.02.0-3.fc27.x86_64.rpm legion-openmpi-17.02.0-3.fc27.x86_64.rpm legion-mpich-17.02.0-3.fc27.x86_64.rpm legion-devel-17.02.0-3.fc27.x86_64.rpm legion-debuginfo-17.02.0-3.fc27.x86_64.rpm legion-17.02.0-3.fc27.src.rpm legion.x86_64: W: spelling-error Summary(en_US) centric -> eccentric, centrist, concentric legion.x86_64: W: spelling-error %description -l en_US centric -> eccentric, centrist, concentric legion.x86_64: W: shared-lib-calls-exit /usr/lib64/librealm.so.1 exit@GLIBC_2.2.5 legion.x86_64: W: shared-lib-calls-exit /usr/lib64/liblegion.so.1 exit@GLIBC_2.2.5 legion.x86_64: W: hidden-file-or-dir /usr/lib/.build-id legion.x86_64: W: hidden-file-or-dir /usr/lib/.build-id legion-openmpi.x86_64: W: spelling-error %description -l en_US centric -> eccentric, centrist, concentric legion-openmpi.x86_64: W: shared-lib-calls-exit /usr/lib64/openmpi/lib/liblegion.so.1 exit@GLIBC_2.2.5 legion-openmpi.x86_64: W: shared-lib-calls-exit /usr/lib64/openmpi/lib/librealm.so.1 exit@GLIBC_2.2.5 legion-openmpi.x86_64: W: no-documentation legion-openmpi.x86_64: W: hidden-file-or-dir /usr/lib/.build-id legion-openmpi.x86_64: W: hidden-file-or-dir /usr/lib/.build-id legion-openmpi.x86_64: E: library-without-ldconfig-postin /usr/lib64/openmpi/lib/liblegion.so.1 legion-openmpi.x86_64: E: library-without-ldconfig-postun /usr/lib64/openmpi/lib/liblegion.so.1 legion-openmpi.x86_64: E: library-without-ldconfig-postin /usr/lib64/openmpi/lib/librealm.so.1 legion-openmpi.x86_64: E: library-without-ldconfig-postun /usr/lib64/openmpi/lib/librealm.so.1 legion-mpich.x86_64: W: spelling-error %description -l en_US centric -> eccentric, centrist, concentric legion-mpich.x86_64: W: shared-lib-calls-exit /usr/lib64/mpich/lib/librealm.so.1 exit@GLIBC_2.2.5 legion-mpich.x86_64: W: shared-lib-calls-exit /usr/lib64/mpich/lib/liblegion.so.1 exit@GLIBC_2.2.5 legion-mpich.x86_64: W: no-documentation legion-mpich.x86_64: W: hidden-file-or-dir /usr/lib/.build-id legion-mpich.x86_64: W: hidden-file-or-dir /usr/lib/.build-id legion-mpich.x86_64: E: library-without-ldconfig-postin /usr/lib64/mpich/lib/librealm.so.1 legion-mpich.x86_64: E: library-without-ldconfig-postun /usr/lib64/mpich/lib/librealm.so.1 legion-mpich.x86_64: E: library-without-ldconfig-postin /usr/lib64/mpich/lib/liblegion.so.1 legion-mpich.x86_64: E: library-without-ldconfig-postun /usr/lib64/mpich/lib/liblegion.so.1 legion-devel.x86_64: W: spelling-error %description -l en_US centric -> eccentric, centrist, concentric legion-devel.x86_64: W: only-non-binary-in-usr-lib legion-devel.x86_64: W: no-documentation legion.src: W: spelling-error Summary(en_US) centric -> eccentric, centrist, concentric legion.src: W: spelling-error %description -l en_US centric -> eccentric, centrist, concentric 6 packages and 0 specfiles checked; 8 errors, 23 warnings.
Rpmlint (debuginfo) ------------------- Checking: legion-debuginfo-17.02.0-3.fc27.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output:
Requires -------- legion (rpmlib, GLIBC filtered): /sbin/ldconfig ld-linux-x86-64.so.2()(64bit) libc.so.6()(64bit) libdl.so.2()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.4)(64bit) libhwloc.so.5()(64bit) liblegion.so.1()(64bit) libpthread.so.0()(64bit) librealm.so.1()(64bit) librt.so.1()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) rtld(GNU_HASH)
legion-debuginfo (rpmlib, GLIBC filtered):
legion-openmpi (rpmlib, GLIBC filtered): ld-linux-x86-64.so.2()(64bit) legion(x86-64) libc.so.6()(64bit) libdl.so.2()(64bit) libgasnet-mpi-par-1.28.2.so()(64bit)(openmpi-x86_64) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libhwloc.so.5()(64bit) liblegion.so.1()(64bit) libpthread.so.0()(64bit) librealm.so.1()(64bit) librealm.so.1()(64bit)(openmpi-x86_64) librt.so.1()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) rtld(GNU_HASH)
legion-mpich (rpmlib, GLIBC filtered): ld-linux-x86-64.so.2()(64bit) legion(x86-64) libc.so.6()(64bit) libdl.so.2()(64bit) libgasnet-mpi-par-1.28.2.so()(64bit)(mpich-x86_64) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libhwloc.so.5()(64bit) liblegion.so.1()(64bit) libpthread.so.0()(64bit) librealm.so.1()(64bit) librealm.so.1()(64bit)(mpich-x86_64) librt.so.1()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) rtld(GNU_HASH)
legion-devel (rpmlib, GLIBC filtered): legion(x86-64) legion-mpich(x86-64) legion-openmpi(x86-64) liblegion.so.1()(64bit) liblegion.so.1()(64bit)(mpich-x86_64) liblegion.so.1()(64bit)(openmpi-x86_64) librealm.so.1()(64bit) librealm.so.1()(64bit)(mpich-x86_64) librealm.so.1()(64bit)(openmpi-x86_64) mpich-devel openmpi-devel
Provides -------- legion: legion legion(x86-64) liblegion.so.1()(64bit) librealm.so.1()(64bit)
legion-debuginfo: legion-debuginfo legion-debuginfo(x86-64)
legion-openmpi: legion-openmpi legion-openmpi(x86-64) liblegion.so.1()(64bit)(openmpi-x86_64) librealm.so.1()(64bit)(openmpi-x86_64)
legion-mpich: legion-mpich legion-mpich(x86-64) liblegion.so.1()(64bit)(mpich-x86_64) librealm.so.1()(64bit)(mpich-x86_64)
legion-devel: cmake(Legion) legion-devel legion-devel(x86-64)
Source checksums ---------------- https://github.com/StanfordLegion/legion/archive/legion-17.02.0.tar.gz#/legi... : CHECKSUM(SHA256) this package : c5413fe8990c33a087c9a567671756c8267e050f5285f75ee33b84911b00c355 CHECKSUM(SHA256) upstream package : c5413fe8990c33a087c9a567671756c8267e050f5285f75ee33b84911b00c355
Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1382755 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
https://bugzilla.redhat.com/show_bug.cgi?id=1382755
--- Comment #31 from Fedora Update System updates@fedoraproject.org --- legion-17.02.0-4.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-66f593ab1a
https://bugzilla.redhat.com/show_bug.cgi?id=1382755
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1382755
--- Comment #32 from Fedora Update System updates@fedoraproject.org --- legion-17.02.0-4.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-afffad953e
https://bugzilla.redhat.com/show_bug.cgi?id=1382755
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #33 from Fedora Update System updates@fedoraproject.org --- legion-17.02.0-4.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-afffad953e
https://bugzilla.redhat.com/show_bug.cgi?id=1382755
--- Comment #34 from Fedora Update System updates@fedoraproject.org --- legion-17.02.0-4.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-66f593ab1a
https://bugzilla.redhat.com/show_bug.cgi?id=1382755
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2017-03-28 21:30:57
--- Comment #35 from Fedora Update System updates@fedoraproject.org --- legion-17.02.0-4.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1382755
--- Comment #36 from Fedora Update System updates@fedoraproject.org --- legion-17.02.0-4.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com -
Red Hat Bugzilla